[dpdk-dev] [Bug 668] DPDK power governor fails if base_frequency is not opened

[bugzilla@dpdk.org]

https://bugs.dpdk.org/show_bug.cgi?id=668

            Bug ID: 668
           Summary: DPDK power governor fails if base_frequency is not
                    opened
           Product: DPDK
           Version: 20.11
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: other
          Assignee: dev@dpdk.org
          Reporter: michallinuxstuff@gmail.com
  Target Milestone: ---

DPDK fails to initialize pstate cpufreq in case base_frequency is missing from
sysfs under given cpu. This is a bit problematic now since this particular attr
exists only under specific conditions: active intel_pstate + HWP supported by
the cpu. Also, from the commit itself (4db9587bbf) it looks like this was put
in place by accident since the part which accepts missing base_frequency (and
which sets it to 0) still exists, i.e.:


   snprintf(fullpath_base, sizeof(fullpath_base), POWER_SYSFILE_BASE_FREQ,
                        pi->lcore_id);

        f_base = fopen(fullpath_base, "r"); 
        FOPEN_OR_ERR_RET(f_base, -1); /* <- point of failure */
        if (f_base == NULL) {
                /* No sysfs base_frequency, that's OK, continue without */
                base_ratio = 0;


Initially noticed under https://github.com/spdk/spdk/issues/1859.

Any feedback on the matter would be appreciate. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.