All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [dpdk-dev] [Bug 675] net/ice: possible integer overflow when computing max_pkt_len
Date: Wed, 14 Apr 2021 06:39:07 +0000	[thread overview]
Message-ID: <bug-675-3@http.bugs.dpdk.org/> (raw)

https://bugs.dpdk.org/show_bug.cgi?id=675

            Bug ID: 675
           Summary: net/ice: possible integer overflow when computing
                    max_pkt_len
           Product: DPDK
           Version: 20.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: tudor.cornea@gmail.com
  Target Milestone: ---

Created attachment 155
  --> https://bugs.dpdk.org/attachment.cgi?id=155&action=edit
Patch with possible fix

Greetings,

While working with the Intel ice driver (E810 NIC), I have stumbled into, what
I think to be a bug, which is causing all Jumbo Frames to get dropped. 

I think that the len variable, used in the computation of max_pkt_len could
overflow, if used to store the result of the following computation:

ICE_SUPPORT_CHAIN_NUM * rxq->rx_buf_len

Since, we could define the mbuf size to have a large value (i.e 13312),
and ICE_SUPPORT_CHAIN_NUM is defined as 5, the computation mentioned above,
could potentially result in a value which might be bigger than MAX_USHORT.

The result will be that Jumbo Frames will not work properly

Could you please review the following pull request (I have also added the patch
as an attachment) ?


[1] https://github.com/DPDK/dpdk/pull/29

-- 
You are receiving this mail because:
You are the assignee for the bug.

                 reply	other threads:[~2021-04-14  6:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-675-3@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.