All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 86891] AMD/ATI Tahiti XT 7970 - long lags/stutters in games
Date: Mon, 27 Oct 2014 20:25:59 +0000	[thread overview]
Message-ID: <bug-86891-2300-6sdkBWkz1q@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-86891-2300@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=86891

--- Comment #3 from Michael Mair-Keimberger <bu9zilla@gmail.com> ---
I though it takes more time, but i already finished bisecting :)

The result:

59bc1d89d6a4d67c94a9b70fa81bda1d5b04f0cb is the first bad commit
commit 59bc1d89d6a4d67c94a9b70fa81bda1d5b04f0cb
Author: Lauri Kasanen <cand@gmx.com>
Date:   Sun Apr 20 20:29:33 2014 +0300

    drm/radeon: Inline r100_mm_rreg, -wreg, v3

    This was originally un-inlined by Andi Kleen in 2011 citing size concerns.
    Indeed, a first attempt at inlining it grew radeon.ko by 7%.

    However, 2% of cpu is spent in this function. Simply inlining it gave 1%
more fps
    in Urban Terror.

    v2: We know the minimum MMIO size. Adding it to the if allows the compiler
to
    optimize the branch out, improving both performance and size.

    The v2 patch decreases radeon.ko size by 2%. I didn't re-benchmark, but
common sense
    says perf is now more than 1% better.

    v3: Also change _wreg, make the threshold a define.

    Inlining _wreg increased the size a bit compared to v2, so now radeon.ko
    is only 1% smaller.

    Signed-off-by: Lauri Kasanen <cand@gmx.com>
    Reviewed-by: Christian König <christian.koenig@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

:040000 040000 91cde817761a93a06d21855ec896d22f03685665
e7de121e74c415308e8266c26ae7ad518d0e8530 M      drivers

This is the bad commit.


asterix linux # git bisect log
git bisect start
# bad: [7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9] Linux 3.17-rc1
git bisect bad 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9
# good: [64aa90f26c06e1cb2aacfb98a7d0eccfbd6c1a91] Linux 3.16-rc7
git bisect good 64aa90f26c06e1cb2aacfb98a7d0eccfbd6c1a91
# good: [ae045e2455429c418a418a3376301a9e5753a0a8] Merge
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
git bisect good ae045e2455429c418a418a3376301a9e5753a0a8                        
# bad: [44c916d58b9ef1f2c4aec2def57fa8289c716a60] Merge tag 'cleanup-for-3.17'
of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc                    
git bisect bad 44c916d58b9ef1f2c4aec2def57fa8289c716a60                         
# good: [e669830526a0abaf301bf408df69cde33901ac63] Merge branch 'upstream' of
git://git.linux-mips.org/pub/scm/ralf/upstream-linus                            
git bisect good e669830526a0abaf301bf408df69cde33901ac63                        
# bad: [7963e9db1b1f842fdc53309baa8714d38e9f5681] Revert "drm: drop redundant
drm_file->is_master"                                                            
git bisect bad 7963e9db1b1f842fdc53309baa8714d38e9f5681                         
# good: [8a105aaa25f4504d26ca828f12d709d2213a230e] Merge branch
'drm-armada-devel' of git://ftp.arm.linux.org.uk/~rmk/linux-arm into drm-next   
git bisect good 8a105aaa25f4504d26ca828f12d709d2213a230e                        
# good: [a2fe6cdc03d7a9b0d048a7f32f9d8827e06c67fa] drm/msm/hdmi: fix
HDMI_MUX_EN gpio request typo                                                   
git bisect good a2fe6cdc03d7a9b0d048a7f32f9d8827e06c67fa                        
# bad: [e7e31600d3e2f8b7726b0521149fc55c62a90467] drm/radeon: remove taking
mclk_lock from radeon_bo_unref                                                  
git bisect bad e7e31600d3e2f8b7726b0521149fc55c62a90467                         
# bad: [c748990b7b1c320c626c758379d50748588c6ed6] drm/radeon: Use correct value
for unknown audio/video latency                                                 
git bisect bad c748990b7b1c320c626c758379d50748588c6ed6                         
# good: [96b1b9711031a1e95e3cf15d830802aed38479a6] Merge branch
'drm_kms_for_next-v8' of git://git.linaro.org/people/benjamin.gaignard/kernel
into drm-next                                                                   
git bisect good 96b1b9711031a1e95e3cf15d830802aed38479a6                        
# good: [636e2582658742b94e7620becce58f939996c961] drm/radeon/dpm: add support
for SVI2 voltage for SI                                                         
git bisect good 636e2582658742b94e7620becce58f939996c961                        
# good: [f2c6b0f452c3804496f55655fda28c2809e1a58b] drm/radeon/cik: Add support
for new ucode format (v5)                                                       
git bisect good f2c6b0f452c3804496f55655fda28c2809e1a58b                        
# good: [da9976206c15178eeae1b4445c9266125bf35b0a] drm/radeon: enable display
scaling on all connectors (v2)                                                  
git bisect good da9976206c15178eeae1b4445c9266125bf35b0a                        
# bad: [59bc1d89d6a4d67c94a9b70fa81bda1d5b04f0cb] drm/radeon: Inline
r100_mm_rreg, -wreg, v3                                                         
git bisect bad 59bc1d89d6a4d67c94a9b70fa81bda1d5b04f0cb                         
# good: [3e22920fbd0005927bc41f71daeb056a0f4def82] drm/radeon: consolidate vga
and dvi get_modes functions (v2)                                                
git bisect good 3e22920fbd0005927bc41f71daeb056a0f4def82                        
# first bad commit: [59bc1d89d6a4d67c94a9b70fa81bda1d5b04f0cb] drm/radeon:
Inline r100_mm_rreg, -wreg, v3

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2014-10-27 20:26 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-25 15:28 [Bug 86891] New: AMD/ATI Tahiti XT 7970 - long lags/stutters in games bugzilla-daemon
2014-10-26 18:48 ` [Bug 86891] " bugzilla-daemon
2014-10-27 18:26 ` bugzilla-daemon
2014-10-27 20:25 ` bugzilla-daemon [this message]
2014-10-27 20:30 ` bugzilla-daemon
2014-10-27 22:45 ` bugzilla-daemon
2014-10-28  8:04 ` bugzilla-daemon
2014-10-29  8:46 ` bugzilla-daemon
2014-10-29 17:10 ` bugzilla-daemon
2014-10-29 17:26 ` bugzilla-daemon
2014-10-29 19:34 ` bugzilla-daemon
2014-10-29 22:04 ` bugzilla-daemon
2014-10-29 22:06 ` bugzilla-daemon
2014-10-30  3:17 ` bugzilla-daemon
2014-10-30 19:33 ` bugzilla-daemon
2014-10-30 22:29 ` bugzilla-daemon
2014-10-30 22:30 ` bugzilla-daemon
2014-10-31  3:28 ` bugzilla-daemon
2014-11-01 17:27 ` bugzilla-daemon
2014-11-01 19:45 ` bugzilla-daemon
2014-11-02 10:33 ` bugzilla-daemon
2014-11-02 10:41 ` bugzilla-daemon
2014-12-10 17:55 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-86891-2300-6sdkBWkz1q@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.