All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla at busybox.net <bugzilla@busybox.net>
To: buildroot@busybox.net
Subject: [Buildroot] [Bug 8771] make savedefconfig modifies sources
Date: Mon, 07 Mar 2016 20:23:01 +0000	[thread overview]
Message-ID: <bug-8771-163-YmX2Br27g5@https.bugs.busybox.net/> (raw)
In-Reply-To: <bug-8771-163@https.bugs.busybox.net/>

https://bugs.busybox.net/show_bug.cgi?id=8771

Thomas Petazzoni <thomas.petazzoni@free-electrons.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

--- Comment #1 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> ---
This is the expected behavior. I personally don't like it (since it deviates
from how the Linux kernel handles defconfig, and also because it's look weird),
but that's the way it's supposed to work in Buildroot.

Basically, the defconfig is stored to the file pointed by BR2_DEFCONFIG. By
default, this option is set to $(CONFIG_DIR)/defconfig, which would do what you
want, i.e save the defconfig next to the .config file.

However, when you run "make <foobar>_defconfig", we set BR2_DEFCONFIG to
"configs/<foobar>_defconfig". The original intent is to make things
"transparent": if you start from a defconfig, the assumption is that you want
changes made to this configuration to be saved back to the same defconfig.

You can override this at any time by changing BR2_DEFCONFIG in
menuconfig/xconfig/nconfig, or simply on the command line by passing
BR2_DEFCONFIG="/some/place".

As I said, I personally don't really like this behavior, and I got confused
several times. The fact that the source tree is modified is indeed another
drawback of this behavior. However, I didn't find this to be too problematic to
really argue against the contributors who wanted this feature.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  reply	other threads:[~2016-03-07 20:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-07 18:43 [Buildroot] [Bug 8771] New: make savedefconfig modifies sources bugzilla at busybox.net
2016-03-07 20:23 ` bugzilla at busybox.net [this message]
2016-03-07 23:39   ` [Buildroot] [Bug 8771] " Arnout Vandecappelle
2016-03-08  8:06     ` Thomas Petazzoni
2016-03-08 11:36       ` Peter Korsgaard
2016-03-08 17:01       ` Steve Calfee
2016-03-08 17:38         ` Arnout Vandecappelle
2016-03-08 18:06           ` Steve Calfee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-8771-163-YmX2Br27g5@https.bugs.busybox.net/ \
    --to=bugzilla@busybox.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.