From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 91015] Piglit regression: spec/ARB_occlusion_query2/api
Date: Mon, 22 Jun 2015 17:32:51 +0000 [thread overview]
Message-ID: <bug-91015-502-Gl2U4jidxJ@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-91015-502@http.bugs.freedesktop.org/>
[-- Attachment #1.1: Type: text/plain, Size: 1673 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=91015
--- Comment #3 from Ian Romanick <idr@freedesktop.org> ---
The following two piglit commits are probably necessary:
commit 49e326474d5ed487d04ff6bef1efae376e4a2492
Author: Eduardo Lima Mitev <elima@igalia.com>
Date: Mon Feb 16 11:10:30 2015 +0100
arb_occlusion_query2: Checks that query obj passed to glBeginQuery matches
target
From the OpenGL 3.3 spec, section "2.14. ASYNCHRONOUS QUERIES", page 94:
"[...] if id is the name of an existing query object whose type does
not
match target, [...] the error INVALID_OPERATION is generated."
Similar wording exists in the OpenGL ES 3.0.0 spec, section "2.13.
ASYNCHRONOUS QUERIES", page 82.
This patch adds a check for this situation.
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
commit 0eff6819639d8c84c98f8fa0bd0b254a69aead60
Author: Eduardo Lima Mitev <elima@igalia.com>
Date: Sat Feb 14 13:29:52 2015 +0100
arb_occlusion_query2: expect an error when target mismatch in
glBeginQuery()
From the OpenGL 3.3 spec, section "2.14. ASYNCHRONOUS QUERIES", page 94:
"[...] if id is the name of an existing query object whose type does
not
match target, [...] the error INVALID_OPERATION is generated."
Similar wording exists in the OpenGL ES 3.0.0 spec, section "2.13.
ASYNCHRONOUS QUERIES", page 82.
Hence, trying to call BeginQuery on a query object which has already
been bound to a different target should return GL_INVALID_OPERATION.
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2720 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-06-22 17:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-91015-502@http.bugs.freedesktop.org/>
2015-06-18 6:47 ` [Bug 91015] Piglit regression: spec/ARB_occlusion_query2/api bugzilla-daemon
2015-06-22 17:01 ` bugzilla-daemon
2015-06-22 17:19 ` bugzilla-daemon
2015-06-22 17:32 ` bugzilla-daemon [this message]
2015-06-22 18:18 ` bugzilla-daemon
2015-06-22 19:11 ` bugzilla-daemon
2019-09-18 19:30 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-91015-502-Gl2U4jidxJ@http.bugs.freedesktop.org/ \
--to=bugzilla-daemon@freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.