From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ@public.gmane.org Subject: [Bug 92377] New: Add support for early voltage table as seen on nv43 Date: Sat, 10 Oct 2015 05:07:52 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0548912045==" Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: nouveau.vger.kernel.org --===============0548912045== Content-Type: multipart/alternative; boundary="1444453672.A28BFEC71.19905"; charset="UTF-8" --1444453672.A28BFEC71.19905 Date: Sat, 10 Oct 2015 05:07:52 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=92377 Bug ID: 92377 Summary: Add support for early voltage table as seen on nv43 Product: xorg Version: git Hardware: x86 (IA32) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: Driver/nouveau Assignee: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Reporter: randrik-JGs/UdohzUI@public.gmane.org QA Contact: xorg-team-go0+a7rfsptAfugRpC6u6w@public.gmane.org Created attachment 118791 --> https://bugs.freedesktop.org/attachment.cgi?id=118791&action=edit vbios as extracted by envytools Latest nouveau (after 4.2) started to refuse to change clocks on my nv43 board. Investigation showed it was simply failing to find voltage table, while such table was recognized by nvbios tool from envytools. So, I've added patch along those lines: diff --git a/drm/nouveau/nvkm/subdev/bios/volt.c b/drm/nouveau/nvkm/subdev/bios/volt.c index 6e0a336..3e9dafa 100644 --- a/drm/nouveau/nvkm/subdev/bios/volt.c +++ b/drm/nouveau/nvkm/subdev/bios/volt.c @@ -40,8 +40,10 @@ nvbios_volt_table(struct nvkm_bios *bios, u8 *ver, u8 *hdr, u8 *cnt, u8 *len) if (volt) { *ver = nvbios_rd08(bios, volt + 0); + printk ("nvbios_volt_table_Ver, %d\n", *ver); switch (*ver) { case 0x12: + case 0x10: *hdr = 5; *cnt = nvbios_rd08(bios, volt + 2); *len = nvbios_rd08(bios, volt + 1); @@ -71,8 +73,11 @@ nvbios_volt_parse(struct nvkm_bios *bios, u8 *ver, u8 *hdr, u8 *cnt, u8 *len, { u16 volt = nvbios_volt_table(bios, ver, hdr, cnt, len); memset(info, 0x00, sizeof(*info)); + printk("nvbios_volt_parse called!\n"); + printk("volt_table_Version: %d\n", !!volt * *ver); switch (!!volt * *ver) { case 0x12: + case 0x10: info->type = NVBIOS_VOLT_GPIO; info->vidmask = nvbios_rd08(bios, volt + 0x04); break; @@ -131,8 +136,10 @@ nvbios_volt_entry_parse(struct nvkm_bios *bios, int idx, u8 *ver, u8 *len, { u16 volt = nvbios_volt_entry(bios, idx, ver, len); memset(info, 0x00, sizeof(*info)); + printk("nvbios_volt_entry_parse called!\n"); switch (!!volt * *ver) { case 0x12: + case 0x10: case 0x20: info->voltage = nvbios_rd08(bios, volt + 0x00) * 10000; info->vid = nvbios_rd08(bios, volt + 0x01); and it seems to work. -- You are receiving this mail because: You are the assignee for the bug. --1444453672.A28BFEC71.19905 Date: Sat, 10 Oct 2015 05:07:52 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"
Bug ID 92377
Summary Add support for early voltage table as seen on nv43
Product xorg
Version git
Hardware x86 (IA32)
OS Linux (All)
Status NEW
Severity normal
Priority medium
Component Driver/nouveau
Assignee nouveau@lists.freedesktop.org
Reporter randrik@mail.ru
QA Contact xorg-team@lists.x.org 

Created attachment 118791 [details]
vbios as extracted by envytools

Latest nouveau (after 4.2) started to refuse to change clocks on my nv43 board.
Investigation showed it was simply failing to find voltage table, while such
table was recognized by nvbios tool from envytools.

So, I've added patch along those lines:



    diff --git a/drm/nouveau/nvkm/subdev/bios/volt.c
b/drm/nouveau/nvkm/subdev/bios/volt.c
    index 6e0a336..3e9dafa 100644
    --- a/drm/nouveau/nvkm/subdev/bios/volt.c
    +++ b/drm/nouveau/nvkm/subdev/bios/volt.c
    @@ -40,8 +40,10 @@ nvbios_volt_table(struct nvkm_bios *bios, u8 *ver, u8
*hdr, u8 *cnt, u8 *len)

                    if (volt) {
                            *ver = nvbios_rd08(bios, volt + 0);
    +                       printk ("nvbios_volt_table_Ver, %d\n", *ver);
                            switch (*ver) {
                            case 0x12:
    +                       case 0x10:
                                    *hdr = 5;
                                    *cnt = nvbios_rd08(bios, volt + 2);
                                    *len = nvbios_rd08(bios, volt + 1);
    @@ -71,8 +73,11 @@ nvbios_volt_parse(struct nvkm_bios *bios, u8 *ver, u8
*hdr, u8 *cnt, u8 *len,
     {
            u16 volt = nvbios_volt_table(bios, ver, hdr, cnt, len);
            memset(info, 0x00, sizeof(*info));
    +       printk("nvbios_volt_parse called!\n");
    +       printk("volt_table_Version: %d\n", !!volt * *ver);
            switch (!!volt * *ver) {
            case 0x12:
    +       case 0x10:
                    info->type    = NVBIOS_VOLT_GPIO;
                    info->vidmask = nvbios_rd08(bios, volt + 0x04);
                    break;
    @@ -131,8 +136,10 @@ nvbios_volt_entry_parse(struct nvkm_bios *bios, int
idx, u8 *ver, u8 *len,
     {
            u16 volt = nvbios_volt_entry(bios, idx, ver, len);
            memset(info, 0x00, sizeof(*info));
    +       printk("nvbios_volt_entry_parse called!\n");
            switch (!!volt * *ver) {
            case 0x12:
    +       case 0x10:
            case 0x20:
                    info->voltage = nvbios_rd08(bios, volt + 0x00) * 10000;
                    info->vid     = nvbios_rd08(bios, volt + 0x01);


and it seems to work.

You are receiving this mail because:
  • You are the assignee for the bug.
--1444453672.A28BFEC71.19905-- --===============0548912045== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTm91dmVhdSBt YWlsaW5nIGxpc3QKTm91dmVhdUBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL25vdXZlYXUK --===============0548912045==--