| Bug ID | 93236 |
|---|---|
| Summary | Tonga garbled desktop since amdgpu/gfxv8: Cleanup of gfx_v8_0_tiling_mode_table_init() |
| Product | DRI |
| Version | DRI git |
| Hardware | Other |
| OS | All |
| Status | NEW |
| Severity | normal |
| Priority | medium |
| Component | DRM/AMDgpu |
| Assignee | dri-devel@lists.freedesktop.org |
| Reporter | adf.lists@gmail.com |
Created attachment 120318 [details] An xwd showing corrupted desktop. Tried the latest powerplay today and I get a shredded desktop (fluxbox) as soon as I startx. Apart from the X corruption everything else seems OK, fbcon is OK. Seems to be - commit 3e199b1535a70d6169fd11ee309f8bc4c8ba5bb9 Author: Tom St Denis <tom.stdenis@amd.com> Date: Tue Dec 1 11:47:21 2015 -0500 amdgpu/gfxv8: Cleanup of gfx_v8_0_tiling_mode_table_init() Simplification and LOC reduction of function gfx_v8_0_tiling_mode_table_init()
| What | Removed | Added |
|---|---|---|
| Attachment #120318 mime type | text/plain | image/png |
Seems this is because there is no longer a default as there was in the case statement. If I add a couple of printk sitting on the commit before "bad" I hit the default case during bootup (before I startx). [ 5.030315] ADF: Hit first default, reg_offset = 31 [ 5.030406] ADF: Hit second default, reg_offset = 15 diff and full dmesg attached to show timing/position of output.
Created attachment 120338 [details]
dmesg with debugging output
Of course had I looked at the code rather than just the diff on fdo cgit I wouldn't have needed to bother with printks - const u32 num_tile_mode_states = 32; const u32 num_secondary_tile_mode_states = 16;
Ugh never mind, I see that the last slot should already be set to 0 :-( Where's the delete post button :-)
Created attachment 120343 [details]
removes stray break
OK I think I've found it now.
There's a stray break in the TONGA bit of the new code.
After a quick search I can't find any others.
| What | Removed | Added |
|---|---|---|
| Status | NEW | RESOLVED |
| Resolution | --- | FIXED |