All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla at busybox.net <bugzilla@busybox.net>
To: buildroot@busybox.net
Subject: [Buildroot] [Bug 9596] KODI: --enable-lirc needs "HAVE_LIRC" compiler definition to use the lirc subsystem
Date: Sun, 26 Feb 2017 14:28:18 +0000	[thread overview]
Message-ID: <bug-9596-163-gvFslTI3gt@https.bugs.busybox.net/> (raw)
In-Reply-To: <bug-9596-163@https.bugs.busybox.net/>

https://bugs.busybox.net/show_bug.cgi?id=9596

--- Comment #2 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> ---
I don't see why this is needed: when --enable-lirc is passed, and the lirc
library is found, the configure script defines HAVE_LIRC:

AC_ARG_ENABLE([lirc],
  [AS_HELP_STRING([--disable-lirc],
  [disable lirc support (default is enabled)])],
  [AC_MSG_RESULT("Lirc disabled")],
  [AC_DEFINE([HAVE_LIRC], [1], ["Lirc enabled"])])

And then, when HAVE_LIRC is defined, HAS_LIRC gets defined by xbmc/system.h:

#ifdef HAVE_LIRC
#define HAS_LIRC
#endif

And HAS_LIRC is the define being tested at the code you point to.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2017-02-26 14:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-18  3:48 [Buildroot] [Bug 9596] New: KODI: --enable-lirc needs "HAVE_LIRC" compiler definition to use the lirc subsystem bugzilla at busybox.net
2017-01-18  3:59 ` [Buildroot] [Bug 9596] " bugzilla at busybox.net
2017-01-20  5:46 ` bugzilla at busybox.net
2017-02-26 14:28 ` bugzilla at busybox.net [this message]
2017-02-26 15:56 ` bugzilla at busybox.net
2017-05-07 12:11 ` bugzilla at busybox.net
2017-05-07 14:07 ` bugzilla at busybox.net

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-9596-163-gvFslTI3gt@https.bugs.busybox.net/ \
    --to=bugzilla@busybox.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.