From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 97273] [r600g, bisected] regression: NI/Turks WebGL (FishGL) massive speed decrease ~33% Date: Wed, 10 Aug 2016 04:12:46 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0932843705==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 4A61A6E6C7 for ; Wed, 10 Aug 2016 04:12:46 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0932843705== Content-Type: multipart/alternative; boundary="14708023660.74B2.8581"; charset="UTF-8" --14708023660.74B2.8581 Date: Wed, 10 Aug 2016 04:12:46 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D97273 Bug ID: 97273 Summary: [r600g, bisected] regression: NI/Turks WebGL (FishGL) massive speed decrease ~33% Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 Assignee: dri-devel@lists.freedesktop.org Reporter: Dieter@nuetzel-hh.de QA Contact: dri-devel@lists.freedesktop.org Current Mesa (git-3f100b7) and some stable versions show massive speed decr= ease on FishGL (WebGL) demo with konqueror 4.14.8 (KDE 4.14.9). http://www.fishgl.com/ look at the aquarium: ~60 fps -> ~40 fps look from inside (diver): ~30 fps -> ~20 fps I've bisected it to: /opt/mesa> git bisect good=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20 3735a925ef5692c836c4d26d6adee370dae1c2b0 is the first bad commit commit 3735a925ef5692c836c4d26d6adee370dae1c2b0 Author: Nicolai H=C3=A4hnle Date: Wed Jun 8 13:24:14 2016 +0200 st/mesa: cache staging texture for glReadPixels v2: add ST_DEBUG flag for disabling (suggested by Ilia) Reviewed-by: Marek Ol=C5=A1=C3=A1k (v1) :040000 040000 f3adb5adc43e4def32bd23896489520d8cae84c6 72b374e2221e9cc1306d7bfacf39780ec5e42d36 Msrc https://cgit.freedesktop.org/mesa/mesa/log/?ofs=3D1150 Revert didn't went smooth, so I've commented: diff --git a/src/mesa/state_tracker/st_cb_readpixels.c b/src/mesa/state_tracker/st_cb_readpixels.c index 8eb839d..3af9530 100644 --- a/src/mesa/state_tracker/st_cb_readpixels.c +++ b/src/mesa/state_tracker/st_cb_readpixels.c @@ -329,7 +329,7 @@ try_cached_readpixels(struct st_context *st, struct st_renderbuffer *strb, struct pipe_resource *src =3D strb->texture; struct pipe_resource *dst =3D NULL; - if (ST_DEBUG & DEBUG_NOREADPIXCACHE) + /* if (ST_DEBUG & DEBUG_NOREADPIXCACHE) */ return NULL; /* Reset cache after invalidation or switch of parameters. */ After that speed was 'normal'. --=20 You are receiving this mail because: You are the assignee for the bug.= --14708023660.74B2.8581 Date: Wed, 10 Aug 2016 04:12:46 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated
Bug ID 97273
Summary [r600g, bisected] regression: NI/Turks WebGL (FishGL) massive= speed decrease ~33%
Product Mesa
Version git
Hardware x86-64 (AMD64)
OS Linux (All)
Status NEW
Severity normal
Priority medium
Component Drivers/Gallium/r600
Assignee dri-devel@lists.freedesktop.org
Reporter Dieter@nuetzel-hh.de
QA Contact dri-devel@lists.freedesktop.org 

Current Mesa (git-3f100b7) and some stable versions show massi=
ve speed decrease
on FishGL (WebGL) demo with konqueror 4.14.8 (KDE 4.14.9).

http://www.fishgl.com/

look at the aquarium: ~60 fps -> ~40 fps
look from inside (diver): ~30 fps -> ~20 fps

I've bisected it to:

/opt/mesa> git bisect good=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20
                  3735a925ef5692c836c4d26d6adee370dae1c2b0 is the first bad
commit
commit 3735a925ef5692c836c4d26d6adee370dae1c2b0
Author: Nicolai H=C3=A4hnle <nicolai.haehnle@amd.com>
Date:   Wed Jun 8 13:24:14 2016 +0200

    st/mesa: cache staging texture for glReadPixels

    v2: add ST_DEBUG flag for disabling (suggested by Ilia)

    Reviewed-by: Marek Ol=C5=A1=C3=A1k <marek.olsak@amd.com> (v1)

:040000 040000 f3adb5adc43e4def32bd23896489520d8cae84c6
72b374e2221e9cc1306d7bfacf39780ec5e42d36 Msrc

https://=
cgit.freedesktop.org/mesa/mesa/log/?ofs=3D1150

Revert didn't went smooth, so I've commented:

diff --git a/src/mesa/state_tracker/st_cb_readpixels.c
b/src/mesa/state_tracker/st_cb_readpixels.c
index 8eb839d..3af9530 100644
--- a/src/mesa/state_tracker/st_cb_readpixels.c
+++ b/src/mesa/state_tracker/st_cb_readpixels.c
@@ -329,7 +329,7 @@ try_cached_readpixels(struct st_context=
 *st, struct
st_renderbuffer *strb,
    struct pipe_resource *src =3D strb->texture;
    struct pipe_resource *dst =3D NULL;

-   if (ST_DEBUG & DEBUG_NOREADPIXCACHE)
+ /*  if (ST_DEBUG & DEBUG_NOREADPIXCACHE) */
       return NULL;

    /* Reset cache after invalidation or switch of parameters. */

After that speed was 'normal'.

You are receiving this mail because:
  • You are the assignee for the bug.
= --14708023660.74B2.8581-- --===============0932843705== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0932843705==--