From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 97477] i915g: gl_FragCoord is always (0.0, max_y) Date: Thu, 25 Aug 2016 05:16:17 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0524454052==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 6E8A26E8E2 for ; Thu, 25 Aug 2016 05:16:17 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0524454052== Content-Type: multipart/alternative; boundary="14721021770.bADcB1.28061"; charset="UTF-8" --14721021770.bADcB1.28061 Date: Thu, 25 Aug 2016 05:16:17 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D97477 Bug ID: 97477 Summary: i915g: gl_FragCoord is always (0.0, max_y) Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/i915g Assignee: dri-devel@lists.freedesktop.org Reporter: nicholasbishop@gmail.com QA Contact: dri-devel@lists.freedesktop.org Created attachment 126029 --> https://bugs.freedesktop.org/attachment.cgi?id=3D126029&action=3Dedit Patch: Handle I915_SEMANTIC_POS when setting texCoords for gl_FragCoord On Intel Pineview M hardware, the i915 gallium driver doesn't output the correct gl_FragCoord. It seems to always have an X coord of 0.0 and a Y coo= rd of the window's height in pixels, e.g. 600.0f or such. I believe this is a regression caused in part by commit afa035031ff9e0c07a2297d864e46c76f7bfff58 (https://lists.freedesktop.org/archives/mesa-commit/2016-January/061181.htm= l) The old behavior used output zero, while the new behavior uses actual zeroe= s. In the case of gl_FragCoord output zero happened to be the correct one. I've attached a patch that seems to fix the issue for me. I ran the piglit "quick" tests and observed 17 new tests passing, and one regression. I susp= ect the regression is unimportant since it involves derivatives that aren't implemented for this driver anyway: "fs-dfdy-accuracy" test failed ... in i915_fpc_translate.c: case TGSI_OPCODE_DDY: /* XXX We just output 0 here */ debug_printf("Punting DDX/DDX\n"); --=20 You are receiving this mail because: You are the assignee for the bug.= --14721021770.bADcB1.28061 Date: Thu, 25 Aug 2016 05:16:17 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated
Bug ID 97477
Summary i915g: gl_FragCoord is always (0.0, max_y)
Product Mesa
Version git
Hardware Other
OS All
Status NEW
Severity normal
Priority medium
Component Drivers/Gallium/i915g
Assignee dri-devel@lists.freedesktop.org
Reporter nicholasbishop@gmail.com
QA Contact dri-devel@lists.freedesktop.org 

Created attachment 126029 [details] [revie=
w]
Patch: Handle I915_SEMANTIC_POS when setting texCoords for gl_FragCoord

On Intel Pineview M hardware, the i915 gallium driver doesn't output the
correct gl_FragCoord. It seems to always have an X coord of 0.0 and a Y coo=
rd
of the window's height in pixels, e.g. 600.0f or such.

I believe this is a regression caused in part by commit
afa035031ff9e0c07a2297d864e46c76f7bfff58
(https://lists.freedesktop.org/archives/mesa-commit/2016-Janua=
ry/061181.html)

The old behavior used output zero, while the new behavior uses actual zeroe=
s.
In the case of gl_FragCoord output zero happened to be the correct one.

I've attached a patch that seems to fix the issue for me. I ran the piglit
"quick" tests and observed 17 new tests passing, and one regressi=
on. I suspect
the regression is unimportant since it involves derivatives that aren't
implemented for this driver anyway:

"fs-dfdy-accuracy" test failed ... in i915_fpc_translate.c:
case TGSI_OPCODE_DDY:
      /* XXX We just output 0 here */
      debug_printf("Punting DDX/DDX\n");

You are receiving this mail because:
  • You are the assignee for the bug.
= --14721021770.bADcB1.28061-- --===============0524454052== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0524454052==--