All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 97882] [amdgpu SI] amdgpu on SI devices is much slower then radeon
Date: Tue, 01 Aug 2017 02:18:49 +0000	[thread overview]
Message-ID: <bug-97882-502-OK09LsMEXd@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-97882-502@http.bugs.freedesktop.org/>


[-- Attachment #1.1: Type: text/plain, Size: 1259 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97882

--- Comment #7 from Trevor Davenport <trevor.davenport@gmail.com> ---
This is fixed by the following commit:


author  Jean Delvare <jdelvare@suse.de> 2017-07-30 08:18:25 (GMT)
committer       Alex Deucher <alexander.deucher@amd.com>        2017-07-31
20:30:42 (GMT)
commit  e5c8d400da67abc1c033b9a4af1806926b55e5f6 (patch)
tree    cf3dac459890ed900416d4087ae0603d4aa42b6f
parent  29805b5f60d88c56ae7e91ae231f0ff8bf1983b8 (diff)

drm/amdgpu: Fix undue fallthroughs in golden registers initialization

As I was staring at the si_init_golden_registers code, I noticed that
the Pitcairn initialization silently falls through the Cape Verde
initialization, and the Oland initialization falls through the Hainan
initialization. However there is no comment stating that this is
intentional, and the radeon driver doesn't have any such fallthrough,
so I suspect this is not supposed to happen.

Commit can be seen here:
https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.14-wip&id=e5c8d400da67abc1c033b9a4af1806926b55e5f6

With this fix I now get performance approximately equal to that of radeon.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2320 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2017-08-01  2:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21  0:48 [Bug 97882] [amdgpu SI] amdgpu on SI devices is much slower then radeon bugzilla-daemon
2016-09-21  0:49 ` bugzilla-daemon
2016-09-21  0:53 ` bugzilla-daemon
2017-05-22 14:27 ` bugzilla-daemon
2017-05-22 14:33 ` bugzilla-daemon
2017-05-22 15:07 ` bugzilla-daemon
2017-05-22 15:22 ` bugzilla-daemon
2017-08-01  2:18 ` bugzilla-daemon [this message]
2017-08-01  2:21 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-97882-502-OK09LsMEXd@http.bugs.freedesktop.org/ \
    --to=bugzilla-daemon@freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.