From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 98505] [Topaz] Regression introduces in 4.8-rc3 Date: Tue, 01 Nov 2016 23:31:40 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1791013458==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id AE4BF89D5F for ; Tue, 1 Nov 2016 23:31:40 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1791013458== Content-Type: multipart/alternative; boundary="14780431000.8b7a5EE.24250"; charset="UTF-8" --14780431000.8b7a5EE.24250 Date: Tue, 1 Nov 2016 23:31:40 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D98505 --- Comment #7 from Peter Wu --- Created attachment 127678 --> https://bugs.freedesktop.org/attachment.cgi?id=3D127678&action=3Dedit amdgpu patch that checks whether the new interface can be used for PM PCIe port PM is not enabled because this BIOS is pre-2015: 12/04/2014 The BIOS seems to be able to report support for lots of things (can you pos= t a fuller dmesg that include the supported functions?): Scope (\_SB.PCI0.GFX0) { Method (ATPX, 2, Serialized) { // ... If (Arg0 =3D=3D One) { Name (TMP2, Buffer (0x0100) { 0x00 }) CreateWordField (TMP2, Zero, F1SS) CreateDWordField (TMP2, 0x02, F1VM) CreateDWordField (TMP2, 0x06, F1FG) F1SS =3D 0x0A F1VM =3D 0x7FC0 If ((\_SB.PCI0.RP05.PXSX.SGMD & 0x0F) =3D=3D 0x02) { // ... If (\_SB.PCI0.RP05.PXSX.PXDY =3D=3D One) { F1FG |=3D 0x80 /* ATPX_DYNAMIC_PX_SUPPORTED */ F1VM |=3D 0x80 } // If (\_SB.PCI0.RP05.PXSX.FDPD =3D=3D One) { F1FG |=3D 0x0400 /* ATPX_DYNAMIC_DGPU_POWER_OFF_SUP= PORTED */ F1VM |=3D 0x0400 If (OSYS >=3D 0x07DC) { F1FG |=3D 0x0800 /* ATPX_DGPU_REQ_POWER_FOR_DIS= PLAYS */ F1VM |=3D 0x0800 } } // ... If (OSYS >=3D 0x07DD) { F1FG |=3D 0x4000 /* ATPX_MS_HYBRID_GFX_SUPPORTED */= =20 F1VM |=3D 0x4000 } amdgpu (and radeon) needs to check whether PCIe port PM is really supported. Possible patch is attached (there should probably be a pci_d3cold_disable c= all somewhere, see commit 279cf3f23870f7eb8ca071115e06d3d5ca0a2b9e for nouveau). --=20 You are receiving this mail because: You are the assignee for the bug.= --14780431000.8b7a5EE.24250 Date: Tue, 1 Nov 2016 23:31:40 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comment= # 7 on bug 98505<= /a> from Peter Wu 
Created attachment 127678 [details] [review]
amdgpu patch that checks whether the new interface can be used for PM

PCIe port PM is not enabled because this BIOS is pre-2015: 12/04/2014
The BIOS seems to be able to report support for lots of things (can you pos=
t a
fuller dmesg that include the supported functions?):

    Scope (\_SB.PCI0.GFX0) {
        Method (ATPX, 2, Serialized) {
            // ...
            If (Arg0 =3D=3D One) {
                Name (TMP2, Buffer (0x0100) { 0x00 })
                CreateWordField (TMP2, Zero, F1SS)
                CreateDWordField (TMP2, 0x02, F1VM)
                CreateDWordField (TMP2, 0x06, F1FG)
                F1SS =3D 0x0A
                F1VM =3D 0x7FC0
                If ((\_SB.PCI0.RP05.PXSX.SGMD & 0x0F) =3D=3D 0x02) {
                    // ...
                    If (\_SB.PCI0.RP05.PXSX.PXDY =3D=3D One) {
                        F1FG |=3D 0x80 /* ATPX_DYNAMIC_PX_SUPPORTED */
                        F1VM |=3D 0x80
                    }
                    //
                    If (\_SB.PCI0.RP05.PXSX.FDPD =3D=3D One) {
                        F1FG |=3D 0x0400 /* ATPX_DYNAMIC_DGPU_POWER_OFF_SUP=
PORTED
*/
                        F1VM |=3D 0x0400
                        If (OSYS >=3D 0x07DC) {
                            F1FG |=3D 0x0800 /* ATPX_DGPU_REQ_POWER_FOR_DIS=
PLAYS
*/
                            F1VM |=3D 0x0800
                        }
                    }
                    // ...
                    If (OSYS >=3D 0x07DD) {
                        F1FG |=3D 0x4000 /* ATPX_MS_HYBRID_GFX_SUPPORTED */=
=20
                        F1VM |=3D 0x4000
                    }

amdgpu (and radeon) needs to check whether PCIe port PM is really supported.
Possible patch is attached (there should probably be a pci_d3cold_disable c=
all
somewhere, see commit 279cf3f23870f7eb8ca071115e06d3d5ca0a2b9e for nouveau)=
.

You are receiving this mail because:
  • You are the assignee for the bug.
= --14780431000.8b7a5EE.24250-- --===============1791013458== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1791013458==--