From: Miles Bader <miles@gnu.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
Johannes Sixt <j.sixt@viscovery.net>,
git@vger.kernel.org
Subject: Re: [PATCH] setup_revisions(): do not access outside argv
Date: Thu, 21 May 2009 11:38:25 +0900 [thread overview]
Message-ID: <buoljor6uzi.fsf@dhlpc061.dev.necel.com> (raw)
In-Reply-To: <7v7i0btdwu.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Wed, 20 May 2009 18:58:41 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> If a function takes (int ac, char **av), then people should be able to
> depend on the usual convention of
>
> (1) for any i < ac, av[i] is not NULL; and
> (2) av[ac] is NULL.
Hmm, isn't potentially useful to be able to pass a sub-range (of a
longer argv vector) to an ac/av function? In such a case, av[ac] may
not be NULL.
-Miles
--
97% of everything is grunge
next prev parent reply other threads:[~2009-05-21 2:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 8:08 [PATCH] setup_revisions(): do not access outside argv Nguyễn Thái Ngọc Duy
2009-05-20 8:15 ` Johannes Sixt
2009-05-20 8:23 ` Nguyen Thai Ngoc Duy
2009-05-21 1:58 ` Junio C Hamano
2009-05-21 2:38 ` Miles Bader [this message]
2009-05-21 2:41 ` Nguyen Thai Ngoc Duy
2009-05-21 4:18 ` Jeff King
2009-05-21 18:02 ` Thomas Jarosch
2009-05-22 7:56 ` Jeff King
2009-05-22 8:02 ` Jeff King
2009-05-22 14:23 ` Thomas Jarosch
2009-05-22 15:33 ` Brandon Casey
2009-05-22 15:34 ` Jeff King
2009-05-25 10:46 ` [PATCH] convert bare readlink to strbuf_readlink Jeff King
2009-05-25 22:23 ` Junio C Hamano
[not found] ` <20090602195605.6117@nanako3.lavabit.com>
2009-06-02 13:57 ` [PATCH] setup_revisions(): do not access outside argv Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=buoljor6uzi.fsf@dhlpc061.dev.necel.com \
--to=miles@gnu.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.