From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234504AbiK1WfC (ORCPT ); Mon, 28 Nov 2022 17:35:02 -0500 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A75F24942 for ; Mon, 28 Nov 2022 14:35:01 -0800 (PST) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2ASMNoxp027649 for ; Mon, 28 Nov 2022 22:35:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : to : from : subject : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=Xm7ABXVOSbaRVbULOVY0cEfjdY6Pm0FuTYBNNkWeDgk=; b=ZQXSjwlCvZ4shy1cPszWearzwZyyJYIYGaNeszcR6ENfk1WSbjHof2wFyB192tIvLdxp IBzBoHlv2jjjTs0ekRmYeDZXeQUUQw+a1lNB7IYEZJFr1+Pe2nmZ0lST4DgWUk9m1onq WXA6L5BTqS+1zwVZfoZ3pABrWddGpc8Vwm7UssQc0zO+MTqkbrWmEC+gBE48ocCG3hlP lrhEN2LvTFlJQi5b0NeHAYhC+Obfp9XEEsivtrVt3s2GwKRSUFICR2P+/6YTq/mlbgqf /3erwNo9maCCsIWH/XtyY9wKmuXc2ouwC1bkIXrvHoEnTZLqBm3Wn7pOP2hGdxYKpRWD /w== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3m397fd34c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 28 Nov 2022 22:35:00 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2ASM2I5r028004 for ; Mon, 28 Nov 2022 22:34:59 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2172.outbound.protection.outlook.com [104.47.73.172]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3m4a2fp1td-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 28 Nov 2022 22:34:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xm7ABXVOSbaRVbULOVY0cEfjdY6Pm0FuTYBNNkWeDgk=; b=dXU6AXpvFIpXMdywv1CaSqXYftRSZ/vG97vkLPeswUfOGDGExnamCjaNUOusnn7O2emZZPgMPF8DQvX2GyhuX/oSPhHqzygK7rf9J782gFqykTjIw4vTcPIZWdIINAsbfLY+8wUzoM0W/beLTVLj0YDMFuyxzFt8LnJC5TOcRn4= Message-ID: Date: Mon, 28 Nov 2022 14:34:54 -0800 Content-Language: en-US From: Sidhartha Kumar Subject: hugetlb BUILD REGRESSION in linux-next20221121 Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 List-ID: To: smatch@vger.kernel.org Hello, One of my patches in linux-next was flagged as a Unverified Error/Warning with the following warning[1]: mm/hugetlb.c:2073 alloc_pool_huge_page() error: uninitialized symbol 'folio'. The relevant change is: -    struct page *page; +    struct folio *folio;      int nr_nodes, node;      gfp_t gfp_mask = htlb_alloc_mask(h) | __GFP_THISNODE;      for_each_node_mask_to_alloc(h, nr_nodes, node, nodes_allowed) { -        page = alloc_fresh_huge_page(h, gfp_mask, node, nodes_allowed, -                        node_alloc_noretry); -        if (page) +        folio = alloc_fresh_hugetlb_folio(h, gfp_mask, node, +                    nodes_allowed, node_alloc_noretry); +        if (folio)              break;      } -    if (!page) +    if (!folio) It looks like I can initialize folio to NULL to avoid this error but I'm not sure how this would cause a regression as previously the page variable was unitialized as well. Please let me know if I am missing something in my patch or if this should be ignored. Thanks, Sidhartha Kumar [1]: https://lore.kernel.org/linux-arm-kernel/637bf477.ORnAaf8quqxr%2FcRo%25lkp@intel.com/T/