From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Peter Hurley <peter@hurleysoftware.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
linux-serial <linux-serial@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] serial: 8250: core: Remove unneeded <linux/pm_runtime.h>
Date: Tue, 3 May 2022 15:24:23 +0300 (EEST) [thread overview]
Message-ID: <c0144ed6-811e-bc2d-7bff-91e7c4ba855@linux.intel.com> (raw)
In-Reply-To: <2545eaa7fc552013a5d04c4df027255204e64834.1651494971.git.geert+renesas@glider.be>
On Mon, 2 May 2022, Geert Uytterhoeven wrote:
> The last calls into Runtime PM were moved to 8250_port.c a long time
> ago.
>
> Fixes: b6830f6df8914faa ("serial: 8250: Split base port operations from universal driver")
Does this really "fix" something or is it just a useful cleanup? To me it
looks the latter.
--
i.
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/tty/serial/8250/8250_core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index 01d30f6ed8fb5931..cfbd2de0ca6e4bcd 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -32,7 +32,6 @@
> #include <linux/mutex.h>
> #include <linux/slab.h>
> #include <linux/uaccess.h>
> -#include <linux/pm_runtime.h>
> #include <linux/io.h>
> #ifdef CONFIG_SPARC
> #include <linux/sunserialcore.h>
>
prev parent reply other threads:[~2022-05-03 12:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 12:37 [PATCH 1/2] serial: 8250: core: Remove unneeded <linux/pm_runtime.h> Geert Uytterhoeven
2022-05-02 12:37 ` [PATCH 2/2] serial: 8250: pxa: " Geert Uytterhoeven
2022-05-03 9:56 ` [PATCH 1/2] serial: 8250: core: " Andy Shevchenko
2022-05-03 12:24 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0144ed6-811e-bc2d-7bff-91e7c4ba855@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.