From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7EF5C433E0 for ; Fri, 29 May 2020 19:15:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA481207D4 for ; Fri, 29 May 2020 19:15:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SurD2S0P"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="e+r/k5Wq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA481207D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TI75NyhxF45pzgkRrDorSM05lr4HgGT3p93nzCQRajo=; b=SurD2S0PjTIioy/q3BrWQq2iS josJepwNK65lKMvc0X1CDR7lV4tRutPvP6bz7IQfprrv0XYLc/4pGZsLf81EIEO2aziIrXIlXthjR Xbt11wMayonLtO3G3zEehc83cMW66iQaeME87X63i27kqazmIbDfpVbL/RxIC9WlgGLhrzHzzsqZK CyhENozKGysS0cDzJtnDMUzTwm/OHlY8fRV/wO03Kuq9M1ahUrU1k2mcQWP1F+Z2MfxZDKUW/6E7F PyqMQvcjoQKb4T7+tPARzZPzLn6GpMaPCnd7pTl8XBiRVEste/oulCdDIlxTP2m5du98tWDBVhgBq 8aTA6QtsQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jekTU-0002ZQ-Vb; Fri, 29 May 2020 19:15:24 +0000 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jekTS-0002Yd-Nx for linux-arm-kernel@lists.infradead.org; Fri, 29 May 2020 19:15:24 +0000 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 29 May 2020 12:15:08 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Fri, 29 May 2020 12:15:20 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Fri, 29 May 2020 12:15:20 -0700 Received: from [10.2.87.173] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 29 May 2020 19:15:20 +0000 Subject: Re: [PATCH 0/3] misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages() To: Dragan Cvetic , LKML References: <20200527012628.1100649-1-jhubbard@nvidia.com> X-Nvconfidentiality: public From: John Hubbard Message-ID: Date: Fri, 29 May 2020 12:15:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1590779708; bh=fzhGtzZMcfGKFcA4Tvhs0mwDOSypFMG8kMfO5rPUm/E=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=e+r/k5WqVFkAi2PibQRZ6bmKhraegciNQsi76G3cRF+zPtEfWvG/Fptuf90ZMBfnc 20fqiotqN8AdRUzB6gPpRSJFcRRzRQX9/XdpQb7nScTTu876Bz7/PsSZCa0XzfIiEn 5M2ut6nC9ozgHHDK3uTQWTMSfMtsMkJdpm0jlWx1CzTkoe4N9jHBilpG6wQ8hoGMDE hCsDoWDlGmfXlB3BpEl72NLx0PixwbxJM/2i4ojGR2ECEtd4XpcTlmE7ikP9mzjp3S xz2H5RgtgoEf4qPfE2o/eU2TFtKNRDcKTP+m8qwgjI/0tO4UIDPsQIBWaJ2JpnMVDF j49Xc5ebg7z4Q== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200529_121522_786797_6EC2CBE5 X-CRM114-Status: GOOD ( 14.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Greg Kroah-Hartman , Michal Simek , Souptick Joarder , Derek Kiernan , "linux-arm-kernel@lists.infradead.org" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-05-29 01:29, Dragan Cvetic wrote: > Hi John, > > Thank you for the suggestion, please find my comment below: > >> -----Original Message----- >> From: John Hubbard >> Sent: Wednesday 27 May 2020 02:26 >> To: LKML >> Cc: Souptick Joarder ; John Hubbard ; Derek Kiernan ; Dragan >> Cvetic ; Arnd Bergmann ; Greg Kroah-Hartman ; Michal Simek >> ; linux-arm-kernel@lists.infradead.org >> Subject: [PATCH 0/3] misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages() >> >> Hi, >> >> There are also a couple of tiny cleanup patches, just to fix up a few >> minor issues that I spotted while converting from get_user_pages_fast() >> to pin_user_pages_fast(). >> >> Note that I have only compile-tested these patches, although that does >> also include cross-compiling for a few other arches. Any run-time >> testing would be greatly appreciated! >> >> Cc: Derek Kiernan >> Cc: Dragan Cvetic >> Cc: Arnd Bergmann >> Cc: Greg Kroah-Hartman >> Cc: Michal Simek >> Cc: linux-arm-kernel@lists.infradead.org >> >> John Hubbard (3): >> misc: xilinx-sdfec: improve get_user_pages_fast() error handling >> misc: xilinx-sdfec: cleanup return value in xsdfec_table_write() >> misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages() > > > Reviewed-by: > Technically there is no problem in this patch, but as you said this should be tested. > Currently due to Covid-19 I'm not able to access the HW and I cannot validate this suggestion. > Hi Dragan, Thanks for the review, and for *wanting* to do the testing, even though you can't right now. :) thanks, -- John Hubbard NVIDIA >> >> drivers/misc/xilinx_sdfec.c | 30 +++++++++++++++++------------- >> 1 file changed, 17 insertions(+), 13 deletions(-) >> >> >> base-commit: 9cb1fd0efd195590b828b9b865421ad345a4a145 >> -- >> 2.26.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CDF7C433DF for ; Fri, 29 May 2020 19:15:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6678020723 for ; Fri, 29 May 2020 19:15:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="e+r/k5Wq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728062AbgE2TPV (ORCPT ); Fri, 29 May 2020 15:15:21 -0400 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:10448 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725865AbgE2TPV (ORCPT ); Fri, 29 May 2020 15:15:21 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 29 May 2020 12:15:08 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Fri, 29 May 2020 12:15:20 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Fri, 29 May 2020 12:15:20 -0700 Received: from [10.2.87.173] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 29 May 2020 19:15:20 +0000 Subject: Re: [PATCH 0/3] misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages() To: Dragan Cvetic , LKML CC: Souptick Joarder , Derek Kiernan , Arnd Bergmann , Greg Kroah-Hartman , Michal Simek , "linux-arm-kernel@lists.infradead.org" References: <20200527012628.1100649-1-jhubbard@nvidia.com> X-Nvconfidentiality: public From: John Hubbard Message-ID: Date: Fri, 29 May 2020 12:15:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1590779708; bh=fzhGtzZMcfGKFcA4Tvhs0mwDOSypFMG8kMfO5rPUm/E=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=e+r/k5WqVFkAi2PibQRZ6bmKhraegciNQsi76G3cRF+zPtEfWvG/Fptuf90ZMBfnc 20fqiotqN8AdRUzB6gPpRSJFcRRzRQX9/XdpQb7nScTTu876Bz7/PsSZCa0XzfIiEn 5M2ut6nC9ozgHHDK3uTQWTMSfMtsMkJdpm0jlWx1CzTkoe4N9jHBilpG6wQ8hoGMDE hCsDoWDlGmfXlB3BpEl72NLx0PixwbxJM/2i4ojGR2ECEtd4XpcTlmE7ikP9mzjp3S xz2H5RgtgoEf4qPfE2o/eU2TFtKNRDcKTP+m8qwgjI/0tO4UIDPsQIBWaJ2JpnMVDF j49Xc5ebg7z4Q== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-05-29 01:29, Dragan Cvetic wrote: > Hi John, > > Thank you for the suggestion, please find my comment below: > >> -----Original Message----- >> From: John Hubbard >> Sent: Wednesday 27 May 2020 02:26 >> To: LKML >> Cc: Souptick Joarder ; John Hubbard ; Derek Kiernan ; Dragan >> Cvetic ; Arnd Bergmann ; Greg Kroah-Hartman ; Michal Simek >> ; linux-arm-kernel@lists.infradead.org >> Subject: [PATCH 0/3] misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages() >> >> Hi, >> >> There are also a couple of tiny cleanup patches, just to fix up a few >> minor issues that I spotted while converting from get_user_pages_fast() >> to pin_user_pages_fast(). >> >> Note that I have only compile-tested these patches, although that does >> also include cross-compiling for a few other arches. Any run-time >> testing would be greatly appreciated! >> >> Cc: Derek Kiernan >> Cc: Dragan Cvetic >> Cc: Arnd Bergmann >> Cc: Greg Kroah-Hartman >> Cc: Michal Simek >> Cc: linux-arm-kernel@lists.infradead.org >> >> John Hubbard (3): >> misc: xilinx-sdfec: improve get_user_pages_fast() error handling >> misc: xilinx-sdfec: cleanup return value in xsdfec_table_write() >> misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages() > > > Reviewed-by: > Technically there is no problem in this patch, but as you said this should be tested. > Currently due to Covid-19 I'm not able to access the HW and I cannot validate this suggestion. > Hi Dragan, Thanks for the review, and for *wanting* to do the testing, even though you can't right now. :) thanks, -- John Hubbard NVIDIA >> >> drivers/misc/xilinx_sdfec.c | 30 +++++++++++++++++------------- >> 1 file changed, 17 insertions(+), 13 deletions(-) >> >> >> base-commit: 9cb1fd0efd195590b828b9b865421ad345a4a145 >> -- >> 2.26.2 >