From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2337C77B61 for ; Tue, 25 Apr 2023 06:24:12 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F3D9F86043; Tue, 25 Apr 2023 08:24:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="KSrx8DlE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8AF25860A5; Tue, 25 Apr 2023 08:24:07 +0200 (CEST) Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 76BEA85B21 for ; Tue, 25 Apr 2023 08:24:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=n-francis@ti.com Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33P6Nrpd080445; Tue, 25 Apr 2023 01:23:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1682403833; bh=GBKLNtBNZraReM6HxXwiOxS1quPb7gLJniEpHAOnOIQ=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=KSrx8DlE0CqRRECCW4SqKgVfuPIsEDdbK5Wqz+9b8XUUU3YzetViTeSpi5UdZPQms Lpz0pGA/UnT6IFu10A6inHI6U+FTxoRDzgViP1AeOzgYryAbUO5EvRmbYqRP2boX5L GZx0liUqFltCXIhWGH4GKOtWPp+WKxoFMIICKlx0= Received: from DLEE110.ent.ti.com (dlee110.ent.ti.com [157.170.170.21]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33P6NrS7114715 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 25 Apr 2023 01:23:53 -0500 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Tue, 25 Apr 2023 01:23:52 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Tue, 25 Apr 2023 01:23:52 -0500 Received: from [172.24.145.195] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33P6NnnS002563; Tue, 25 Apr 2023 01:23:50 -0500 Message-ID: Date: Tue, 25 Apr 2023 11:53:49 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 19/19] doc: board: ti: Update documentation for binman flow To: Simon Glass CC: , , , , , , , , References: <20230421123203.1315330-1-n-francis@ti.com> <20230421123203.1315330-20-n-francis@ti.com> Content-Language: en-US From: Neha Malcom Francis In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Simon On 25/04/23 01:12, Simon Glass wrote: > Hi Neha, > > On Fri, 21 Apr 2023 at 06:33, Neha Malcom Francis wrote: >> >> Earlier documentation specified builds for generating bootloader images >> using an external TI repository k3-image-gen and core-secdev-k3. Modify >> this to using the binman flow so that user understands how to build the >> final boot images. >> >> Signed-off-by: Neha Malcom Francis >> --- >> doc/board/ti/am62x_sk.rst | 20 ++++-------- >> doc/board/ti/j721e_evm.rst | 37 ++++++++------------- >> doc/board/ti/k3.rst | 67 ++++++++++---------------------------- >> 3 files changed, 36 insertions(+), 88 deletions(-) > > Reviewed-by: Simon Glass > >> >> diff --git a/doc/board/ti/am62x_sk.rst b/doc/board/ti/am62x_sk.rst >> index b1b7d99bef..f5e0774899 100644 >> --- a/doc/board/ti/am62x_sk.rst >> +++ b/doc/board/ti/am62x_sk.rst >> @@ -115,23 +115,19 @@ Below is the pictorial representation of boot flow: >> >> Sources: >> -------- >> -1. SYSFW: >> - Tree: git://git.ti.com/k3-image-gen/k3-image-gen.git >> - Branch: master >> - >> -2. ATF: >> +1. ATF: >> Tree: https://github.com/ARM-software/arm-trusted-firmware.git >> Branch: master >> >> -3. OPTEE: >> +2. OPTEE: >> Tree: https://github.com/OP-TEE/optee_os.git >> Branch: master >> >> -4. U-Boot: >> +3. U-Boot: >> Tree: https://source.denx.de/u-boot/u-boot >> Branch: master >> >> -5. TI Linux Firmware: >> +4. TI Linux Firmware: >> Tree: git://git.ti.com/processor-firmware/ti-linux-firmware.git >> Branch: ti-linux-firmware >> >> @@ -156,18 +152,14 @@ Build procedure: >> .. code-block:: text >> >> $ make ARCH=arm CROSS_COMPILE=arm-none-linux-gnueabihf- am62x_evm_r5_defconfig O=/tmp/r5 >> - $ make ARCH=arm CROSS_COMPILE=arm-none-linux-gnueabihf- O=/tmp/r5 >> - $ cd >> - $ make ARCH=arm CROSS_COMPILE=arm-none-linux-gnueabihf- SOC=am62x SBL=/tmp/r5/spl/u-boot-spl.bin SYSFW_PATH=/ti-sysfw/ti-fs-firmware-am62x-gp.bin >> - >> -Use the tiboot3.bin generated from last command >> + $ make ARCH=arm CROSS_COMPILE=arm-none-linux-gnueabihf- O=/tmp/r5 BINMAN_INDIRS= >> >> * 3.2 A53: >> >> .. code-block:: text >> >> $ make ARCH=arm CROSS_COMPILE=aarch64-none-linux-gnu- am62x_evm_a53_defconfig O=/tmp/a53 >> - $ make ARCH=arm CROSS_COMPILE=aarch64-none-linux-gnu- ATF=/build/k3/lite/release/bl31.bin TEE=/out/arm-plat-k3/core/tee-pager_v2.bin DM=/ti-dm/am62xx/ipc_echo_testb_mcu1_0_release_strip.xer5f O=/tmp/a53 >> + $ make ARCH=arm CROSS_COMPILE=aarch64-none-linux-gnu- BL31=/build/k3/lite/release/bl31.bin TEE=/out/arm-plat-k3/core/tee-pager_v2.bin BINMAN_INDIRS= >> >> Target Images >> -------------- >> diff --git a/doc/board/ti/j721e_evm.rst b/doc/board/ti/j721e_evm.rst >> index e898601c41..c90e2b8279 100644 >> --- a/doc/board/ti/j721e_evm.rst >> +++ b/doc/board/ti/j721e_evm.rst >> @@ -130,67 +130,56 @@ support. Below is the pictorial representation of boot flow: >> >> Sources: >> -------- >> -1. SYSFW: >> - Tree: git://git.ti.com/k3-image-gen/k3-image-gen.git >> - Branch: master >> - >> -2. ATF: >> +1. ATF: >> Tree: https://github.com/ARM-software/arm-trusted-firmware.git >> Branch: master >> >> -3. OPTEE: >> +2. OPTEE: >> Tree: https://github.com/OP-TEE/optee_os.git >> Branch: master >> >> -4. DM Firmware: >> - Tree: git://git.ti.com/processor-firmware/ti-linux-firmware.git >> - Branch: ti-linux-firmware >> - >> -5. U-Boot: >> +3. U-Boot: >> Tree: https://source.denx.de/u-boot/u-boot >> Branch: master >> >> +4. TI Linux Firmware: >> + Tree: git://git.ti.com/processor-firmware/ti-linux-firmware.git >> + Branch: ti-linux-firmware >> + >> Build procedure: >> ---------------- >> -1. SYSFW: >> - >> -.. code-block:: bash >> - >> - make CROSS_COMPILE=arm-linux-gnueabihf- SOC=j721e >> - >> -2. ATF: >> +1. ATF: >> >> .. code-block:: bash >> >> make CROSS_COMPILE=aarch64-linux-gnu- ARCH=aarch64 PLAT=k3 TARGET_BOARD=generic SPD=opteed >> >> -3. OPTEE: >> +2. OPTEE: >> >> .. code-block:: bash >> >> make PLATFORM=k3-j721e CFG_ARM64_core=y >> >> -4. U-Boot: >> +3. U-Boot: >> >> * 4.1 R5: >> >> .. code-block:: bash >> >> make CROSS_COMPILE=arm-linux-gnueabihf- j721e_evm_r5_defconfig O=build/r5 >> - make CROSS_COMPILE=arm-linux-gnueabihf- O=build/r5 >> + make CROSS_COMPILE=arm-linux-gnueabihf- O=build/r5 BINMAN_INDIRS= >> >> * 4.2 A72: >> >> .. code-block:: bash >> >> make CROSS_COMPILE=aarch64-linux-gnu- j721e_evm_a72_defconfig O=build/a72 >> - make CROSS_COMPILE=aarch64-linux-gnu- ATF=/build/k3/generic/release/bl31.bin TEE=/out/arm-plat-k3/core/tee-pager_v2.bin DM=/ti-dm/j721e/ipc_echo_testb_mcu1_0_release_strip.xer5f O=build/a72 >> + make CROSS_COMPILE=aarch64-linux-gnu- BL31=/build/k3/generic/release/bl31.bin TEE=/out/arm-plat-k3/core/tee-pager_v2.bin BINMAN_INDIRS= > > Is there an 'O=build/a72' missing there? > Yes, thanks for catching that! > You can combine these as well, by using 'j721e_evm_a72_defconfig all' > to both configure and build. > > Also it might be nice to keep the line length shorter if you can. > [..] > Thanks I will do that. > Regards, > Simon -- Thanking You Neha Malcom Francis