From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68336C2B9F7 for ; Wed, 26 May 2021 06:38:04 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB9EE613C9 for ; Wed, 26 May 2021 06:38:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB9EE613C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-313-YQFCSzqpO_W_KaeV5_mXyQ-1; Wed, 26 May 2021 02:37:59 -0400 X-MC-Unique: YQFCSzqpO_W_KaeV5_mXyQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 20F1D107ACE3; Wed, 26 May 2021 06:37:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1FF7260855; Wed, 26 May 2021 06:37:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0DAD155345; Wed, 26 May 2021 06:37:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 14Q6aqCM013331 for ; Wed, 26 May 2021 02:36:52 -0400 Received: by smtp.corp.redhat.com (Postfix) id 23829FDCF9; Wed, 26 May 2021 06:36:52 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1E84FFED2B for ; Wed, 26 May 2021 06:36:49 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7591D858F0D for ; Wed, 26 May 2021 06:36:49 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-455-IwmdenAkNYG6t-Y90wxACg-1; Wed, 26 May 2021 02:36:46 -0400 X-MC-Unique: IwmdenAkNYG6t-Y90wxACg-1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D8E43ADD7; Wed, 26 May 2021 06:36:44 +0000 (UTC) To: Damien Le Moal , dm-devel@redhat.com, Mike Snitzer , linux-block@vger.kernel.org, Jens Axboe References: <20210525212501.226888-1-damien.lemoal@wdc.com> <20210525212501.226888-2-damien.lemoal@wdc.com> From: Hannes Reinecke Message-ID: Date: Wed, 26 May 2021 08:36:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210525212501.226888-2-damien.lemoal@wdc.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 14Q6aqCM013331 X-loop: dm-devel@redhat.com Subject: Re: [dm-devel] [PATCH v5 01/11] block: improve handling of all zones reset operation X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" T24gNS8yNS8yMSAxMToyNCBQTSwgRGFtaWVuIExlIE1vYWwgd3JvdGU6Cj4gU0NTSSwgWk5TIGFu ZCBudWxsX2JsayB6b25lZCBkZXZpY2VzIHN1cHBvcnQgcmVzZXR0aW5nIGFsbCB6b25lcyB1c2lu Zwo+IGEgc2luZ2xlIGNvbW1hbmQgKFJFUV9PUF9aT05FX1JFU0VUX0FMTCksIGFzIGluZGljYXRl ZCB1c2luZyB0aGUgZGV2aWNlCj4gcmVxdWVzdCBxdWV1ZSBmbGFnIFFVRVVFX0ZMQUdfWk9ORV9S RVNFVEFMTC4gVGhpcyBmbGFnIGlzIG5vdCBzZXQgZm9yCj4gZGV2aWNlIG1hcHBlciB0YXJnZXRz IGNyZWF0aW5nIHpvbmVkIGRldmljZXMuIEluIHRoaXMgY2FzZSwgYSB1c2VyCj4gcmVxdWVzdCBm b3IgcmVzZXR0aW5nIGFsbCB6b25lcyBvZiBhIGRldmljZSBpcyBwcm9jZXNzZWQgaW4KPiBibGtk ZXZfem9uZV9tZ210KCkgYnkgaXNzdWluZyBhIFJFUV9PUF9aT05FX1JFU0VUIG9wZXJhdGlvbiBm b3IgZWFjaAo+IHpvbmUgb2YgdGhlIGRldmljZS4gVGhpcyBsZWFkcyB0byBkaWZmZXJlbnQgYmVo YXZpb3JzIG9mIHRoZQo+IEJMS1JFU0VUWk9ORSBpb2N0bCgpIGRlcGVuZGluZyBvbiB0aGUgdGFy Z2V0IGRldmljZSBzdXBwb3J0IGZvciB0aGUKPiByZXNldCBhbGwgb3BlcmF0aW9uLiBFLmcuCj4g Cj4gYmxrem9uZSByZXNldCAvZGV2L3NkWAo+IAo+IHdpbGwgcmVzZXQgYWxsIHpvbmVzIG9mIGEg U0NTSSBkZXZpY2UgdXNpbmcgYSBzaW5nbGUgY29tbWFuZCB0aGF0IHdpbGwKPiBpZ25vcmUgY29u dmVudGlvbmFsLCByZWFkLW9ubHkgb3Igb2ZmbGluZSB6b25lcy4KPiAKPiBCdXQgYSBkbS1saW5l YXIgZGV2aWNlIGluY2x1ZGluZyBjb252ZW50aW9uYWwsIHJlYWQtb25seSBvciBvZmZsaW5lCj4g em9uZXMgY2Fubm90IGJlIHJlc2V0IGluIHRoZSBzYW1lIG1hbm5lciBhcyBzb21lIG9mIHRoZSBz aW5nbGUgem9uZQo+IHJlc2V0IG9wZXJhdGlvbnMgaXNzdWVkIGJ5IGJsa2Rldl96b25lX21nbXQo KSB3aWxsIGZhaWwuIEUuZy46Cj4gCj4gYmxrem9uZSByZXNldCAvZGV2L2RtLVkKPiBibGt6b25l OiAvZGV2L2RtLTA6IEJMS1JFU0VUWk9ORSBpb2N0bCBmYWlsZWQ6IFJlbW90ZSBJL08gZXJyb3IK PiAKPiBUbyBzaW1wbGlmeSBhcHBsaWNhdGlvbnMgYW5kIHRvb2xzIGRldmVsb3BtZW50LCB1bmlm eSB0aGUgYmVoYXZpb3Igb2YKPiB0aGUgYWxsLXpvbmUgcmVzZXQgb3BlcmF0aW9uIGJ5IG1vZGlm eWluZyBibGtkZXZfem9uZV9tZ210KCkgdG8gbm90Cj4gaXNzdWUgYSB6b25lIHJlc2V0IG9wZXJh dGlvbiBmb3IgY29udmVudGlvbmFsLCByZWFkLW9ubHkgYW5kIG9mZmxpbmUKPiB6b25lcywgdGh1 cyBtaW1pY2tpbmcgd2hhdCBhbiBhY3R1YWwgcmVzZXQtYWxsIGRldmljZSBjb21tYW5kIGRvZXMg b24gYQo+IGRldmljZSBzdXBwb3J0aW5nIFJFUV9PUF9aT05FX1JFU0VUX0FMTC4gVGhpcyBlbXVs YXRpb24gaXMgZG9uZSB1c2luZwo+IHRoZSBuZXcgZnVuY3Rpb24gYmxrZGV2X3pvbmVfcmVzZXRf YWxsX2VtdWxhdGVkKCkuIFRoZSB6b25lcyBuZWVkaW5nIGEKPiByZXNldCBhcmUgaWRlbnRpZmll ZCB1c2luZyBhIGJpdG1hcCB0aGF0IGlzIGluaXRpYWxpemVkIHVzaW5nIGEgem9uZQo+IHJlcG9y dC4gU2luY2UgZW1wdHkgem9uZXMgZG8gbm90IG5lZWQgYSByZXNldCwgYWxzbyBpZ25vcmUgdGhl c2Ugem9uZXMuCj4gVGhlIGZ1bmN0aW9uIGJsa2Rldl96b25lX3Jlc2V0X2FsbCgpIGlzIGludHJv ZHVjZWQgZm9yIGJsb2NrIGRldmljZXMKPiBuYXRpdmVseSBzdXBwb3J0aW5nIHJlc2V0IGFsbCBv cGVyYXRpb25zLiBibGtkZXZfem9uZV9tZ210KCkgaXMgbW9kaWZpZWQKPiB0byBjYWxsIGVpdGhl ciBmdW5jdGlvbiB0byBleGVjdXRlIGFuIGFsbCB6b25lIHJlc2V0IHJlcXVlc3QuCj4gCj4gU2ln bmVkLW9mZi1ieTogRGFtaWVuIExlIE1vYWwgPGRhbWllbi5sZW1vYWxAd2RjLmNvbT4KPiBbaGNo OiBzcGxpdCBpbnRvIG11bHRpcGxlIGZ1bmN0aW9uc10KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3Rv cGggSGVsbHdpZyA8aGNoQGxzdC5kZT4KPiBSZXZpZXdlZC1ieTogQ2hhaXRhbnlhIEt1bGthcm5p IDxjaGFpdGFueWEua3Vsa2FybmlAd2RjLmNvbT4KPiAtLS0KPiAgIGJsb2NrL2Jsay16b25lZC5j IHwgMTE5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0KPiAg IDEgZmlsZSBjaGFuZ2VkLCA5MiBpbnNlcnRpb25zKCspLCAyNyBkZWxldGlvbnMoLSkKPiAKUmV2 aWV3ZWQtYnk6IEhhbm5lcyBSZWluZWNrZSA8aGFyZUBzdXNlLmRlPgoKQ2hlZXJzLAoKSGFubmVz Ci0tIApEci4gSGFubmVzIFJlaW5lY2tlICAgICAgICAgICAgICAgIEtlcm5lbCBTdG9yYWdlIEFy Y2hpdGVjdApoYXJlQHN1c2UuZGUgICAgICAgICAgICAgICAgICAgICAgICAgICAgICArNDkgOTEx IDc0MDUzIDY4OApTVVNFIFNvZnR3YXJlIFNvbHV0aW9ucyBHbWJILCBNYXhmZWxkc3RyLiA1LCA5 MDQwOSBOw7xybmJlcmcKSFJCIDM2ODA5IChBRyBOw7xybmJlcmcpLCBHZXNjaMOkZnRzZsO8aHJl cjogRmVsaXggSW1lbmTDtnJmZmVyCgoKLS0KZG0tZGV2ZWwgbWFpbGluZyBsaXN0CmRtLWRldmVs QHJlZGhhdC5jb20KaHR0cHM6Ly9saXN0bWFuLnJlZGhhdC5jb20vbWFpbG1hbi9saXN0aW5mby9k bS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22FA3C47088 for ; Wed, 26 May 2021 06:36:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 034C161184 for ; Wed, 26 May 2021 06:36:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232808AbhEZGiS (ORCPT ); Wed, 26 May 2021 02:38:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:52464 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232340AbhEZGiQ (ORCPT ); Wed, 26 May 2021 02:38:16 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622011004; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ONB8jiShfRjF1jEyyu8gWgZq4vb66oeXeoKawmGmsR4=; b=YfzkrFURCKlOe9YBEsmowllyoqXnxdFezPE5IBs8Nw4WG+ViOl1ABqgfHCLBgHvVdnpL9I QQLX1bHpL6OFXaewukaferEe1lg9FyehWezJQWbpjnEtfORLm1WsjTNu9nOTa3eyTpQcrM wH9xjN7ythg3IzANLqwGyWz5HiZ4QYE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622011004; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ONB8jiShfRjF1jEyyu8gWgZq4vb66oeXeoKawmGmsR4=; b=QZ7/F5JzOyiSBoV9+6w8Gbms1Z3BHWsQkFG1RzVDGjHuTgvrgRVdYbBXfMC5xA+B46srw9 04prWMsW0hJtR9Aw== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D8E43ADD7; Wed, 26 May 2021 06:36:44 +0000 (UTC) Subject: Re: [PATCH v5 01/11] block: improve handling of all zones reset operation To: Damien Le Moal , dm-devel@redhat.com, Mike Snitzer , linux-block@vger.kernel.org, Jens Axboe References: <20210525212501.226888-1-damien.lemoal@wdc.com> <20210525212501.226888-2-damien.lemoal@wdc.com> From: Hannes Reinecke Message-ID: Date: Wed, 26 May 2021 08:36:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210525212501.226888-2-damien.lemoal@wdc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 5/25/21 11:24 PM, Damien Le Moal wrote: > SCSI, ZNS and null_blk zoned devices support resetting all zones using > a single command (REQ_OP_ZONE_RESET_ALL), as indicated using the device > request queue flag QUEUE_FLAG_ZONE_RESETALL. This flag is not set for > device mapper targets creating zoned devices. In this case, a user > request for resetting all zones of a device is processed in > blkdev_zone_mgmt() by issuing a REQ_OP_ZONE_RESET operation for each > zone of the device. This leads to different behaviors of the > BLKRESETZONE ioctl() depending on the target device support for the > reset all operation. E.g. > > blkzone reset /dev/sdX > > will reset all zones of a SCSI device using a single command that will > ignore conventional, read-only or offline zones. > > But a dm-linear device including conventional, read-only or offline > zones cannot be reset in the same manner as some of the single zone > reset operations issued by blkdev_zone_mgmt() will fail. E.g.: > > blkzone reset /dev/dm-Y > blkzone: /dev/dm-0: BLKRESETZONE ioctl failed: Remote I/O error > > To simplify applications and tools development, unify the behavior of > the all-zone reset operation by modifying blkdev_zone_mgmt() to not > issue a zone reset operation for conventional, read-only and offline > zones, thus mimicking what an actual reset-all device command does on a > device supporting REQ_OP_ZONE_RESET_ALL. This emulation is done using > the new function blkdev_zone_reset_all_emulated(). The zones needing a > reset are identified using a bitmap that is initialized using a zone > report. Since empty zones do not need a reset, also ignore these zones. > The function blkdev_zone_reset_all() is introduced for block devices > natively supporting reset all operations. blkdev_zone_mgmt() is modified > to call either function to execute an all zone reset request. > > Signed-off-by: Damien Le Moal > [hch: split into multiple functions] > Signed-off-by: Christoph Hellwig > Reviewed-by: Chaitanya Kulkarni > --- > block/blk-zoned.c | 119 +++++++++++++++++++++++++++++++++++----------- > 1 file changed, 92 insertions(+), 27 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer