From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5468130492 for ; Tue, 16 Apr 2024 16:08:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713283694; cv=none; b=caF+bCta/iC2SegZ33MKFMbMY3tTyHOqgrk+WZTj80VRlaHO5l9OvyWf40AiPDynj7AGCZfaoelERAY/3OSzFqEZ674eer4iAhEIZXexkrmBBzSEUnxiNFkLY6+mHj87hEya+tN3jAWDbtcJ5F4f6AZP7qxdqjZxdZ3f3fmT4d8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713283694; c=relaxed/simple; bh=QV71qq9odi8AHKM63Tno0XX3cSK/Xlz9aafkhj8FPUw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Fpk5sBoLRgCjJK3/L0UAX8qwAOCQBe823nWefFyo4Ty/s+3zXMPtZIhkARzPvHHe1s1362xePPFv/Ub0p5mCY/Ezer+KUscSd4Tjeok1yasq3n6chfU2r9d5ZcTn0S5yZba+TCZXcqbU5CpA10pr/IlaD5jvlV7H2Eh9LZo3PZo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ddONVnb0; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ddONVnb0" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4187731a6e1so12199145e9.2 for ; Tue, 16 Apr 2024 09:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713283691; x=1713888491; darn=lists.linux.dev; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=ZIdA1Sj+M3uL+IMIYi64iHj/gQH9BBQNdMeTTfi5MAk=; b=ddONVnb0XAQw5/QqoqIMP8ujadYRXEoMDELpTsIhZTmL3hmbH9lPE61l2uzrPquyMO UGXPv6DipeGo4hTSA0VRd/vA3MVdGXlN+IFPVH7j8y144SDq8slHEGmsJddQRc10fpSO 58p/nNCWct7DUgsqWyFQPY9asPCjd2sju5Qzck99Q8c1WUHDDhyuN1EGW3FvFYH8jRJ/ 0VfNMOUL5CEukpKd8XzZ9pWn35eTk4g6L6EjYLmBySok9+CyiuULK6IiXrHiPTT5i4R6 M5wEOiMyZFDePmFwIecyuhCSm/eFMXb79GmXNLf2P6qrMYkGuwob8PifLUu3oAXvQkd3 msaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713283691; x=1713888491; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZIdA1Sj+M3uL+IMIYi64iHj/gQH9BBQNdMeTTfi5MAk=; b=rTt1cBms06K4JNaKoBcgoE+KNX/x3dFsx+jpefOlcqy7xHTi8DMZnymqydZD9CBZay 0SJFj86wiIRJdJurY4l6KmOEKElMSB8OvzfYQtvHXo9krJF0Vx6TsH/v4jAt06THh/mo 80a+HpK+72ND89sPvhH0l3tsDHt5jHdq0azDv99oqH9P9wUaotIFLJVO/rOyMtqG+Emm GeONK7DvJ2J9ZEEBEIYlO4c+g4k92iMGC9MyTof5t5mf+vDcl+aJta4lOlXq0QnxuC3U /W11OtltrT6iVPlayd9XxBHmnxEir2Y6lzZ/7gtxfAhm2V1NA+anD0YGrEYl4ZnC+IO5 VJhg== X-Forwarded-Encrypted: i=1; AJvYcCWeZ8anpPLlYA2YNjR503Sh6TrNmHqyCoXXPgP/ZaZOKSBTIoj/vP8LhumAo9LV8Hz2W+ZDx7jIOV/l7G/iDv5CYTbf X-Gm-Message-State: AOJu0YwAO4WL9jtzPBTj/264Mqa91KkoX0NTpnnB5pTGQ/gfOT3j77z3 RPGLsOZgiSAf3L6Yq8d0vf/EWbVI7Ev6VhX/XR+0SOXEhBG0Wnkp X-Google-Smtp-Source: AGHT+IHyFWGmvJYOfR2xREiYISWtTfew1Vay0BFApoqN0ItFTTRH32ygEA6x9s/dWYJk19A15KUMfg== X-Received: by 2002:a05:600c:3549:b0:418:23d7:816f with SMTP id i9-20020a05600c354900b0041823d7816fmr5977429wmq.17.1713283690835; Tue, 16 Apr 2024 09:08:10 -0700 (PDT) Received: from ?IPv6:2001:8a0:e622:f700:648e:56c:90e2:9fe8? ([2001:8a0:e622:f700:648e:56c:90e2:9fe8]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c1c0700b004187d900766sm5347326wms.43.2024.04.16.09.08.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 09:08:10 -0700 (PDT) Message-ID: Subject: Re: [PATCH v1] arm64: dts: imx8mm: fix missing pgc_vpu_* power domain parent From: Vitor Soares To: Lucas Stach , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Peng Fan Cc: Vitor Soares , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Tue, 16 Apr 2024 17:08:08 +0100 In-Reply-To: <564fa534b32f4a6e96da6752f531fc7447ec633d.camel@gmail.com> References: <20240409085802.290439-1-ivitro@gmail.com> <9ce35b9bb5a15891f6bd01bd54b7dc84b3ba4021.camel@pengutronix.de> <564fa534b32f4a6e96da6752f531fc7447ec633d.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2024-04-16 at 11:53 +0100, Vitor Soares wrote: > ++ Peng Fan >=20 > Greetings, >=20 >=20 > On Wed, 2024-04-10 at 12:01 +0100, Vitor Soares wrote: > > Hi Lucas, > >=20 > > On Tue, 2024-04-09 at 17:44 +0100, Vitor Soares wrote: > > > On Tue, 2024-04-09 at 16:36 +0200, Lucas Stach wrote: > > > > Am Dienstag, dem 09.04.2024 um 14:22 +0100 schrieb Vitor Soares: > > > > > Hi Lucas, > > > > >=20 > > > > > Thanks for your feedback. > > > > >=20 > > > > > On Tue, 2024-04-09 at 11:13 +0200, Lucas Stach wrote: > > > > > > Hi Vitor, > > > > > >=20 > > > > > > Am Dienstag, dem 09.04.2024 um 09:58 +0100 schrieb Vitor > > > > > > Soares: > > > > > > > From: Vitor Soares > > > > > > >=20 > > > > > > > The pgc_vpu_* nodes miss the reference to the power domain > > > > > > > parent, > > > > > > > leading the system to hang during the resume. > > > > > > >=20 > > > > > > This change is not correct. The vpumix domain is controlled > > > > > > through > > > > > > the > > > > > > imx8mm-vpu-blk-ctrl and must not be directly triggered by the > > > > > > child > > > > > > domains in order to guarantee proper power sequencing. > > > > > >=20 > > > > > > If the sequencing is incorrect for resume, it needs to be > > > > > > fixed > > > > > > in > > > > > > the > > > > > > blk-ctrl driver. I'll happily assist if you have any > > > > > > questions > > > > > > about > > > > > > this intricate mix between GPC and blk-ctrl hardware/drivers. > > > > > =C2=A0 > > > > > I'm new into the topic, so I tried to follow same approach as > > > > > in > > > > > imx8mp > > > > > DT. > > > > >=20 > > > > That's a good hint, the 8MP VPU GPC node additions missed my > > > > radar. > > > > The > > > > direct dependency there between the GPC domains is equally wrong. > > > >=20 > > > > > I also checked the imx8mq DT and it only have one domain for > > > > > the > > > > > VPU in the GPC. It seem blk-ctrl also dependes on pgc_vpu_* to > > > > > work > > > > > properly. > > > > >=20 > > > > > The blk-ctrl driver hangs on imx8m_blk_ctrl_power_on() when > > > > > access > > > > > the > > > > > ip registers for the soft reset. I tried to power-up the before > > > > > the > > > > > soft reset, but it didn't work. > > > > >=20 > > > > The runtime_pm_get_sync() at the start of that function should > > > > ensure > > > > that bus GPC domain aka vpumix is powered up. Can you check if > > > > that > > > > is > > > > happening? > > >=20 > > > I checked bc->bus_power_dev->power.runtime_status and it is > > > RPM_ACTIVE. > > >=20 > > > Am I looking to on the right thing? It is RPM_ACTIVE event before > > > runtime_pm_get_sync(). > >=20 > > During the probe I can see that > > bus_power_dev->power.runtime_status =3D RPM_SUSPENDED and then vpumix > > is > > powered up on GPC driver. > >=20 > > On resume routine I can't see this flow. bus_power_dev- > > > power.runtime_status =3D RPM_ACTIVE and vpumix end up not being > > > powered- > > up. > >=20 > > I checked the suspend flow and the GPC tries to poweroff vpumix. > >=20 > >=20 >=20 > My understanding is that when resuming the 38310000.video-codec, the > vpumix isn't powered up. It happens because runtime_status and > runtime_last_status =3D RPM_ACTIVE.=20 >=20 > I tried to change blk-ctrl suspend routine to force the runtime_status > =3D RPM_SUSPENDED, but the system ended up hanging on another device. >=20 > From the comment in blk-ctrl suspend, we rely on PM_SLEEP code that > iterates over dpm_list for suspend/resume. > I did look at the dpm_list, and it changes the order on every boot.=20 >=20 > With all the tests, I also found that the system randomly hangs on > dispblk-lcdif suspend. I have confirmed this device is in a different > place in the dpm_list (not sure if it is the root cause).=20 > I haven't understood how blk-ctrl ensures the correct order there yet.= =20 >=20 > Taking the following dpm_list excerpt: > idx - device > ------------------------------ > ...=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 > 191 - imx-pgc-domain.7=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 > 192 - imx-pgc-domain.8=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 > 193 - imx-pgc-domain.9=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 > 194 - 38330000.blk-ctrl=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 > 195 - 38310000.video-codec=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > 196 - 38300000.video-codec=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > ... > 205 - genpd:0:38330000.blk-ctrl > 206 - genpd:1:38330000.blk-ctrl > 207 - genpd:2:38330000.blk-ctrl > 208 - genpd:3:38330000.blk-ctrl > ------------------------------ >=20 > Shouldn't genpd devices be before 38330000.blk-ctrl? > As their power domain is GPC and the blk-ctrl power domain is genpd. >=20 I did the following change to have genpd device before 38330000.blk-ctrl on dpm_list and it did work. diff --git a/drivers/pmdomain/imx/imx8m-blk-ctrl.c b/drivers/pmdomain/imx/i= mx8m-blk-ctrl.c index ca942d7929c2..0f1471dcd4e8 100644 --- a/drivers/pmdomain/imx/imx8m-blk-ctrl.c +++ b/drivers/pmdomain/imx/imx8m-blk-ctrl.c @@ -220,6 +220,7 @@ static int imx8m_blk_ctrl_probe(struct platform_device = *pdev) return dev_err_probe(dev, PTR_ERR(bc->bus_power_dev= ), "failed to attach power domain= \"bus\"\n"); } + device_move(dev, bc->bus_power_dev, DPM_ORDER_PARENT_BEFORE_DEV); =20 for (i =3D 0; i < bc_data->num_domains; i++) { const struct imx8m_blk_ctrl_domain_data *data =3D &bc_data-= >domains[i]; @@ -268,6 +269,7 @@ static int imx8m_blk_ctrl_probe(struct platform_device = *pdev) data->gpc_name); goto cleanup_pds; } + device_move(dev, domain->power_dev, DPM_ORDER_PARENT_BEFORE= _DEV); =20 domain->genpd.name =3D data->name; domain->genpd.power_on =3D imx8m_blk_ctrl_power_on; any concern about this approach? Best regards, Vitor Soares >=20 > >=20 > > >=20 > > >=20 > > > >=20 > > > > Regards, > > > > Lucas > > > >=20 > > > > > Do you have an idea how we can address this within blk-ctrl? > > > > >=20 > > > > > Best regards, > > > > > Vitor > > >=20 > >=20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4DBCC4345F for ; Tue, 16 Apr 2024 16:08:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BdlIrDcqXNLwdFVNY7kSkGEUQ/Kd4W7zAqSJqjr20Zw=; b=0+7kDvm8npYkZQ onghWKEz4xKkxYeq84uXcStwDl4mpLwcHAG7cEhtmU+AYJXVWXZfKNghqVkE3hPQL7+WP7jmFD2nw bjEMqXT3IYKezeixy5IvTM/O2bpGFSc0SBB9k5K6Qw7AadapYPU27GG4m75lziUnyFz0c3hQ8GIH0 W75a+P0rvyn1KHkRoAJowp5M5jlNrsbJhpM/BRxs5jXHqyZc/vT0F1QDLN/3uYkEqgcuihbE7CRDA fp+x+s4K7rkuVx1pjkn3TmvzpVco4Avy6m5iyiUxqty5MFJVblGhe3dK/dz2EBS6LXgA3Qz+XClH8 69wvDqca6h5hXJ2iRZJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwlM4-0000000Cvq8-1npM; Tue, 16 Apr 2024 16:08:20 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwlLx-0000000Cvp3-2rfs for linux-arm-kernel@lists.infradead.org; Tue, 16 Apr 2024 16:08:18 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-4187981999fso11883145e9.1 for ; Tue, 16 Apr 2024 09:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713283691; x=1713888491; darn=lists.infradead.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=ZIdA1Sj+M3uL+IMIYi64iHj/gQH9BBQNdMeTTfi5MAk=; b=Xvi9rLmUGmuYiU+z605Z9Di07VVfQKx382BwfTn58ebsTemd98CpA/SvnSKEgsRkQ1 v/oHFXwqgckPDdw2CtIWaSqJvzDreNvmOBzIKqh8zOhcT5VtnKgyKcMU00Ux/K0Jkwu/ Jfi4BAuS/0mob6tXCV0KcYoi/6DRPE6PadLbxIck7KAUSgGA1WMAr7r5e2JY6NfgEukB z1bUyleLb6alf7+aiYj8ZzRNfmB/MmgTTmPI5uPaLeVAUcFfiNY6jgxImoJX9fPJkK5d Q8Qq7CHsi2oJBhzEoFWva/zbR4h11u1wGj6o7NExUXZ0t6mC78nEfL3H8XxxexdurdIu FsuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713283691; x=1713888491; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZIdA1Sj+M3uL+IMIYi64iHj/gQH9BBQNdMeTTfi5MAk=; b=LTlxgdllcRgJRw5FP7wo87r2cgCQ6a7r7G2jRhpHrxdsI5OQNEercx5Y7UU7U1mbcd GUCNEg6QgT+rEsNnhfB+G8zUatR1eI+4q3NxWbAn6RuarWcKpX6eFTmP00+TQ3a/szYT cWRwcFOLLSIKtwXRtgZ9AjHmb0uuz1kIQsSeb512BJlMAcLMZpwqVAanDKRBRJcPgZjU uZWN2v5ERdTWQMC6khA/S00+W8HIQCHZ71/wky5PFD03VWLu32vy4SwP/bbi/QE5d6/t +flo6EXM0EC7V43r51kyOvqMfk+mZ+WWIsIomh86X4aCSAophmFND5dUDh2IORxILgVz 0vuA== X-Forwarded-Encrypted: i=1; AJvYcCXj6ZKrsNRjU/KJzrMYXdoMsl5Lor2gtYafVQ5cGvwzaV7YLuKzRawGflkdugKz10l7D24Q6RZGDbIkspSxkQe2E1cAKdkNzgIHthQHMtnAtSgOW80= X-Gm-Message-State: AOJu0YxShTJBAeY7S4izdZpOYzHRp66l4dsTM6uDP6KHNfabNfiP/t0n 02nD8OdGXRYA6fQnG3H+IWuZ8wgl5AMG1aZQY8oa0yWd88N/3q0v X-Google-Smtp-Source: AGHT+IHyFWGmvJYOfR2xREiYISWtTfew1Vay0BFApoqN0ItFTTRH32ygEA6x9s/dWYJk19A15KUMfg== X-Received: by 2002:a05:600c:3549:b0:418:23d7:816f with SMTP id i9-20020a05600c354900b0041823d7816fmr5977429wmq.17.1713283690835; Tue, 16 Apr 2024 09:08:10 -0700 (PDT) Received: from ?IPv6:2001:8a0:e622:f700:648e:56c:90e2:9fe8? ([2001:8a0:e622:f700:648e:56c:90e2:9fe8]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c1c0700b004187d900766sm5347326wms.43.2024.04.16.09.08.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 09:08:10 -0700 (PDT) Message-ID: Subject: Re: [PATCH v1] arm64: dts: imx8mm: fix missing pgc_vpu_* power domain parent From: Vitor Soares To: Lucas Stach , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Peng Fan Cc: Vitor Soares , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Tue, 16 Apr 2024 17:08:08 +0100 In-Reply-To: <564fa534b32f4a6e96da6752f531fc7447ec633d.camel@gmail.com> References: <20240409085802.290439-1-ivitro@gmail.com> <9ce35b9bb5a15891f6bd01bd54b7dc84b3ba4021.camel@pengutronix.de> <564fa534b32f4a6e96da6752f531fc7447ec633d.camel@gmail.com> User-Agent: Evolution 3.44.4-0ubuntu2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240416_090813_775166_427FE7FC X-CRM114-Status: GOOD ( 47.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyMDI0LTA0LTE2IGF0IDExOjUzICswMTAwLCBWaXRvciBTb2FyZXMgd3JvdGU6Cj4g KysgUGVuZyBGYW4gPHBlbmcuZmFuQG54cC5jb20+Cj4gCj4gR3JlZXRpbmdzLAo+IAo+IAo+IE9u IFdlZCwgMjAyNC0wNC0xMCBhdCAxMjowMSArMDEwMCwgVml0b3IgU29hcmVzIHdyb3RlOgo+ID4g SGkgTHVjYXMsCj4gPiAKPiA+IE9uIFR1ZSwgMjAyNC0wNC0wOSBhdCAxNzo0NCArMDEwMCwgVml0 b3IgU29hcmVzIHdyb3RlOgo+ID4gPiBPbiBUdWUsIDIwMjQtMDQtMDkgYXQgMTY6MzYgKzAyMDAs IEx1Y2FzIFN0YWNoIHdyb3RlOgo+ID4gPiA+IEFtIERpZW5zdGFnLCBkZW0gMDkuMDQuMjAyNCB1 bSAxNDoyMiArMDEwMCBzY2hyaWViIFZpdG9yIFNvYXJlczoKPiA+ID4gPiA+IEhpIEx1Y2FzLAo+ ID4gPiA+ID4gCj4gPiA+ID4gPiBUaGFua3MgZm9yIHlvdXIgZmVlZGJhY2suCj4gPiA+ID4gPiAK PiA+ID4gPiA+IE9uIFR1ZSwgMjAyNC0wNC0wOSBhdCAxMToxMyArMDIwMCwgTHVjYXMgU3RhY2gg d3JvdGU6Cj4gPiA+ID4gPiA+IEhpIFZpdG9yLAo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gQW0g RGllbnN0YWcsIGRlbSAwOS4wNC4yMDI0IHVtIDA5OjU4ICswMTAwIHNjaHJpZWIgVml0b3IKPiA+ ID4gPiA+ID4gU29hcmVzOgo+ID4gPiA+ID4gPiA+IEZyb206IFZpdG9yIFNvYXJlcyA8dml0b3Iu c29hcmVzQHRvcmFkZXguY29tPgo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+IFRoZSBwZ2Nf dnB1Xyogbm9kZXMgbWlzcyB0aGUgcmVmZXJlbmNlIHRvIHRoZSBwb3dlciBkb21haW4KPiA+ID4g PiA+ID4gPiBwYXJlbnQsCj4gPiA+ID4gPiA+ID4gbGVhZGluZyB0aGUgc3lzdGVtIHRvIGhhbmcg ZHVyaW5nIHRoZSByZXN1bWUuCj4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IFRoaXMgY2hhbmdl IGlzIG5vdCBjb3JyZWN0LiBUaGUgdnB1bWl4IGRvbWFpbiBpcyBjb250cm9sbGVkCj4gPiA+ID4g PiA+IHRocm91Z2gKPiA+ID4gPiA+ID4gdGhlCj4gPiA+ID4gPiA+IGlteDhtbS12cHUtYmxrLWN0 cmwgYW5kIG11c3Qgbm90IGJlIGRpcmVjdGx5IHRyaWdnZXJlZCBieSB0aGUKPiA+ID4gPiA+ID4g Y2hpbGQKPiA+ID4gPiA+ID4gZG9tYWlucyBpbiBvcmRlciB0byBndWFyYW50ZWUgcHJvcGVyIHBv d2VyIHNlcXVlbmNpbmcuCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBJZiB0aGUgc2VxdWVuY2lu ZyBpcyBpbmNvcnJlY3QgZm9yIHJlc3VtZSwgaXQgbmVlZHMgdG8gYmUKPiA+ID4gPiA+ID4gZml4 ZWQKPiA+ID4gPiA+ID4gaW4KPiA+ID4gPiA+ID4gdGhlCj4gPiA+ID4gPiA+IGJsay1jdHJsIGRy aXZlci4gSSdsbCBoYXBwaWx5IGFzc2lzdCBpZiB5b3UgaGF2ZSBhbnkKPiA+ID4gPiA+ID4gcXVl c3Rpb25zCj4gPiA+ID4gPiA+IGFib3V0Cj4gPiA+ID4gPiA+IHRoaXMgaW50cmljYXRlIG1peCBi ZXR3ZWVuIEdQQyBhbmQgYmxrLWN0cmwgaGFyZHdhcmUvZHJpdmVycy4KPiA+ID4gPiA+IMKgCj4g PiA+ID4gPiBJJ20gbmV3IGludG8gdGhlIHRvcGljLCBzbyBJIHRyaWVkIHRvIGZvbGxvdyBzYW1l IGFwcHJvYWNoIGFzCj4gPiA+ID4gPiBpbgo+ID4gPiA+ID4gaW14OG1wCj4gPiA+ID4gPiBEVC4K PiA+ID4gPiA+IAo+ID4gPiA+IFRoYXQncyBhIGdvb2QgaGludCwgdGhlIDhNUCBWUFUgR1BDIG5v ZGUgYWRkaXRpb25zIG1pc3NlZCBteQo+ID4gPiA+IHJhZGFyLgo+ID4gPiA+IFRoZQo+ID4gPiA+ IGRpcmVjdCBkZXBlbmRlbmN5IHRoZXJlIGJldHdlZW4gdGhlIEdQQyBkb21haW5zIGlzIGVxdWFs bHkgd3JvbmcuCj4gPiA+ID4gCj4gPiA+ID4gPiBJIGFsc28gY2hlY2tlZCB0aGUgaW14OG1xIERU IGFuZCBpdCBvbmx5IGhhdmUgb25lIGRvbWFpbiBmb3IKPiA+ID4gPiA+IHRoZQo+ID4gPiA+ID4g VlBVIGluIHRoZSBHUEMuIEl0IHNlZW0gYmxrLWN0cmwgYWxzbyBkZXBlbmRlcyBvbiBwZ2NfdnB1 XyogdG8KPiA+ID4gPiA+IHdvcmsKPiA+ID4gPiA+IHByb3Blcmx5Lgo+ID4gPiA+ID4gCj4gPiA+ ID4gPiBUaGUgYmxrLWN0cmwgZHJpdmVyIGhhbmdzIG9uIGlteDhtX2Jsa19jdHJsX3Bvd2VyX29u KCkgd2hlbgo+ID4gPiA+ID4gYWNjZXNzCj4gPiA+ID4gPiB0aGUKPiA+ID4gPiA+IGlwIHJlZ2lz dGVycyBmb3IgdGhlIHNvZnQgcmVzZXQuIEkgdHJpZWQgdG8gcG93ZXItdXAgdGhlIGJlZm9yZQo+ ID4gPiA+ID4gdGhlCj4gPiA+ID4gPiBzb2Z0IHJlc2V0LCBidXQgaXQgZGlkbid0IHdvcmsuCj4g PiA+ID4gPiAKPiA+ID4gPiBUaGUgcnVudGltZV9wbV9nZXRfc3luYygpIGF0IHRoZSBzdGFydCBv ZiB0aGF0IGZ1bmN0aW9uIHNob3VsZAo+ID4gPiA+IGVuc3VyZQo+ID4gPiA+IHRoYXQgYnVzIEdQ QyBkb21haW4gYWthIHZwdW1peCBpcyBwb3dlcmVkIHVwLiBDYW4geW91IGNoZWNrIGlmCj4gPiA+ ID4gdGhhdAo+ID4gPiA+IGlzCj4gPiA+ID4gaGFwcGVuaW5nPwo+ID4gPiAKPiA+ID4gSSBjaGVj a2VkIGJjLT5idXNfcG93ZXJfZGV2LT5wb3dlci5ydW50aW1lX3N0YXR1cyBhbmQgaXQgaXMKPiA+ ID4gUlBNX0FDVElWRS4KPiA+ID4gCj4gPiA+IEFtIEkgbG9va2luZyB0byBvbiB0aGUgcmlnaHQg dGhpbmc/IEl0IGlzIFJQTV9BQ1RJVkUgZXZlbnQgYmVmb3JlCj4gPiA+IHJ1bnRpbWVfcG1fZ2V0 X3N5bmMoKS4KPiA+IAo+ID4gRHVyaW5nIHRoZSBwcm9iZSBJIGNhbiBzZWUgdGhhdAo+ID4gYnVz X3Bvd2VyX2Rldi0+cG93ZXIucnVudGltZV9zdGF0dXMgPSBSUE1fU1VTUEVOREVEIGFuZCB0aGVu IHZwdW1peAo+ID4gaXMKPiA+IHBvd2VyZWQgdXAgb24gR1BDIGRyaXZlci4KPiA+IAo+ID4gT24g cmVzdW1lIHJvdXRpbmUgSSBjYW4ndCBzZWUgdGhpcyBmbG93LiBidXNfcG93ZXJfZGV2LQo+ID4g PiBwb3dlci5ydW50aW1lX3N0YXR1cyA9IFJQTV9BQ1RJVkUgYW5kIHZwdW1peCBlbmQgdXAgbm90 IGJlaW5nCj4gPiA+IHBvd2VyZWQtCj4gPiB1cC4KPiA+IAo+ID4gSSBjaGVja2VkIHRoZSBzdXNw ZW5kIGZsb3cgYW5kIHRoZSBHUEMgdHJpZXMgdG8gcG93ZXJvZmYgdnB1bWl4Lgo+ID4gCj4gPiAK PiAKPiBNeSB1bmRlcnN0YW5kaW5nIGlzIHRoYXQgd2hlbiByZXN1bWluZyB0aGUgMzgzMTAwMDAu dmlkZW8tY29kZWMsIHRoZQo+IHZwdW1peCBpc24ndCBwb3dlcmVkIHVwLiBJdCBoYXBwZW5zIGJl Y2F1c2UgcnVudGltZV9zdGF0dXMgYW5kCj4gcnVudGltZV9sYXN0X3N0YXR1cyA9IFJQTV9BQ1RJ VkUuIAo+IAo+IEkgdHJpZWQgdG8gY2hhbmdlIGJsay1jdHJsIHN1c3BlbmQgcm91dGluZSB0byBm b3JjZSB0aGUgcnVudGltZV9zdGF0dXMKPiA9IFJQTV9TVVNQRU5ERUQsIGJ1dCB0aGUgc3lzdGVt IGVuZGVkIHVwIGhhbmdpbmcgb24gYW5vdGhlciBkZXZpY2UuCj4gCj4gRnJvbSB0aGUgY29tbWVu dCBpbiBibGstY3RybCBzdXNwZW5kLCB3ZSByZWx5IG9uIFBNX1NMRUVQIGNvZGUgdGhhdAo+IGl0 ZXJhdGVzIG92ZXIgZHBtX2xpc3QgZm9yIHN1c3BlbmQvcmVzdW1lLgo+IEkgZGlkIGxvb2sgYXQg dGhlIGRwbV9saXN0LCBhbmQgaXQgY2hhbmdlcyB0aGUgb3JkZXIgb24gZXZlcnkgYm9vdC4gCj4g Cj4gV2l0aCBhbGwgdGhlIHRlc3RzLCBJIGFsc28gZm91bmQgdGhhdCB0aGUgc3lzdGVtIHJhbmRv bWx5IGhhbmdzIG9uCj4gZGlzcGJsay1sY2RpZiBzdXNwZW5kLiBJIGhhdmUgY29uZmlybWVkIHRo aXMgZGV2aWNlIGlzIGluIGEgZGlmZmVyZW50Cj4gcGxhY2UgaW4gdGhlIGRwbV9saXN0IChub3Qg c3VyZSBpZiBpdCBpcyB0aGUgcm9vdCBjYXVzZSkuIAo+IEkgaGF2ZW4ndCB1bmRlcnN0b29kIGhv dyBibGstY3RybCBlbnN1cmVzIHRoZSBjb3JyZWN0IG9yZGVyIHRoZXJlIHlldC4gCj4gCj4gVGFr aW5nIHRoZSBmb2xsb3dpbmcgZHBtX2xpc3QgZXhjZXJwdDoKPiBpZHggLSBkZXZpY2UKPiAtLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAuLi7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAKPiAxOTEg LSBpbXgtcGdjLWRvbWFpbi43wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoAo+ IDE5MiAtIGlteC1wZ2MtZG9tYWluLjjCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgCj4gMTkzIC0gaW14LXBnYy1kb21haW4uOcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAKPiAxOTQgLSAzODMzMDAwMC5ibGstY3RybMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgCj4gMTk1IC0gMzgzMTAwMDAudmlkZW8tY29kZWPCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoAo+IDE5NiAtIDM4MzAwMDAwLnZpZGVvLWNvZGVjwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAKPiAuLi4KPiAyMDUgLSBnZW5wZDowOjM4MzMwMDAwLmJsay1jdHJsCj4g MjA2IC0gZ2VucGQ6MTozODMzMDAwMC5ibGstY3RybAo+IDIwNyAtIGdlbnBkOjI6MzgzMzAwMDAu YmxrLWN0cmwKPiAyMDggLSBnZW5wZDozOjM4MzMwMDAwLmJsay1jdHJsCj4gLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tCj4gCj4gU2hvdWxkbid0IGdlbnBkIGRldmljZXMgYmUgYmVmb3Jl IDM4MzMwMDAwLmJsay1jdHJsPwo+IEFzIHRoZWlyIHBvd2VyIGRvbWFpbiBpcyBHUEMgYW5kIHRo ZSBibGstY3RybCBwb3dlciBkb21haW4gaXMgZ2VucGQuCj4gCgpJIGRpZCB0aGUgZm9sbG93aW5n IGNoYW5nZSB0byBoYXZlIGdlbnBkIGRldmljZSBiZWZvcmUgMzgzMzAwMDAuYmxrLWN0cmwKb24g ZHBtX2xpc3QgYW5kIGl0IGRpZCB3b3JrLgoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvcG1kb21haW4v aW14L2lteDhtLWJsay1jdHJsLmMgYi9kcml2ZXJzL3BtZG9tYWluL2lteC9pbXg4bS1ibGstY3Ry bC5jCmluZGV4IGNhOTQyZDc5MjljMi4uMGYxNDcxZGNkNGU4IDEwMDY0NAotLS0gYS9kcml2ZXJz L3BtZG9tYWluL2lteC9pbXg4bS1ibGstY3RybC5jCisrKyBiL2RyaXZlcnMvcG1kb21haW4vaW14 L2lteDhtLWJsay1jdHJsLmMKQEAgLTIyMCw2ICsyMjAsNyBAQCBzdGF0aWMgaW50IGlteDhtX2Js a19jdHJsX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCiAgICAgICAgICAgICAg ICAgICAgICAgIHJldHVybiBkZXZfZXJyX3Byb2JlKGRldiwgUFRSX0VSUihiYy0+YnVzX3Bvd2Vy X2RldiksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJmYWls ZWQgdG8gYXR0YWNoIHBvd2VyIGRvbWFpbiBcImJ1c1wiXG4iKTsKICAgICAgICB9CisgICAgICAg ZGV2aWNlX21vdmUoZGV2LCBiYy0+YnVzX3Bvd2VyX2RldiwgRFBNX09SREVSX1BBUkVOVF9CRUZP UkVfREVWKTsKIAogICAgICAgIGZvciAoaSA9IDA7IGkgPCBiY19kYXRhLT5udW1fZG9tYWluczsg aSsrKSB7CiAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgaW14OG1fYmxrX2N0cmxfZG9tYWlu X2RhdGEgKmRhdGEgPSAmYmNfZGF0YS0+ZG9tYWluc1tpXTsKQEAgLTI2OCw2ICsyNjksNyBAQCBz dGF0aWMgaW50IGlteDhtX2Jsa19jdHJsX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGF0YS0+Z3BjX25hbWUp OwogICAgICAgICAgICAgICAgICAgICAgICBnb3RvIGNsZWFudXBfcGRzOwogICAgICAgICAgICAg ICAgfQorICAgICAgICAgICAgICAgZGV2aWNlX21vdmUoZGV2LCBkb21haW4tPnBvd2VyX2Rldiwg RFBNX09SREVSX1BBUkVOVF9CRUZPUkVfREVWKTsKIAogICAgICAgICAgICAgICAgZG9tYWluLT5n ZW5wZC5uYW1lID0gZGF0YS0+bmFtZTsKICAgICAgICAgICAgICAgIGRvbWFpbi0+Z2VucGQucG93 ZXJfb24gPSBpbXg4bV9ibGtfY3RybF9wb3dlcl9vbjsKCmFueSBjb25jZXJuIGFib3V0IHRoaXMg YXBwcm9hY2g/CgpCZXN0IHJlZ2FyZHMsClZpdG9yIFNvYXJlcwo+IAo+ID4gCj4gPiA+IAo+ID4g PiAKPiA+ID4gPiAKPiA+ID4gPiBSZWdhcmRzLAo+ID4gPiA+IEx1Y2FzCj4gPiA+ID4gCj4gPiA+ ID4gPiBEbyB5b3UgaGF2ZSBhbiBpZGVhIGhvdyB3ZSBjYW4gYWRkcmVzcyB0aGlzIHdpdGhpbiBi bGstY3RybD8KPiA+ID4gPiA+IAo+ID4gPiA+ID4gQmVzdCByZWdhcmRzLAo+ID4gPiA+ID4gVml0 b3IKPiA+ID4gCj4gPiAKPiAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==