From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA6CDC433E0 for ; Thu, 28 Jan 2021 11:53:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C59764D9F for ; Thu, 28 Jan 2021 11:53:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C59764D9F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 91E336E162; Thu, 28 Jan 2021 11:53:34 +0000 (UTC) Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 37BC56E162 for ; Thu, 28 Jan 2021 11:53:33 +0000 (UTC) Received: by mail-ed1-x52a.google.com with SMTP id bx12so6247417edb.8 for ; Thu, 28 Jan 2021 03:53:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=DkJgFwX0t54l53HJntHsCKNxF0CgsuSqjgDoEoK0aa4=; b=Q1xSvStcwXIVzB9au194I1ynsiJZoqq5DEe7MwOQGLW7DwwFnnERJxv29j7n7Gj9Y3 co4fWNRY58BvpzPdrx+mor/jOp+8RDvl5cRtXR+OGFnsIxdmAWRArwO7Tccz3L4KFqUh j2dz9YCfeOCWpGEdqh1sFwjHc0lqcohew5Dk3uaz6eES99OanWmGwWAEVeMVwiPDcg3m vwY3bPwtwpJ3JrHDD7D0KMCi4+CD6YqlUVD5WMwmB4y+klecpwKSLRfgNl0It1f6aQlJ bOU9PaW5XGSiwQQGQasRg7fbtkA9hgObegk28meJ1FCZbieERIzJnggqc6GD+SYh1PtO tmzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=DkJgFwX0t54l53HJntHsCKNxF0CgsuSqjgDoEoK0aa4=; b=dOWlOoHg21PQzVlV2VxqTLgx+zYIx13aeeH1xjAH6mPQyN37xStK0ArPKqRj1iIify DWY8aETXiBx9UPdyvGh7aIreeiTcOQW+DeafJqt5vk29m6ZyAdv0Y7cAD/p3epY4hiSs MlzzTA6zxZfioLlsT3tcWkqqvlTIL2GYew7wXnW/QXz7hpgTQl9zeN7Q5i3WeezE5zut QW8GxsQA1TSlzGKmiSAuKkFEM9y5RhU0YthU8Lkln3tkmzLZXV1B5RZVL7bue0eTU56O kNQ8kU0BdMUtAlA4aTgcKD9Z8xwslbdoGSpsMbU0lyjrE7eWuD/8/hEdYBGAp1k6WQzx U8Jg== X-Gm-Message-State: AOAM533/DtMlkHFDiA5eTnQ3bJorbsHJpl7DYCHDdWiUZpl7FsbvIR74 utiiX2+3kbf5mwOroA1fNyY= X-Google-Smtp-Source: ABdhPJx9koQXi2Y5O82nCVvb3L6cYygKnjgNVq8w0I5z8DSed3RDQKRA5Yt60uWtPV5kqQVeFZQjNQ== X-Received: by 2002:a05:6402:46:: with SMTP id f6mr13583297edu.163.1611834811897; Thu, 28 Jan 2021 03:53:31 -0800 (PST) Received: from ?IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7? ([2a02:908:1252:fb60:be8a:bd56:1f94:86e7]) by smtp.gmail.com with ESMTPSA id k26sm2913867eds.41.2021.01.28.03.53.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jan 2021 03:53:30 -0800 (PST) Subject: Re: [Linaro-mm-sig] [PATCH v3] dmabuf: Add the capability to expose DMA-BUF stats in sysfs To: Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= References: <20210126204240.418297-1-hridya@google.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Thu, 28 Jan 2021 12:53:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: christian.koenig@amd.com Cc: Android Kernel Team , kernel test robot , Greg KH , LKML , DRI mailing list , Linaro MM SIG , hyesoo.yu@samsung.com, Hridya Valsaraju , Suren Baghdasaryan , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" QW0gMjguMDEuMjEgdW0gMTI6MDAgc2NocmllYiBTdW1pdCBTZW13YWw6Cj4gSGkgSHJpZHlhLAo+ Cj4gT24gV2VkLCAyNyBKYW4gMjAyMSBhdCAxNzozNiwgR3JlZyBLSCA8Z3JlZ2toQGxpbnV4Zm91 bmRhdGlvbi5vcmc+IHdyb3RlOgo+PiBPbiBUdWUsIEphbiAyNiwgMjAyMSBhdCAxMjo0MjozNlBN IC0wODAwLCBIcmlkeWEgVmFsc2FyYWp1IHdyb3RlOgo+Pj4gVGhpcyBwYXRjaCBhbGxvd3Mgc3Rh dGlzdGljcyB0byBiZSBlbmFibGVkIGZvciBlYWNoIERNQS1CVUYgaW4KPj4+IHN5c2ZzIGJ5IGVu YWJsaW5nIHRoZSBjb25maWcgQ09ORklHX0RNQUJVRl9TWVNGU19TVEFUUy4KPj4+Cj4+PiBUaGUg Zm9sbG93aW5nIHN0YXRzIHdpbGwgYmUgZXhwb3NlZCBieSB0aGUgaW50ZXJmYWNlOgo+Pj4KPj4+ IC9zeXMva2VybmVsL2RtYWJ1Zi9idWZmZXJzLzxpbm9kZV9udW1iZXI+L2V4cG9ydGVyX25hbWUK Pj4+IC9zeXMva2VybmVsL2RtYWJ1Zi9idWZmZXJzLzxpbm9kZV9udW1iZXI+L3NpemUKPj4+IC9z eXMva2VybmVsL2RtYWJ1Zi9idWZmZXJzLzxpbm9kZV9udW1iZXI+L2F0dGFjaG1lbnRzLzxhdHRh Y2hfdWlkPi9kZXZpY2UKPj4+IC9zeXMva2VybmVsL2RtYWJ1Zi9idWZmZXJzLzxpbm9kZV9udW1i ZXI+L2F0dGFjaG1lbnRzLzxhdHRhY2hfdWlkPi9tYXBfY291bnRlcgo+Pj4KPj4+IFRoZSBpbm9k ZV9udW1iZXIgaXMgdW5pcXVlIGZvciBlYWNoIERNQS1CVUYgYW5kIHdhcyBhZGRlZCBlYXJsaWVy IFsxXQo+Pj4gaW4gb3JkZXIgdG8gYWxsb3cgdXNlcnNwYWNlIHRvIHRyYWNrIERNQS1CVUYgdXNh Z2UgYWNyb3NzIGRpZmZlcmVudAo+Pj4gcHJvY2Vzc2VzLgo+Pj4KPj4+IEN1cnJlbnRseSwgdGhp cyBpbmZvcm1hdGlvbiBpcyBleHBvc2VkIGluCj4+PiAvc3lzL2tlcm5lbC9kZWJ1Zy9kbWFfYnVm L2J1ZmluZm8uCj4+PiBIb3dldmVyLCBzaW5jZSBkZWJ1Z2ZzIGlzIGNvbnNpZGVyZWQgdW5zYWZl IHRvIGJlIG1vdW50ZWQgaW4gcHJvZHVjdGlvbiwKPj4+IGl0IGlzIGJlaW5nIGR1cGxpY2F0ZWQg aW4gc3lzZnMuCj4+Pgo+Pj4gVGhpcyBpbmZvcm1hdGlvbiB3aWxsIGJlIHVzZWQgdG8gZGVyaXZl IERNQS1CVUYKPj4+IHBlci1leHBvcnRlciBzdGF0cyBhbmQgcGVyLWRldmljZSB1c2FnZSBzdGF0 cyBmb3IgQW5kcm9pZCBCdWcgcmVwb3J0cy4KPj4+IFRoZSBjb3JyZXNwb25kaW5nIHVzZXJzcGFj ZSBjaGFuZ2VzIGNhbiBiZSBmb3VuZCBhdCBbMl0uCj4+PiBUZWxlbWV0cnkgdG9vbHMgd2lsbCBh bHNvIGNhcHR1cmUgdGhpcyBpbmZvcm1hdGlvbihhbG9uZyB3aXRoIG90aGVyCj4+PiBtZW1vcnkg bWV0cmljcykgcGVyaW9kaWNhbGx5IGFzIHdlbGwgYXMgb24gaW1wb3J0YW50IGV2ZW50cyBsaWtl IGEKPj4+IGZvcmVncm91bmQgYXBwIGtpbGwgKHdoaWNoIG1pZ2h0IGhhdmUgYmVlbiB0cmlnZ2Vy ZWQgYnkgTG93IE1lbW9yeQo+Pj4gS2lsbGVyKS4gSXQgd2lsbCBhbHNvIGNvbnRyaWJ1dGUgdG8g cHJvdmlkZSBhIHNuYXBzaG90IG9mIHRoZSBzeXN0ZW0KPj4+IG1lbW9yeSB1c2FnZSBvbiBvdGhl ciBldmVudHMgc3VjaCBhcyBPT00ga2lsbHMgYW5kIEFwcGxpY2F0aW9uIE5vdAo+Pj4gUmVzcG9u ZGluZyBldmVudHMuCj4+Pgo+Pj4gQSBzaGVsbCBzY3JpcHQgdGhhdCBjYW4gYmUgcnVuIG9uIGEg Y2xhc3NpYyBMaW51eCBlbnZpcm9ubWVudCB0byByZWFkCj4+PiBvdXQgdGhlIERNQS1CVUYgc3Rh dGlzdGljcyBjYW4gYmUgZm91bmQgYXQgWzNdKHN1Z2dlc3RlZCBieSBKb2huCj4+PiBTdHVsdHop Lgo+Pj4KPj4+IFRoZSBwYXRjaCBjb250YWlucyB0aGUgZm9sbG93aW5nIGltcHJvdmVtZW50cyBv dmVyIHRoZSBwcmV2aW91cyB2ZXJzaW9uOgo+Pj4gMSkgRWFjaCBhdHRhY2htZW50IGlzIHJlcHJl c2VudGVkIGJ5IGl0cyBvd24gZGlyZWN0b3J5IHRvIGFsbG93IGNyZWF0aW5nCj4+PiBhIHN5bWxp bmsgdG8gdGhlIGltcG9ydGluZyBkZXZpY2UgYW5kIHRvIGFsc28gcHJvdmlkZSByb29tIGZvciBm dXR1cmUKPj4+IGV4cGFuc2lvbi4KPj4+IDIpIFRoZSBudW1iZXIgb2YgZGlzdGluY3QgbWFwcGlu Z3Mgb2YgZWFjaCBhdHRhY2htZW50IGlzIGV4cG9zZWQgaW4gYQo+Pj4gc2VwYXJhdGUgZmlsZS4K Pj4+IDMpIFRoZSBwZXItYnVmZmVyIHN0YXRpc3RpY3MgYXJlIG5vdyBpbiAvc3lzL2tlcm5lbC9k bWFidWYvYnVmZmVycwo+Pj4gaW5vcmRlciB0byBtYWtlIHRoZSBpbnRlcmZhY2UgZXhwYW5kYWJs ZSBpbiBmdXR1cmUuCj4+Pgo+Pj4gQWxsIG9mIHRoZSBpbXByb3ZlbWVudHMgYWJvdmUgYXJlIGJh c2VkIG9uIHN1Z2dlc3Rpb25zL2ZlZWRiYWNrIGZyb20KPj4+IERhbmllbCBWZXR0ZXIgYW5kIENo cmlzdGlhbiBLw7ZuaWcuCj4+Pgo+Pj4gWzFdOiBodHRwczovL2xvcmUua2VybmVsLm9yZy9wYXRj aHdvcmsvcGF0Y2gvMTA4ODc5MS8KPj4+IFsyXTogaHR0cHM6Ly9hbmRyb2lkLXJldmlldy5nb29n bGVzb3VyY2UuY29tL3EvdG9waWM6JTIyZG1hYnVmLXN5c2ZzJTIyKyhzdGF0dXM6b3BlbiUyME9S JTIwc3RhdHVzOm1lcmdlZCkKPj4+IFszXTogaHR0cHM6Ly9hbmRyb2lkLXJldmlldy5nb29nbGVz b3VyY2UuY29tL2MvcGxhdGZvcm0vc3lzdGVtL21lbW9yeS9saWJtZW1pbmZvLysvMTU0OTczNAo+ Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IEhyaWR5YSBWYWxzYXJhanUgPGhyaWR5YUBnb29nbGUuY29t Pgo+Pj4gUmVwb3J0ZWQtYnk6IGtlcm5lbCB0ZXN0IHJvYm90IDxsa3BAaW50ZWwuY29tPgo+IFRo YW5rcyBmb3IgdGhlIHBhdGNoIQo+Cj4gQ2hyaXN0aWFuOiBJZiB5b3UncmUgc2F0aXNmaWVkIHdp dGggdGhlIGV4cGxhbmF0aW9uIGFyb3VuZCBub3QKPiBkaXJlY3RseSBlbWJlZGRpbmcga29iamVj dHMgaW50byB0aGUgZG1hX2J1ZiBhbmQgZG1hX2J1Zl9hdHRhY2htZW50Cj4gc3RydWN0cywgdGhl biB3aXRoIEdyZWcncyByLWIgZnJvbSBzeXNmcyBQb1YsIEkgdGhpbmsgd2UgY2FuIG1lcmdlIGl0 Lgo+IFBsZWFzZSBsZXQgbWUga25vdyBpZiB5b3UgZmVlbCBvdGhlcndpc2UhCgogRnJvbSB0aGUg dGVjaG5pY2FsIHNpZGUgaXQgbG9va3MgY2xlYW4gdG8gbWUsIGZlZWwgZnJlZSB0byBhZGQgbXkg CmFja2VkLWJ5IHdoaWxlIHB1c2hpbmcuCgpCdXQgSSB3b3VsZCBhdCBsZWFzdCB0cnkgdG8gY29u dmluY2UgRGFuaWVsIG9uIHRoZSBkZXNpZ24uIEF0IGxlYXN0IHNvbWUgCm9mIGhpcyBjb25jZXJu cyBzZWVtcyB0byBiZSB2YWxpZCBhbmQga2VlcCBpbiBtaW5kIHRoYXQgd2UgbmVlZCB0byAKc3Vw cG9ydCB0aGlzIGludGVyZmFjZSBmb3JldmVyLgoKUmVnYXJkcywKQ2hyaXN0aWFuLgoKPgo+Pj4g LS0tCj4+PiBDaGFuZ2VzIGluIHYzOgo+Pj4gRml4IGEgd2FybmluZyByZXBvcnRlZCBieSB0aGUg a2VybmVsIHRlc3Qgcm9ib3QuCj4+Pgo+Pj4gQ2hhbmdlcyBpbiB2MjoKPj4+IC1Nb3ZlIHN0YXRp c3RpY3MgdG8gL3N5cy9rZXJuZWwvZG1hYnVmL2J1ZmZlcnMgaW4gb2RlciB0byBhbGxvdyBhZGRp dGlvbgo+Pj4gb2Ygb3RoZXIgRE1BLUJVRi1yZWxhdGVkIHN5c2ZzIHN0YXRzIGluIGZ1dHVyZS4g QmFzZWQgb24gZmVlZGJhY2sgZnJvbQo+Pj4gRGFuaWVsIFZldHRlci4KPj4+IC1FYWNoIGF0dGFj aG1lbnQgaGFzIGl0cyBvd24gZGlyZWN0b3J5IHRvIHJlcHJlc2VudCBhdHRhY2hpbmcgZGV2aWNl cyBhcwo+Pj4gc3ltbGlua3MgYW5kIHRvIGludHJvZHVjZSBtYXBfY291bnQgYXMgYSBzZXBhcmF0 ZSBmaWxlLiBCYXNlZCBvbgo+Pj4gZmVlZGJhY2sgZnJvbSBEYW5pZWwgVmV0dGVyIGFuZCBDaHJp c3RpYW4gS8O2bmlnLiBUaGFuayB5b3UgYm90aCEKPj4+IC1Db21taXQgbWVzc2FnZXMgdXBkYXRl ZCB0byBwb2ludCB0byB1c2Vyc3BhY2UgY29kZSBpbiBBT1NQIHRoYXQgd2lsbAo+Pj4gcmVhZCB0 aGUgRE1BLUJVRiBzeXNmcyBzdGF0cy4KPj4+Cj4+Pgo+Pj4gICAuLi4vQUJJL3Rlc3Rpbmcvc3lz ZnMta2VybmVsLWRtYWJ1Zi1idWZmZXJzICAgfCAgNTIgKysrKwo+Pj4gICBkcml2ZXJzL2RtYS1i dWYvS2NvbmZpZyAgICAgICAgICAgICAgICAgICAgICAgfCAgMTEgKwo+Pj4gICBkcml2ZXJzL2Rt YS1idWYvTWFrZWZpbGUgICAgICAgICAgICAgICAgICAgICAgfCAgIDEgKwo+Pj4gICBkcml2ZXJz L2RtYS1idWYvZG1hLWJ1Zi1zeXNmcy1zdGF0cy5jICAgICAgICAgfCAyODUgKysrKysrKysrKysr KysrKysrCj4+PiAgIGRyaXZlcnMvZG1hLWJ1Zi9kbWEtYnVmLXN5c2ZzLXN0YXRzLmggICAgICAg ICB8ICA2MiArKysrCj4+PiAgIGRyaXZlcnMvZG1hLWJ1Zi9kbWEtYnVmLmMgICAgICAgICAgICAg ICAgICAgICB8ICAzNyArKysKPj4+ICAgaW5jbHVkZS9saW51eC9kbWEtYnVmLmggICAgICAgICAg ICAgICAgICAgICAgIHwgIDIwICsrCj4+PiAgIDcgZmlsZXMgY2hhbmdlZCwgNDY4IGluc2VydGlv bnMoKykKPj4+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vQUJJL3Rlc3Rpbmcv c3lzZnMta2VybmVsLWRtYWJ1Zi1idWZmZXJzCj4+PiAgIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2 ZXJzL2RtYS1idWYvZG1hLWJ1Zi1zeXNmcy1zdGF0cy5jCj4+PiAgIGNyZWF0ZSBtb2RlIDEwMDY0 NCBkcml2ZXJzL2RtYS1idWYvZG1hLWJ1Zi1zeXNmcy1zdGF0cy5oCj4+IEkgZG9uJ3Qga25vdyB0 aGUgZG1hLWJ1ZiBjb2RlIGF0IGFsbCwgYnV0IGZyb20gYSBzeXNmcy9rb2JqZWN0IHBvaW50IG9m Cj4+IHZpZXcsIHRoaXMgcGF0Y2ggbG9va3MgZ29vZCB0byBtZToKPj4KPj4gUmV2aWV3ZWQtYnk6 IEdyZWcgS3JvYWgtSGFydG1hbiA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+Cj4gQmVzdCwK PiBTdW1pdC4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xwo+IExpbmFyby1tbS1zaWcgbWFpbGluZyBsaXN0Cj4gTGluYXJvLW1tLXNpZ0BsaXN0cy5saW5h cm8ub3JnCj4gaHR0cHM6Ly9saXN0cy5saW5hcm8ub3JnL21haWxtYW4vbGlzdGluZm8vbGluYXJv LW1tLXNpZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99652C433E0 for ; Thu, 28 Jan 2021 11:54:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 440EC64DD8 for ; Thu, 28 Jan 2021 11:54:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231151AbhA1LyR (ORCPT ); Thu, 28 Jan 2021 06:54:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229651AbhA1LyO (ORCPT ); Thu, 28 Jan 2021 06:54:14 -0500 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1F78C061573; Thu, 28 Jan 2021 03:53:33 -0800 (PST) Received: by mail-ed1-x535.google.com with SMTP id j13so6276402edp.2; Thu, 28 Jan 2021 03:53:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=DkJgFwX0t54l53HJntHsCKNxF0CgsuSqjgDoEoK0aa4=; b=Q1xSvStcwXIVzB9au194I1ynsiJZoqq5DEe7MwOQGLW7DwwFnnERJxv29j7n7Gj9Y3 co4fWNRY58BvpzPdrx+mor/jOp+8RDvl5cRtXR+OGFnsIxdmAWRArwO7Tccz3L4KFqUh j2dz9YCfeOCWpGEdqh1sFwjHc0lqcohew5Dk3uaz6eES99OanWmGwWAEVeMVwiPDcg3m vwY3bPwtwpJ3JrHDD7D0KMCi4+CD6YqlUVD5WMwmB4y+klecpwKSLRfgNl0It1f6aQlJ bOU9PaW5XGSiwQQGQasRg7fbtkA9hgObegk28meJ1FCZbieERIzJnggqc6GD+SYh1PtO tmzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=DkJgFwX0t54l53HJntHsCKNxF0CgsuSqjgDoEoK0aa4=; b=WnTa+XMmBlNy9/1Cx1JqfiF1jWD/NrQCCfSrZNWgFui8evrRNPFzkfV7vGeDkiJHZl PtnB26dWrn6/68Ssiv2YJF1Ls7XiRAgpV3DzcszPbaEgY4R16Y81MVRXewLbXF7IfYO9 HutHGaiSZg0/HtXdzHoFJIL6nugbEPKO6i1oKnu37lRBjVBemx36e3lnHrnZ7J3qy/cW oS6rMhhu8sfYqCGZk5qMG2y25paR7gHdh1PkzjnqJtD1PT6eJVI5TUtg06mvUEe+S+vN QalGplgjiU3k3llFaOiFdxvqPUdnOEZmKapeo0HbSPu2XhUFIKS1cKOB/Rs/IhO2eE+Z xbBQ== X-Gm-Message-State: AOAM531ltsTWcNuWOsgtq6qFz15pFk9yUFLuR5w4ebo6rXrr139yRqc3 Ug6cznNhB5y828s1WUQ8ZluywP+yOEM= X-Google-Smtp-Source: ABdhPJx9koQXi2Y5O82nCVvb3L6cYygKnjgNVq8w0I5z8DSed3RDQKRA5Yt60uWtPV5kqQVeFZQjNQ== X-Received: by 2002:a05:6402:46:: with SMTP id f6mr13583297edu.163.1611834811897; Thu, 28 Jan 2021 03:53:31 -0800 (PST) Received: from ?IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7? ([2a02:908:1252:fb60:be8a:bd56:1f94:86e7]) by smtp.gmail.com with ESMTPSA id k26sm2913867eds.41.2021.01.28.03.53.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jan 2021 03:53:30 -0800 (PST) Reply-To: christian.koenig@amd.com Subject: Re: [Linaro-mm-sig] [PATCH v3] dmabuf: Add the capability to expose DMA-BUF stats in sysfs To: Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= Cc: kernel test robot , Suren Baghdasaryan , LKML , DRI mailing list , Linaro MM SIG , hyesoo.yu@samsung.com, John Stultz , Greg KH , Hridya Valsaraju , Android Kernel Team , "open list:DMA BUFFER SHARING FRAMEWORK" References: <20210126204240.418297-1-hridya@google.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Thu, 28 Jan 2021 12:53:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Am 28.01.21 um 12:00 schrieb Sumit Semwal: > Hi Hridya, > > On Wed, 27 Jan 2021 at 17:36, Greg KH wrote: >> On Tue, Jan 26, 2021 at 12:42:36PM -0800, Hridya Valsaraju wrote: >>> This patch allows statistics to be enabled for each DMA-BUF in >>> sysfs by enabling the config CONFIG_DMABUF_SYSFS_STATS. >>> >>> The following stats will be exposed by the interface: >>> >>> /sys/kernel/dmabuf/buffers//exporter_name >>> /sys/kernel/dmabuf/buffers//size >>> /sys/kernel/dmabuf/buffers//attachments//device >>> /sys/kernel/dmabuf/buffers//attachments//map_counter >>> >>> The inode_number is unique for each DMA-BUF and was added earlier [1] >>> in order to allow userspace to track DMA-BUF usage across different >>> processes. >>> >>> Currently, this information is exposed in >>> /sys/kernel/debug/dma_buf/bufinfo. >>> However, since debugfs is considered unsafe to be mounted in production, >>> it is being duplicated in sysfs. >>> >>> This information will be used to derive DMA-BUF >>> per-exporter stats and per-device usage stats for Android Bug reports. >>> The corresponding userspace changes can be found at [2]. >>> Telemetry tools will also capture this information(along with other >>> memory metrics) periodically as well as on important events like a >>> foreground app kill (which might have been triggered by Low Memory >>> Killer). It will also contribute to provide a snapshot of the system >>> memory usage on other events such as OOM kills and Application Not >>> Responding events. >>> >>> A shell script that can be run on a classic Linux environment to read >>> out the DMA-BUF statistics can be found at [3](suggested by John >>> Stultz). >>> >>> The patch contains the following improvements over the previous version: >>> 1) Each attachment is represented by its own directory to allow creating >>> a symlink to the importing device and to also provide room for future >>> expansion. >>> 2) The number of distinct mappings of each attachment is exposed in a >>> separate file. >>> 3) The per-buffer statistics are now in /sys/kernel/dmabuf/buffers >>> inorder to make the interface expandable in future. >>> >>> All of the improvements above are based on suggestions/feedback from >>> Daniel Vetter and Christian König. >>> >>> [1]: https://lore.kernel.org/patchwork/patch/1088791/ >>> [2]: https://android-review.googlesource.com/q/topic:%22dmabuf-sysfs%22+(status:open%20OR%20status:merged) >>> [3]: https://android-review.googlesource.com/c/platform/system/memory/libmeminfo/+/1549734 >>> >>> Signed-off-by: Hridya Valsaraju >>> Reported-by: kernel test robot > Thanks for the patch! > > Christian: If you're satisfied with the explanation around not > directly embedding kobjects into the dma_buf and dma_buf_attachment > structs, then with Greg's r-b from sysfs PoV, I think we can merge it. > Please let me know if you feel otherwise! From the technical side it looks clean to me, feel free to add my acked-by while pushing. But I would at least try to convince Daniel on the design. At least some of his concerns seems to be valid and keep in mind that we need to support this interface forever. Regards, Christian. > >>> --- >>> Changes in v3: >>> Fix a warning reported by the kernel test robot. >>> >>> Changes in v2: >>> -Move statistics to /sys/kernel/dmabuf/buffers in oder to allow addition >>> of other DMA-BUF-related sysfs stats in future. Based on feedback from >>> Daniel Vetter. >>> -Each attachment has its own directory to represent attaching devices as >>> symlinks and to introduce map_count as a separate file. Based on >>> feedback from Daniel Vetter and Christian König. Thank you both! >>> -Commit messages updated to point to userspace code in AOSP that will >>> read the DMA-BUF sysfs stats. >>> >>> >>> .../ABI/testing/sysfs-kernel-dmabuf-buffers | 52 ++++ >>> drivers/dma-buf/Kconfig | 11 + >>> drivers/dma-buf/Makefile | 1 + >>> drivers/dma-buf/dma-buf-sysfs-stats.c | 285 ++++++++++++++++++ >>> drivers/dma-buf/dma-buf-sysfs-stats.h | 62 ++++ >>> drivers/dma-buf/dma-buf.c | 37 +++ >>> include/linux/dma-buf.h | 20 ++ >>> 7 files changed, 468 insertions(+) >>> create mode 100644 Documentation/ABI/testing/sysfs-kernel-dmabuf-buffers >>> create mode 100644 drivers/dma-buf/dma-buf-sysfs-stats.c >>> create mode 100644 drivers/dma-buf/dma-buf-sysfs-stats.h >> I don't know the dma-buf code at all, but from a sysfs/kobject point of >> view, this patch looks good to me: >> >> Reviewed-by: Greg Kroah-Hartman > Best, > Sumit. > _______________________________________________ > Linaro-mm-sig mailing list > Linaro-mm-sig@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/linaro-mm-sig