From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yassine Ouaissa <yassine.ouaissa@allegrodvt.com>
Cc: Michael Tretter <m.tretter@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Michal Simek <michal.simek@amd.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Aradhya Bhatia <a-bhatia1@ti.com>,
Rafa?? Mi??ecki <rafal@milecki.pl>,
Junhao Xie <bigfoot@classfun.cn>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Kever Yang <kever.yang@rock-chips.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>,
Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>,
Gaosheng Cui <cuigaosheng1@huawei.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Uwe Kleine-K??nig <u.kleine-koenig@baylibre.com>,
Ricardo Ribalda <ribalda@chromium.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] media: allegro-dvt: Add DT-bindings for the Gen 3 IP
Date: Wed, 14 May 2025 10:01:14 +0200 [thread overview]
Message-ID: <c071c53e-4cbc-4daa-bb02-c8bce3eed538@kernel.org> (raw)
In-Reply-To: <5cth47emwdjyc7dt35a5n2zeh4lkklgdpp2r2qs6s2qgiye6et@oxb2a4tene4k>
On 12/05/2025 13:17, Yassine Ouaissa wrote:
> On 12.05.2025 12:42, Krzysztof Kozlowski wrote:
>> On Mon, May 12, 2025 at 08:23:11AM GMT, Yassine Ouaissa wrote:
>>> issue fixed also, thanks.
>>>>> + significant advancements over its predecessors. This new decoder features
>>>>> + enhanced processing capabilities with improved throughput and reduced latency.
>>>>> +
>>>>> + Communication between the host driver software and the MCU is implemented through
>>>>> + a specialized mailbox interface mechanism. This mailbox system provides a
>>>>> + structured channel for exchanging commands, parameters, and status information
>>>>> + between the host CPU and the MCU controlling the codec engines.
>>>>> +
>>>>> +properties:
>>>>> + compatible:
>>>>> + const: allegrodvt,al300-vdec
>>>>
>>>> Undocumented prefix.
>>>>
>>>> What is the actual device name? al300? Can you have al300-adec? or
>>>> al300-dec?
>>>>
>>>>
>>>
>>> the device name is al300, the vdec is for decoder driver.
>>
>> So drop vdec. Compatible should reflect device name.
>>
>
> We cannot, the IP could have the encode and decode in the same time.
> the al300 is for the IP gen, and vdec/venc for the driver compatible.
>
> I'll discuss with the team, about other naming.
Do not send next version - like you did now - before we finish
discussion. You just sent the same bypassing this entire discussion.
Explain what is the device name, what is the device so we can understand it.
I also expect all other comments to be implemented - including
clock-names and incorrect device node name.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-14 8:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-11 14:47 [PATCH 0/3] media: Add Gen 3 IP stateful decoder driver Yassine Ouaissa
2025-05-11 14:47 ` [PATCH 1/3] media: allegro-dvt: Move the current driver to a subdirectory Yassine Ouaissa
2025-05-11 14:47 ` [PATCH 2/3] media: allegro-dvt: Add Gen 3 IP stateful decoder driver Yassine Ouaissa
2025-05-11 20:49 ` kernel test robot
2025-05-12 22:39 ` kernel test robot
2025-05-11 14:47 ` [PATCH 3/3] media: allegro-dvt: Add DT-bindings for the Gen 3 IP Yassine Ouaissa
2025-05-11 16:38 ` Rob Herring (Arm)
2025-05-11 20:03 ` Krzysztof Kozlowski
2025-05-12 8:23 ` Yassine Ouaissa
2025-05-12 10:42 ` Krzysztof Kozlowski
2025-05-12 11:17 ` Yassine Ouaissa
2025-05-14 8:01 ` Krzysztof Kozlowski [this message]
2025-05-14 7:59 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c071c53e-4cbc-4daa-bb02-c8bce3eed538@kernel.org \
--to=krzk@kernel.org \
--cc=a-bhatia1@ti.com \
--cc=andrzejtp2010@gmail.com \
--cc=bigfoot@classfun.cn \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=cuigaosheng1@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=hverkuil@xs4all.nl \
--cc=joe@pf.is.s.u-tokyo.ac.jp \
--cc=kernel@pengutronix.de \
--cc=kever.yang@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.tretter@pengutronix.de \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mchehab@kernel.org \
--cc=michal.simek@amd.com \
--cc=neil.armstrong@linaro.org \
--cc=rafal@milecki.pl \
--cc=ribalda@chromium.org \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yassine.ouaissa@allegrodvt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.