RE: [PATCH rtw-next] wifi: rtw88: 8723b: always report a single spatial stream

[Ping-Ke Shih <pkshih@realtek.com>]

Luka Gejak <luka.gejak@linux.dev> wrote:
> RTL8723B only ever has one spatial stream. Set nss and ant_num to 1
> directly instead of deriving them from rf_path_num, which just happens
> to be 1 on this chip.
> 
> Signed-off-by: Luka Gejak <luka.gejak@linux.dev>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>


> ---
>  drivers/net/wireless/realtek/rtw88/rtw8723b.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723b.c
> b/drivers/net/wireless/realtek/rtw88/rtw8723b.c
> index 8bb9c03d769c..89190dd4f5c7 100644
> --- a/drivers/net/wireless/realtek/rtw88/rtw8723b.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8723b.c
> @@ -2365,12 +2365,9 @@ static int rtw8723b_read_efuse(struct rtw_dev *rtwdev, u8 *log_map)
>         if (efuse->power_track_type != 0)
>                 rtw_warn(rtwdev, "unsupported power track type\n");
> 
> -       /*
> -        * No firmware hardware feature report exists, so fill the hardware
> -        * capability here; a zero stream count kills the HT MCS set.
> -        */
> -       efuse->hw_cap.nss = max_t(u8, rtwdev->hal.rf_path_num, 1);
> -       efuse->hw_cap.ant_num = efuse->hw_cap.nss;

Curiously, is there real hardware encountered the problem?

> +       /* No firmware hardware feature report exists, so fill it in here. */
> +       efuse->hw_cap.nss = 1;
> +       efuse->hw_cap.ant_num = 1;
>         efuse->hw_cap.bw = BIT(RTW_CHANNEL_WIDTH_20) |
>                            BIT(RTW_CHANNEL_WIDTH_40);
> 
> --
> 2.53.0