All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	<netdev@vger.kernel.org>
Cc: <joshua.a.hay@intel.com>, <przemyslaw.kitszel@intel.com>,
	Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH iwl-net] idpf: add missing cpu_to_le32 in idpf_tx_splitq_build_flow_desc
Date: Mon, 3 Aug 2026 13:37:59 -0700	[thread overview]
Message-ID: <c093518f-0b9c-4b1c-9587-ebe487497dc9@intel.com> (raw)
In-Reply-To: <willemdebruijn.kernel.2f2bc4b192e45@gmail.com>



On 8/2/2026 7:31 AM, Willem de Bruijn wrote:
> Willem de Bruijn wrote:
>> From: Willem de Bruijn <willemb@google.com>
>>
>> idpf_tx_splitq_build_flow_desc performs a 32-bit store to &cmd_dtype
>> to set the 8-bit cmd_dtype and zero the adjacent 3-byte timestamp
>> field in a single operation.
>>
>> Descriptors are in little endian. Add missing cpu_to_le32 and cast to
>> __le32 to ensure the fields are written correctly also on big endian
>> platforms.
>>
>> Signed-off-by: Willem de Bruijn <willemb@google.com>
> 
> Fixes: 1a49cf814fe1 ("idpf: add Tx timestamp flows")
> 
> Forgot the tag. Apologies.

I see it's for 'iwl-net' but IWL isn't on the send list. Seems 
straightforward enough that if netdev wants to take it directly, it's ok 
with me. If yes,

Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com>

Otherwise, could you add the Fixes and include IWL 
(intel-wired-lan@lists.osuosl.org) on the send?

Thanks,
Tony


  reply	other threads:[~2026-08-03 20:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31 10:31 [PATCH iwl-net] idpf: add missing cpu_to_le32 in idpf_tx_splitq_build_flow_desc Willem de Bruijn
2026-08-02 14:31 ` Willem de Bruijn
2026-08-03 20:37   ` Tony Nguyen [this message]
2026-08-03 21:11     ` Willem de Bruijn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c093518f-0b9c-4b1c-9587-ebe487497dc9@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=joshua.a.hay@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=willemb@google.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.