From: Ilya Leoshkevich <iii@linux.ibm.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Mahesh Bodapati" <mbodapat@xilinx.com>
Subject: Re: [PATCH] tests/docker: Fix microblaze atomics
Date: Tue, 24 Sep 2024 14:22:57 +0200 [thread overview]
Message-ID: <c0d81e09bd1ce5ee49dcb48715102efe2a1dbcb8.camel@linux.ibm.com> (raw)
In-Reply-To: <87wmj1clmh.fsf@draig.linaro.org>
On Tue, 2024-09-24 at 12:54 +0100, Alex Bennée wrote:
> Ilya Leoshkevich <iii@linux.ibm.com> writes:
>
> (add Mahesh to CC)
>
> > GCC produces invalid code for microblaze atomics.
> >
> > The fix is unfortunately not upstream, so fetch it from an external
> > location and apply it locally.
>
> Queued to testing/next, thanks.
>
> However I didn't see any tests failing so I'm curious where you saw
> the
> problem? Would it be worth adding an atomics test (microblaze or
> generic) to catch this?
It's very reliably caught by the new test that I'm proposing as a part
of this series:
https://lore.kernel.org/qemu-devel/20240923162208.90745-19-iii@linux.ibm.com/T/#u
>
> Also for the Microblaze guys is there any push to upstream the
> patches
> you have into GCC or have an easily distributively binary build we
> could
> convert our dockerfiles to?
>
> >
> > Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> > Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> > ---
> > .../debian-microblaze-cross.d/build-toolchain.sh | 8
> > ++++++++
> > tests/docker/dockerfiles/debian-toolchain.docker | 7
> > +++++++
> > 2 files changed, 15 insertions(+)
next prev parent reply other threads:[~2024-09-24 12:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 15:23 [PATCH] tests/docker: Fix microblaze atomics Ilya Leoshkevich
2024-09-24 11:54 ` Alex Bennée
2024-09-24 12:22 ` Ilya Leoshkevich [this message]
2024-09-24 18:02 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0d81e09bd1ce5ee49dcb48715102efe2a1dbcb8.camel@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=alex.bennee@linaro.org \
--cc=edgar.iglesias@gmail.com \
--cc=mbodapat@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.