From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Nilay Shroff <nilay@linux.ibm.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: "hch@lst.de" <hch@lst.de>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"gjoyce@linux.ibm.com" <gjoyce@linux.ibm.com>,
"axboe@fb.com" <axboe@fb.com>
Subject: Re: [PATCHv3] nvme: find numa distance only if controller has valid numa id
Date: Tue, 16 Apr 2024 09:07:10 +0000 [thread overview]
Message-ID: <c0dd0177-20d2-4d7b-aa44-ee29b2117c30@nvidia.com> (raw)
In-Reply-To: <20240416082102.914152-1-nilay@linux.ibm.com>
On 4/16/2024 1:19 AM, Nilay Shroff wrote:
> On system where native nvme multipath is configured and iopolicy
> is set to numa but the nvme controller numa node id is undefined
> or -1 (NUMA_NO_NODE) then avoid calculating node distance for
> finding optimal io path. In such case we may access numa distance
> table with invalid index and that may potentially refer to incorrect
> memory. So this patch ensures that if the nvme controller numa node
> id is -1 then instead of calculating node distance for finding optimal
> io path, we set the numa node distance of such controller to default 10
> (LOCAL_DISTANCE).
>
> Link:https://lore.kernel.org/all/20240413090614.678353-1-nilay@linux.ibm.com/
> Signed-off-by: Nilay Shroff<nilay@linux.ibm.com>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2024-04-16 9:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 8:19 [PATCHv3] nvme: find numa distance only if controller has valid numa id Nilay Shroff
2024-04-16 9:07 ` Chaitanya Kulkarni [this message]
2024-04-16 9:43 ` Sagi Grimberg
2024-04-16 15:14 ` Christoph Hellwig
2024-04-16 16:44 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0dd0177-20d2-4d7b-aa44-ee29b2117c30@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@fb.com \
--cc=gjoyce@linux.ibm.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.