From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Tamas K Lengyel" <tamas@tklengyel.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/4] xen/evtchn: Switch to dmalloc
Date: Tue, 5 Jan 2021 17:09:43 +0100 [thread overview]
Message-ID: <c0f7609c-af1c-2296-8362-4dde2848871f@suse.com> (raw)
In-Reply-To: <20201223163442.8840-3-andrew.cooper3@citrix.com>
On 23.12.2020 17:34, Andrew Cooper wrote:
> RFC: Likely more to convert. This is just a minimal attempt.
Looks complete as far as this one file goes. More can be found
in evtchn_fifo.c of course.
> --- a/xen/common/event_channel.c
> +++ b/xen/common/event_channel.c
> @@ -16,6 +16,7 @@
>
> #include "event_channel.h"
>
> +#include <xen/dmalloc.h>
> #include <xen/init.h>
> #include <xen/lib.h>
> #include <xen/errno.h>
> @@ -153,7 +154,7 @@ static struct evtchn *alloc_evtchn_bucket(struct domain *d, unsigned int port)
> struct evtchn *chn;
> unsigned int i;
>
> - chn = xzalloc_array(struct evtchn, EVTCHNS_PER_BUCKET);
> + chn = dzalloc_array(d, struct evtchn, EVTCHNS_PER_BUCKET);
> if ( !chn )
> return NULL;
There's an error path down from here which also needs converting.
Jan
next prev parent reply other threads:[~2021-01-05 16:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 16:34 [PATCH 0/4] xen: domain-tracked allocations, and fault injection Andrew Cooper
2020-12-23 16:34 ` [PATCH 1/4] xen/dmalloc: Introduce dmalloc() APIs Andrew Cooper
2021-01-05 15:56 ` Jan Beulich
2021-01-13 23:16 ` Andrew Cooper
2021-01-14 10:14 ` Jan Beulich
2021-01-14 15:30 ` Andrew Cooper
2021-01-05 16:01 ` Jan Beulich
2022-12-11 17:24 ` Julien Grall
2020-12-23 16:34 ` [PATCH 2/4] xen/evtchn: Switch to dmalloc Andrew Cooper
2021-01-05 16:09 ` Jan Beulich [this message]
2020-12-23 16:34 ` [PATCH 3/4] xen/domctl: Introduce fault_ttl Andrew Cooper
2021-01-05 16:39 ` Jan Beulich
2021-01-13 23:58 ` Andrew Cooper
2020-12-23 16:34 ` [PATCH 4/4] tools/misc: Test for fault injection Andrew Cooper
2020-12-23 16:41 ` Jan Beulich
2021-01-08 1:49 ` [PATCH 0/4] xen: domain-tracked allocations, and " Stefano Stabellini
2022-12-11 17:21 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0f7609c-af1c-2296-8362-4dde2848871f@suse.com \
--to=jbeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tamas@tklengyel.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.