From: Stephen Boyd <sboyd@kernel.org>
To: Rohit Visavalia <rohit.visavalia@amd.com>,
michal.simek@amd.com, mturquette@baylibre.com,
vishal.sagar@amd.com
Cc: javier.carrasco.cruz@gmail.com, geert+renesas@glider.be,
u.kleine-koenig@baylibre.com, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Rohit Visavalia <rohit.visavalia@amd.com>
Subject: Re: [PATCH 3/3] clk: xilinx: vcu: unregister pll_post only if registered correctly
Date: Mon, 30 Dec 2024 16:37:00 -0800 [thread overview]
Message-ID: <c110a740502cda3fafa55828292ce34c.sboyd@kernel.org> (raw)
In-Reply-To: <20241226122023.3439559-4-rohit.visavalia@amd.com>
Quoting Rohit Visavalia (2024-12-26 04:20:23)
> If registration of pll_post is failed, it will be set to NULL or ERR,
> unregistering same will fail with following call trace:
>
> Unable to handle kernel NULL pointer dereference at virtual address 008
> pc : clk_hw_unregister+0xc/0x20
> lr : clk_hw_unregister_fixed_factor+0x18/0x30
> sp : ffff800011923850
> ...
> Call trace:
> clk_hw_unregister+0xc/0x20
> clk_hw_unregister_fixed_factor+0x18/0x30
> xvcu_unregister_clock_provider+0xcc/0xf4 [xlnx_vcu]
> xvcu_probe+0x2bc/0x53c [xlnx_vcu]
>
> Signed-off-by: Rohit Visavalia <rohit.visavalia@amd.com>
Please add a Fixes tag, and put fixes earlier in the series so they can
be applied while other patches go through review.
next prev parent reply other threads:[~2024-12-31 0:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-26 12:20 [PATCH 0/3] clk: xilinx: vcu: Sequence update and couple of fixes Rohit Visavalia
2024-12-26 12:20 ` [PATCH 1/3] clk: xilinx: vcu: Update vcu init/reset sequence Rohit Visavalia
2024-12-31 0:39 ` Stephen Boyd
2024-12-31 14:16 ` Visavalia, Rohit
2024-12-31 14:26 ` Geert Uytterhoeven
2025-01-02 7:01 ` Visavalia, Rohit
2025-01-02 9:58 ` Geert Uytterhoeven
2025-01-02 10:05 ` Visavalia, Rohit
2024-12-26 12:20 ` [PATCH 2/3] clk: xilinx: vcu: don't set pll_ref as parent of VCU(enc/dec) clocks Rohit Visavalia
2024-12-31 0:35 ` Stephen Boyd
2024-12-31 14:16 ` Visavalia, Rohit
2024-12-26 12:20 ` [PATCH 3/3] clk: xilinx: vcu: unregister pll_post only if registered correctly Rohit Visavalia
2024-12-31 0:37 ` Stephen Boyd [this message]
2024-12-31 14:16 ` Visavalia, Rohit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c110a740502cda3fafa55828292ce34c.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=geert+renesas@glider.be \
--cc=javier.carrasco.cruz@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=mturquette@baylibre.com \
--cc=rohit.visavalia@amd.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=vishal.sagar@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.