From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012057.outbound.protection.outlook.com [40.93.195.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 788F1367B8B for ; Fri, 7 Aug 2026 14:14:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.195.57 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786112062; cv=fail; b=pdLmc/FP6NJmQTPJz/22C5Fi4adbIaQ+FMRikvb6sl8/1dheAEEPjOLUBhWkanFakpXzxS6q0zoJmpHCOo49BZF5z8JPsrOp35+hUBXc6O6rpXJenVnv6XoF+S6V28pqe64M/yNYrUST9oTFv/aAa6Suim7cEIS0be+2TdwybeA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786112062; c=relaxed/simple; bh=QKhYaGcaNJLOCRCAtHMcf/J0C/gc2GyNjzR9a5IBFdg=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=m6RSk93BjX8bL/zmLqDd+HewM7b0vDByZ96/mohCfxk/SBRjRZvSNxBRURO8B5cQQyPWhHs4RRuOWKVatN39AsRJdZWfRWkqRAdmN6Lqor44zwXVDJCx7K5pw9gZP505un1W0zuXKMfko8mqeOT1m85t6wo3AghZDj6yMp9A3Vo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=tocgeoMa; arc=fail smtp.client-ip=40.93.195.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="tocgeoMa" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ArhyEPDjB/rn1y7YaRx0cWnE3qje4LPOIjVFLZpfD2MRyLKcZZKaHFsm7OVanIYyim1GzQeVQw7jikhwsVVIf14MbtReGQOzBsddYvHt7cuRW4Yh0T3AqLdXa2j/u3aXnKLexJz726lQbFLWuSXMzFZjWC05MjflzvYbXXEUUkMmj2L+wF9XIuQgZhVL9aMqJ8xS+hU9HbRMpeXrMOLmttoMgeO+c0+a6zuMbJQamK/OmA1gVOL0Fafw4IEHD22DEq6zKgOBPCsI1u7n1WWMUgAsxCC2/SodC9EPpV8AmbYKLhkI+QzLx9zgjqKzUp7jthJ03e8lLVW2Dhz5NuBD3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9884hcNJjvg/GAWin5k5fSP9L0OKHdgGj7GspKj+omg=; b=FjMf2reENayR5hYhPcY21HqagJwxCVTJYteleCWiBFj6wqwEFYfy/jxTINvNZoMraryrcnlS4fdVcRnAR5X5N6lhFO9L9gsghTCAyPPl/9NMKso43cU32pWCEpoif0h1nwDc4O6SyBjNAofoiL0iw9RAVkirheC9sIhCdwRWOsZPGMTnPFGtTa/5gxz0sDtH9f1M6TnZdDPgpLWfefgYdvYWvexmOIxBDT+O6sZ9dmbr1xYU1v8qj3bMhPfmEyyWg7dZ5MUN2VqMMjviJ31NnHfdJhKEyOmyiCqNcZQ0fAknrGIXYLfyeRLbvNjwtgQrzm3qYvYzvdnwWKoEz/Or1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9884hcNJjvg/GAWin5k5fSP9L0OKHdgGj7GspKj+omg=; b=tocgeoMaU2WfUNmu5rJaffD6RHcAYxf29Gbreq75nGyCf2N6mUwlJzuuw4oeNRt8ebeLcCa3wX7Iv7BHBGWuoS3MQlLQvZHj9e0r3UH+FE9sC2CAoA13i0pTh7fWik6DPJGJwSFCi0sRF83gw+59VLfrvpYsnZDvdtF5NMyC1dA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from BL1PR12MB5320.namprd12.prod.outlook.com (2603:10b6:208:314::17) by PH7PR12MB8595.namprd12.prod.outlook.com (2603:10b6:510:1b5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.20; Fri, 7 Aug 2026 14:14:08 +0000 Received: from BL1PR12MB5320.namprd12.prod.outlook.com ([fe80::1876:4a6d:2cf5:b8d1]) by BL1PR12MB5320.namprd12.prod.outlook.com ([fe80::1876:4a6d:2cf5:b8d1%5]) with mapi id 15.21.0292.022; Fri, 7 Aug 2026 14:14:06 +0000 Message-ID: Date: Fri, 7 Aug 2026 09:14:03 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2] arm,x86,fs/resctrl: Generic schema description Proof of Concept To: Reinette Chatre , "Luck, Tony" Cc: Ben Horgan , James Morse , Dave Martin , Babu Moger , Drew Fustini , Fenghua Yu , Chen Yu , Borislav Petkov , Thomas Gleixner , Dave Hansen , Peter Newman , "x86@kernel.org" , "linux-kernel@vger.kernel.org" References: <7a8b6cc8-d194-4af2-9fb9-2438d2dcae01@intel.com> <9d0239e6-318e-4a59-937d-a64b839e02e9@intel.com> Content-Language: en-US From: "Moger, Babu" In-Reply-To: <9d0239e6-318e-4a59-937d-a64b839e02e9@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA0PR11CA0073.namprd11.prod.outlook.com (2603:10b6:806:d2::18) To BL1PR12MB5320.namprd12.prod.outlook.com (2603:10b6:208:314::17) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL1PR12MB5320:EE_|PH7PR12MB8595:EE_ X-MS-Office365-Filtering-Correlation-Id: 4757b6db-fc29-4a7a-3708-08def48e244c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|7416014|376014|366016|1800799024|18002099003|6133799003|56012099006|11063799006|10067099003|4143699003|22082099003; X-Microsoft-Antispam-Message-Info: jIWCtyX/Cp0UwqGMqMMjsJDlnsfyTRbomUq38e1b308u+6m6er2cO1PzzECOVsBNj/kfCI3WGzrAtP4BH+xoK4asN4xB032/bsZNyjCuytXkRAT+S6F50b0Xuov4YBPEwiDFDUnncaamKBymDUkOrFCYYuIUVmWnM6ciZfLRH2rOn65Kl/gFytP5QgJJ2BwkHi/RAGAi8NhPffJKU0dhQpH7D28ZGHEbTrB8mEdYGsQ1B5s94l0tHzBM7+058/OuP9WDr3MiRDkRH+TqLeMzSdd5DkztozDcMk+pCl3qhnI8mnI8PhjdVeChf5YxVxrJ4u+mJszfrLi01DtS15EgI0QvEuL4oH3AZfS/zzI+rs0eJoRwMMLzMvH/N74q/d9qbOFZBdWGJylTba/BYHzUu9siSIFJPP9lbWr6hxAI3zatVqBDDJl7rIFJbc17J3t0JSKUuoiW32cHQWu/KMDjgeyqgDnTbPg9A8YYJGaqSbYQLDz4XDwZJOSBXlr1q0W90h4BrslqlbfpbgRYWFOiTuI5OTqXO2bVzUsVYCsVq0BSDBH6N8h3RA5BpHJ8oUNpqtu2wpWSodTabHL+A35mmDCxzvdwsSJs97iMwwBQTDSzTllx8a5KpicxbN4zT9om1nqjoITmOsSf6b8xmo3P6s6brCNpqBUqCn05HLsyn/w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR12MB5320.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(7416014)(376014)(366016)(1800799024)(18002099003)(6133799003)(56012099006)(11063799006)(10067099003)(4143699003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eFA5TUVPMVE1WXpXRjJCRDJ3dGh2M0dzZzc0NUJCSkt2eTdLZlp3MSt4aG5m?= =?utf-8?B?NTJFaWVTZVlJZlRaKzd3NUp5R1N5c3VjNmpUdEErdlpQT2lMblNkVmFGb3RZ?= =?utf-8?B?am1RZzlybFZWRVdWV0FVNXY1S3o2UFM4NTlsY3JRWG9oSUpQandQc2srNHlw?= =?utf-8?B?OVNjRnhpY2hGMkphdmdqMnNtNzRFRzB2cFpKVUVxQjJFQnZJbUQyaTZtSFBV?= =?utf-8?B?dzNEV2I4WlRsTGNvcWRkL3ZsYjR2aStCZHFsUWh3aVNnLzVBWDN3V0RaYXVl?= =?utf-8?B?NHBteUxLU1JHZ2U3TEpuWXhsVWozMlI1ZVNvL1JLWXp5U2NoR0k3dXMvTjZi?= =?utf-8?B?M1VaVk9GMHIzSkQ3cU03QVRzSUhHV2taQk5FN1owM0NjWE1CTUcrb2x6cUd3?= =?utf-8?B?MXZSQUpWazhXWmw1bENJL2JtaTcvWWJMSGF0cGlUV3lXOGNMQkRMQXRGcUtw?= =?utf-8?B?K1ErMmxHeTRMajlleWYvN1BTcjg1eU96VVY5elFuaE5SZkZlNmdPOTNmRVRN?= =?utf-8?B?V1hLUndEYW8rRDNhVksyOTMyVjdzNVZqdFd4TndjMlcrcHZOWWJDSzZXTndv?= =?utf-8?B?T2pHNkszTHpxd2hObzJEcXdBTDVOUE8rTS84SE50eGtBbFA2S2JHQVVsb3du?= =?utf-8?B?d0Z5QW5iSUxwd3ZiWldDaEtxdGxlWTVpKzdDc3JaUmo1VUNkQ2NHTDVLYm1x?= =?utf-8?B?ZWg4WFI5dDNVZmx1TTgvTVNSS1NZQzAyME9DOEl0NURGbFpYRkJkQ0lxTjZ0?= =?utf-8?B?VUJHc09Eb0k0dWdaVFdZN3k4Nk5XYzAyRTV2am5QUGpKZjVGbFhmam9NWWVi?= =?utf-8?B?VTh0amZDNytzUUVrNUFMamhwbHBMdUF5akdmK2F6elBTSGZVYlRYSWdiamZu?= =?utf-8?B?NGRpSWQ4VjhLaU5MWTQ0ZVk1N2Z3eDBvU3BZQUF3Y3Z6ZFZ4WjVYUGNlLytr?= =?utf-8?B?dWcwSVc3ZnJzRWdGOUx3ZlhNOWRoS2lmTGY1dU9JK3RDR0RvNWNQTzQ5Qzlo?= =?utf-8?B?bkNxYk9JY3l2QnE1VzlnOGhCT1p1U2xyaTBINzBlQkxSRlU5SjhoM2hLbVJO?= =?utf-8?B?a0cwVWxRS01jeVhQYlcwMGFaUWhTcThXOEFQRGlJSXZtenN4MHhLL2RWNFBk?= =?utf-8?B?RXZnN0txYXhtcGc5Vm5OYWRGVTM0WW1RS1JOTFRIRFVqWnVsaDNBbTkrWmVv?= =?utf-8?B?dVBkL0RJL1BObkpWa3kvZHNnOGswQzdxT3lKYnhQODNqUWlZRlA5Q2ZJelJj?= =?utf-8?B?TnRvZkUrTHRNMzBXeUJUdk1DaVQzcGpyd0xNeGNRakJkK0tsQTZZc1drWE9s?= =?utf-8?B?YXpxazE4RkoyRlpnV2xhSFY2WWNLTVRyK2hObVFod0E0NmtFc3djdVEyQlNF?= =?utf-8?B?TWtjTjF0ZGtMYW9qSTFyVThNMUVCbm0xR1Z2QlJDeWhNUGpoVEZVU01YcjM2?= =?utf-8?B?WXBnWVN5RWoyK3YxdmNHc29YNnpOcUNNdGRDcGFVM2JhNVBlVjNVZlNFUTZa?= =?utf-8?B?K0xKZ0FTejVYak1SZVFrVldoOGNXKzhSai9QcDVmem02RkFtT3JJa3RSSXZs?= =?utf-8?B?Y0ZCVU9uWjAwWHBhZEh5dzQzNm84VmZrRnBEbUJVSW1PU3BvaXFFbUlGei93?= =?utf-8?B?dVdVNmhzT093V2MzSTJHQXV4Z241MVpKbmJiRURVRm5peTUrTWUxVExYb3hy?= =?utf-8?B?K2licFdoNjBwUG05Wm52eHB1VEhVRmpsTE9JQkZUQWVCQm5SMFVsUkcvalps?= =?utf-8?B?Z210UUMwMUtTa3BmelQzV0QvbU9VZ0t2dzJIblExTE9hOXcyVlRKYVVYblAy?= =?utf-8?B?SGpCN3ZUWXlXUk92MTZxREFCWWhwL01GZVFPMkp2VFUvbG8wNnJpSkMyV2U0?= =?utf-8?B?R1Y5dERRN3FNSDU1azVNdlU0c0NmWFBNdW1XTVorYm9RcExnMjA3RmJRNkh1?= =?utf-8?B?M3Z3YTlKMXh6QXFMN3ZKcFNpKzdiOUNXeHlUckkrZDBUMGdRbVZWdmdEdVoy?= =?utf-8?B?T1Z2dW44WEJCU29hTDVmcXgrWko2U2RKR25KaVBNZm1pYWdyWTJ2MFhOQnRu?= =?utf-8?B?bCtWNTdtZmQvaWR0a05uYzBuQzVGUzZaRm9jNEV2WSs3M0RTT2VJajdCT0gz?= =?utf-8?B?UUJjN1A1Yko1KzJHbEFzci8xKzFubmxCVE5vRUVwSlIrQ21nNEZZT0YxMmt0?= =?utf-8?B?ZUFZblEwTWtESmpZT0Q1cXFRSi9XdXRlTVJkWnNVRWQwSmVCeTFJRWJDYkxo?= =?utf-8?B?SHFYZ1N3bEI3LzBMMU1DZDRscTNCT2VkQ1dJbElONVlENnVsUkRtdmNEa2sv?= =?utf-8?Q?V9ZemtJXF/rfvsTkyk?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4757b6db-fc29-4a7a-3708-08def48e244c X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5320.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2026 14:14:06.7061 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0unInzR2c8KCVU3awB2sRje88ODBaVwnxcXqZWORkrB7vb6tscZZSSt+yghV4dm0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8595 Hi Reinette, Thanks for the patches. I am yet to look at all the patches. On 8/6/2026 12:11 PM, Reinette Chatre wrote: > Hi Tony, > > On 8/6/26 10:04 AM, Luck, Tony wrote: >> On Wed, Aug 05, 2026 at 04:57:04PM -0700, Reinette Chatre wrote: >>> Hi Ben, >>> >>> On 8/5/26 9:59 AM, Ben Horgan wrote: >>>> Just given a go at running this on a model with MPAM and I can mount resctrl with this >>>> small patch to initialise the emulated_by lists so that list_empty() behaves. >>>> >>>> diff --git a/drivers/resctrl/mpam_resctrl.c b/drivers/resctrl/mpam_resctrl.c >>>> index 21dcbf5764cc..638095649151 100644 >>>> --- a/drivers/resctrl/mpam_resctrl.c >>>> +++ b/drivers/resctrl/mpam_resctrl.c >>>> @@ -1018,6 +1018,7 @@ static int mpam_resctrl_control_init(struct mpam_resctrl_res *res) >>>> case RDT_RESOURCE_L3: >>>> mpam_ctrl->r_ctrl.type = RESCTRL_CTRL_BITMAP; >>>> mpam_ctrl->r_ctrl.name = RESCTRL_CTRL_NAME_DEF; >>>> + INIT_LIST_HEAD(&mpam_ctrl->r_ctrl.emulated_by); >>>> INIT_LIST_HEAD_RCU(&mpam_ctrl->r_ctrl.domains); >>>> __set_bit(RESCTRL_BITMAP_FLAG_SPARSE, mpam_ctrl->r_ctrl.bitmap.flags); >>>> mpam_ctrl->r_ctrl.bitmap.cbm_len = class->props.cpbm_wd; >>>> @@ -1048,6 +1049,7 @@ static int mpam_resctrl_control_init(struct mpam_resctrl_res *res) >>>> r->ctrl_scope = RESCTRL_L3_CACHE; >>>> mpam_ctrl->r_ctrl.type = RESCTRL_CTRL_SCALAR; >>>> mpam_ctrl->r_ctrl.name = RESCTRL_CTRL_NAME_DEF; >>>> + INIT_LIST_HEAD(&mpam_ctrl->r_ctrl.emulated_by); >>>> INIT_LIST_HEAD_RCU(&mpam_ctrl->r_ctrl.domains); >>>> >>>> r->bw_throttle_mode = THREAD_THROTTLE_UNDEFINED; >>> >>> Thank you for this. Added this and it is now available in branch resctrl/controls_rfc_v2.1 >> >> Is same needed for x86? I don't see any initialization of the >> "r_ctrl.emulated_by" lists in similar initialization functions. > x86 "emulated_by" list initialization should be in both branches. > > Branch resctrl/controls_rfc_v2.1 combined all "emulated_by" list initialization > (for x86 and MPAM) into commit: > 3407e523c988 ("fs/resctrl: Introduce emulated controls and control mode") > > In the original resctrl/controls_rfc_v2 the x86 "emulated_by" list initialization can > be found in commit fbed64f80515 ("x86/resctrl: SAMPLE: Emulated controls") > Looking at the commit: commit 3407e523c988 ("fs/resctrl: Introduce emulated controls and control mode") Based on the patch description, emulated controls are intended to be used only when there is a difference between the native and legacy controls. If no such difference exists, both modes should operate identically. For MBA(AMD) and GMBA, there does not appear to be any difference between the two modes. Is that understanding correct? Thanks Babu