From: David Ahern <dsahern@gmail.com>
To: Ido Schimmel <idosch@nvidia.com>, Ferenc Fejes <ferenc@fejes.dev>
Cc: netdev <netdev@vger.kernel.org>, kuniyu@amazon.com
Subject: Re: [question] robust netns association with fib4 lookup
Date: Fri, 25 Apr 2025 11:21:34 -0700 [thread overview]
Message-ID: <c1266298-8833-4bef-9ac5-6c61ba4dd0c6@gmail.com> (raw)
In-Reply-To: <aAvRxOGcyaEx0_V2@shredder>
On 4/25/25 11:17 AM, Ido Schimmel wrote:
>> Is there any other way to get the netns info for fib4 lookups? If not, would it
>> be worth an RFC to pass the struct net argument to fib_table_lookup as well, as
>> is currently done in fib6_table_lookup?
>
> I think it makes sense to make both tracepoints similar and pass the net
> argument to trace_fib_table_lookup()
>
>> Unfortunately this includes some callers to fib_table_lookup. The
>> netns id would also be presented in the existing tracepoints ([1] and
>> [2]). Thanks in advance for any suggestion.
>
> By "netns id" you mean the netns cookie? It seems that some TCP trace
> events already expose it (see include/trace/events/tcp.h). It would be
> nice to finally have "perf" filter these FIB events based on netns.
>
> David, any objections?
none from me. I was looking at the code last night and going to suggest
either plumbing net all the way down or add net to the fib table struct.
next prev parent reply other threads:[~2025-04-25 18:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 11:33 [question] robust netns association with fib4 lookup Ferenc Fejes
2025-04-25 18:17 ` Ido Schimmel
2025-04-25 18:21 ` David Ahern [this message]
2025-04-28 10:23 ` Ferenc Fejes
2025-04-28 10:20 ` Ferenc Fejes
2025-04-28 15:35 ` Ido Schimmel
2025-04-29 5:50 ` Ferenc Fejes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1266298-8833-4bef-9ac5-6c61ba4dd0c6@gmail.com \
--to=dsahern@gmail.com \
--cc=ferenc@fejes.dev \
--cc=idosch@nvidia.com \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.