From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Subject: Re: [PATCH] app/testpmd: show output of commands read from file
Date: Fri, 4 Oct 2024 05:55:26 +0100 [thread overview]
Message-ID: <c14cecf2-fb49-4946-88b4-e83294a1ca7f@amd.com> (raw)
In-Reply-To: <20240822103604.113246-1-bruce.richardson@intel.com>
On 8/22/2024 11:36 AM, Bruce Richardson wrote:
> Testpmd supports the "--cmdline-file" parameter to read a set of initial
> commands from a file. However, the only indication that this has been
> done successfully on startup is a single-line message, no output from
> the commands is seen.
>
> To improve usability here, we can use cmdline_new rather than
> cmdline_file_new and have the output from the various commands sent to
> stdout, allowing the user to see better what is happening.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
After discussion, I think it is OK to have the update in the testpmd
(instead of a new function in cmdline), hence;
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
next prev parent reply other threads:[~2024-10-04 4:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 10:36 [PATCH] app/testpmd: show output of commands read from file Bruce Richardson
2024-08-22 10:41 ` [PATCH v2] " Bruce Richardson
2024-08-22 16:53 ` Ferruh Yigit
2024-08-22 17:14 ` Bruce Richardson
2024-08-22 17:18 ` Bruce Richardson
2024-08-22 21:09 ` Ferruh Yigit
2024-08-23 9:12 ` Bruce Richardson
2024-10-04 4:56 ` Ferruh Yigit
2024-10-08 1:33 ` Ferruh Yigit
2024-10-10 8:56 ` David Marchand
2024-10-10 9:46 ` Bruce Richardson
2024-10-04 4:55 ` Ferruh Yigit [this message]
2024-10-04 4:56 ` [PATCH] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c14cecf2-fb49-4946-88b4-e83294a1ca7f@amd.com \
--to=ferruh.yigit@amd.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.