From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Antonio Di Lorenzo <antoniodilorenzonap@gmail.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
<linux-sound@vger.kernel.org>, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] ASoC: Intel: soc-acpi: add SoundWire config for ASUS P5405CAA
Date: Fri, 11 Sep 2026 11:29:16 +0200 [thread overview]
Message-ID: <c153ede2-b54c-4e2d-b51b-1dd8e0268dda@intel.com> (raw)
In-Reply-To: <20260911091035.221224-1-antoniodilorenzonap@gmail.com>
On 9/11/2026 11:10 AM, Antonio Di Lorenzo wrote:
> RT721 AIF1 is used for the headset jack and AIF3 for the DMIC,
> while AIF2 is unused when external speaker amplifiers are present.
This patch only updates the ptl-match table, there are no
machine-board-driver changes here so the paragraph seems out of place
and can be dropped.
> Use function topology selection for this configuration.
The statement has little value if any. Explain _why_ no valid
sof_tplg_filename is assigned and the entry relies solely on
get_function_tplg_files.
...
> @@ -487,6 +544,14 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_ptl_sdw_machines[] = {
> .sof_tplg_filename = "sof-ptl-rt713-l3-rt1320-l1.tplg",
> .get_function_tplg_files = sof_sdw_get_tplg_files,
> },
> + {
> + .link_mask = BIT(1) | BIT(3),
> + .links = ptl_tas2783_l1_rt721_l3,
> + .drv_name = "sof_sdw",
> + /* Function topologies only; no monolithic fallback. */
> + .sof_tplg_filename = "sof-ptl-dummy.tplg",
I do not see any "dummy" occurrence within this folder and thus I wonder
how will the code react to such combination. Peter, what's your take on
this?
> + .get_function_tplg_files = sof_sdw_get_tplg_files,
> + },
> {
> .link_mask = BIT(0) | BIT(2) | BIT(3),
> .links = ptl_rt722_l0_rt1320_l23,
next prev parent reply other threads:[~2026-09-11 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 9:10 [PATCH] ASoC: Intel: soc-acpi: add SoundWire config for ASUS P5405CAA Antonio Di Lorenzo
2026-09-11 9:29 ` Cezary Rojewski [this message]
2026-09-11 11:31 ` Liao, Bard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c153ede2-b54c-4e2d-b51b-1dd8e0268dda@intel.com \
--to=cezary.rojewski@intel.com \
--cc=antoniodilorenzonap@gmail.com \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-sound@vger.kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.