From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: handle exclusive fence similar to shared ones
Date: Wed, 9 Jun 2021 16:07:24 +0200 [thread overview]
Message-ID: <c164ea49-2ce2-8b40-1cdf-cd4cf93612e7@gmail.com> (raw)
In-Reply-To: <YMDFNyqzCfgsJnn2@phenom.ffwll.local>
Am 09.06.21 um 15:42 schrieb Daniel Vetter:
> [SNIP]
>> That won't work. The problem is that you have only one exclusive slot, but
>> multiple submissions which execute out of order and compose the buffer
>> object together.
>>
>> That's why I suggested to use the dma_fence_chain to circumvent this.
>>
>> But if you are ok that amdgpu sets the exclusive fence without changing the
>> shared ones than the solution I've outlined should already work as well.
> Uh that's indeed nasty. Can you give me the details of the exact use-case
> so I can read the userspace code and come up with an idea? I was assuming
> that even with parallel processing there's at least one step at the end
> that unifies it for the next process.
Unfortunately not, with Vulkan that is really in the hand of the
application.
But the example we have in the test cases is using 3D+DMA to compose a
buffer IIRC.
> If we can't detect this somehow then it means we do indeed have to create
> a fence_chain for the exclusive slot for everything, which would be nasty.
I've already created a prototype of that and it is not that bad. It does
have some noticeable overhead, but I think that's ok.
> Or a large-scale redo across all drivers, which is probaly even more
> nasty.
Yeah, that is indeed harder to get right.
Christian.
> -Daniel
>
>
next prev parent reply other threads:[~2021-06-09 14:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-06 10:03 handle exclusive fence similar to shared ones Christian König
2021-06-06 10:03 ` [PATCH 1/3] dma-buf: fix dma_resv_test_signaled test_all handling Christian König
2021-06-06 10:03 ` [PATCH 2/3] drm/nouveau: always wait for the exclusive fence Christian König
2021-06-06 10:03 ` [PATCH 3/3] drm/amdgpu: drop workaround for adding page table clears as shared fence Christian König
2021-06-07 8:58 ` handle exclusive fence similar to shared ones Daniel Vetter
2021-06-07 9:59 ` Christian König
2021-06-07 15:09 ` Daniel Vetter
2021-06-07 16:25 ` Christian König
2021-06-09 13:42 ` Daniel Vetter
2021-06-09 14:07 ` Christian König [this message]
2021-06-10 16:41 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c164ea49-2ce2-8b40-1cdf-cd4cf93612e7@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.