All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Timur Kristóf" <timur.kristof@gmail.com>
To: Jesse Zhang <Jesse.Zhang@amd.com>, amd-gfx@lists.freedesktop.org
Cc: Alexander.Deucher@amd.com,
	Christian Koenig <christian.koenig@amd.com>,
	 Lijo.Lazar@amd.com, Mario.Novales@amd.com, Manu.Rastogi@amd.com,
	 Jiongyu.Zhu@amd.com
Subject: Re: [PATCH v4 13/13] drm/amdgpu/gfx11: enable the gfx engine soft reset
Date: Thu, 19 Nov 2026 12:47:37 +0100	[thread overview]
Message-ID: <c166332638f3f5cc04b7cbde72cdc31a13e1ff67.camel@gmail.com> (raw)
In-Reply-To: <20261105030612.726542-13-Jesse.Zhang@amd.com>

On Thu, 2026-11-05 at 11:05 +0800, Jesse Zhang wrote:
> Report AMDGPU_RESET_TYPE_IP_BLOCK_SOFT_RESET for the gfx rings with
> MES,
> which the reset uses to map the kernel gfx queue again. Not on SR-IOV
> VFs.
> 
> The kernel gfx queue and gfx user queue resets then fall back to a
> soft
> reset of the gfx engine before a full reset. The IP block soft reset
> of
> gfx11 only resets the gfx engine then; the whole IP block
> soft_reset()
> isn't used.
> 
> v4: Not limited to the RS64 firmware anymore, the reset restarts the
> F32
>     PFP and ME of the APUs too (Timur). The soft_reset_engine()
> callback
>     is set by the patch that adds it. No async gfx ring check: they
> are
>     always used now.
> 
> Signed-off-by: Jesse Zhang <Jesse.Zhang@amd.com>

Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> index 80b91459f5b0..396fe3f6678a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> @@ -1941,6 +1941,11 @@ static int gfx_v11_0_sw_init(struct
> amdgpu_ip_block *ip_block)
>  		break;
>  	}
>  
> +	/* The reset remaps the kernel gfx queue through MES. */
> +	if (!amdgpu_sriov_vf(adev) && adev->enable_mes &&
> +	    !adev->debug_disable_ip_block_soft_reset)
> +		adev->gfx.gfx_supported_reset |=
> AMDGPU_RESET_TYPE_IP_BLOCK_SOFT_RESET;
> +
>  	if (!adev->enable_mes_kiq) {
>  		r = amdgpu_gfx_kiq_init(adev, GFX11_MEC_HPD_SIZE,
> 0);
>  		if (r) {

  reply	other threads:[~2026-11-19 11:47 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05  3:05 [PATCH v4 01/13] drm/amdgpu: pass the device to the multi ring reset helpers Jesse Zhang
2026-11-05  3:05 ` [PATCH v4 02/13] drm/amdgpu/ring: During multi-queue reset, only call begin helper if needed Jesse Zhang
2026-11-11 23:52   ` Daniel Campos Ramos
2026-11-19 11:34   ` Timur Kristóf
2026-11-05  3:05 ` [PATCH v4 03/13] drm/amdgpu: add an engine scope to the IP block soft reset Jesse Zhang
2026-11-19 11:35   ` Timur Kristóf
2026-11-05  3:05 ` [PATCH v4 04/13] drm/amdgpu/gfx: add callbacks to save and restore a gfx HQD Jesse Zhang
2026-11-19 11:35   ` Timur Kristóf
2026-11-05  3:05 ` [PATCH v4 05/13] drm/amdgpu/gfx12: " Jesse Zhang
2026-11-19 11:35   ` Timur Kristóf
2026-11-05  3:05 ` [PATCH v4 06/13] drm/amdgpu/gfx11: " Jesse Zhang
2026-11-19 11:36   ` Timur Kristóf
2026-11-05  3:05 ` [PATCH v4 07/13] drm/amdgpu/userq: add a helper to signal the fences of a queue up to a point Jesse Zhang
2026-11-19 11:36   ` Timur Kristóf
2026-11-05  3:05 ` [PATCH v4 08/13] drm/amdgpu/userq: add helpers to keep the user queues of one engine across a reset Jesse Zhang
2026-11-19 11:36   ` Timur Kristóf
2026-11-05  3:05 ` [PATCH v4 09/13] drm/amdgpu/gfx12: add a gfx engine soft reset Jesse Zhang
2026-11-19 11:42   ` Timur Kristóf
2026-11-05  3:05 ` [PATCH v4 10/13] drm/amdgpu/gfx11: " Jesse Zhang
2026-11-19 11:47   ` Timur Kristóf
2026-11-05  3:05 ` [PATCH v4 11/13] drm/amdgpu/userq: reset the gfx engine when a gfx user queue reset fails Jesse Zhang
2026-11-19 11:47   ` Timur Kristóf
2026-11-05  3:05 ` [PATCH v4 12/13] drm/amdgpu/gfx12: enable the gfx engine soft reset Jesse Zhang
2026-11-19 11:47   ` Timur Kristóf
2026-11-05  3:05 ` [PATCH v4 13/13] drm/amdgpu/gfx11: " Jesse Zhang
2026-11-19 11:47   ` Timur Kristóf [this message]
2026-11-10  2:06 ` [PATCH v4 01/13] drm/amdgpu: pass the device to the multi ring reset helpers Zhang, Jesse(Jie)
2026-11-11 15:28   ` Timur Kristóf
2026-11-19 11:33 ` Timur Kristóf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c166332638f3f5cc04b7cbde72cdc31a13e1ff67.camel@gmail.com \
    --to=timur.kristof@gmail.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Jesse.Zhang@amd.com \
    --cc=Jiongyu.Zhu@amd.com \
    --cc=Lijo.Lazar@amd.com \
    --cc=Manu.Rastogi@amd.com \
    --cc=Mario.Novales@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.