From: Andrew Dyer <amdyer@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] fs/ext2/ext2fs.c bug and patch
Date: Sat, 8 Jan 2005 14:32:39 -0600 [thread overview]
Message-ID: <c166aa9f050108123275ef21a4@mail.gmail.com> (raw)
Hi all,
In the course of getting ext2 support to work on our platform
I noticed that
the ext2load command calls ext2fs_open() and uses a return code of less than
0 as an error indication, otherwise the return value is a length.
ext2fs_open() uses 0 to indicate a returned error, so the ext2load command
doesn't properly flag errors coming back from the filesystem code. The ext2load
command is the only caller of ext2fs_open() that I could see.
The attached patch changes the return codes from ext2fs_open() to be negative
on an error.
--
Hardware, n.:
The parts of a computer system that can be kicked.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: uboot-ext2fs_open-return.txt
Url: http://lists.denx.de/pipermail/u-boot/attachments/20050108/0700e5ca/attachment.txt
next reply other threads:[~2005-01-08 20:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-08 20:32 Andrew Dyer [this message]
2005-02-04 9:43 ` [U-Boot-Users] fs/ext2/ext2fs.c bug and patch Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c166aa9f050108123275ef21a4@mail.gmail.com \
--to=amdyer@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.