All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Dyer <amdyer@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [patch] tools/bmp_logo.c using incorrect offset to pixel data
Date: Mon, 31 Jan 2005 18:58:28 -0600	[thread overview]
Message-ID: <c166aa9f05013116587509e637@mail.gmail.com> (raw)

The attached patch makes bmp_logo.c use the header information about
the start of pixel data  in the bmp file instead of trying to find the
start itself.  If someone wants a test case bmp file that will 
produce incorrect output with the current code e-mail me and I can
send it along.  The bug was seen with the tool compiled/running under
redhat 7.3 on x86 arch.  The visual indication was that the bitmap was
shifted to the right with a section of garbage displayed in the lower
left corner.  The source bmp displays fine with Win2000.

I would suggest it's worth noting in the somewhere in docs that
include/bmp_logo.h is overwritten by the default build environment
(with the Denx logo :-( ).  I added a line like this to my board
config.mk file to override this behavior.

#logo bitmap
LOGO_BMP = ../board/eldorado/rht_small_logo.bmp


-- 
Hardware, n.:
        The parts of a computer system that can be kicked.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: uboot-bmp_logo-patch.txt
Url: http://lists.denx.de/pipermail/u-boot/attachments/20050131/73d71123/attachment.txt 

             reply	other threads:[~2005-02-01  0:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-01  0:58 Andrew Dyer [this message]
2005-09-25 13:40 ` [U-Boot-Users] [patch] tools/bmp_logo.c using incorrect offset to pixel data Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c166aa9f05013116587509e637@mail.gmail.com \
    --to=amdyer@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.