All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Fernandes <joelagnelf@nvidia.com>
To: Qi Xi <xiqi2@huawei.com>,
	paulmck@kernel.org, Xiongfeng Wang <wangxiongfeng2@huawei.com>
Cc: Joel Fernandes <joel@joelfernandes.org>,
	ankur.a.arora@oracle.com,
	Frederic Weisbecker <frederic@kernel.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	neeraj.upadhyay@kernel.org, urezki@gmail.com,
	rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Wangshaobo (bobo)" <bobo.shaobowang@huawei.com>,
	Xie XiuQi <xiexiuqi@huawei.com>
Subject: Re: [QUESTION] problems report: rcu_read_unlock_special() called in irq_exit() causes dead loop
Date: Wed, 2 Jul 2025 13:24:00 -0400	[thread overview]
Message-ID: <c16ddb6e-73f1-4eff-bbcf-c03b95f79fdf@nvidia.com> (raw)
In-Reply-To: <166bc5aa-a715-438e-8805-c74c2b5fc83b@nvidia.com>



On 7/2/2025 6:59 AM, Joel Fernandes wrote:
> 
> 
> On 7/2/2025 5:14 AM, Qi Xi wrote:
>> Hi Joel,
>>
>> After applying the 2 patches, the problem still exists. Compared to the previous
>> fixes which did solve the problem, the difference is ct_in_irq() in the first
>> patch.
>>
>> I am wondering why "nesting != CT_NESTING_IRQ_NONIDLE" is added?
>>
>>
>> (previous fix: problem is solved)
>>
>> +bool ct_in_irq(void)
>> +{
>> +    return ct_nmi_nesting() != 0;
>> +}
>>
>> (current fix: problem still exists)
>>
>> +bool ct_in_irq(void)
>> +{
>> +    long nesting = ct_nmi_nesting();
>> +
>> +    return (nesting && nesting != CT_NESTING_IRQ_NONIDLE);
>> +}
> 
> Oh gosh, thanks for spotting that! Indeed,  I had changed it to != 0 in the last
> version but applied an older patch. I will fix it in the tree. Thank you again!
> 
> Neeraj, would you like this as a separate commit that you can then squash? Or
> could you fix it up in your tree?
> 
Qi, Xiongfeng, I am currently working on alternative fix after discussing with
the crew. I will keep you posted with the fix, and would it to be good to get
your testing on it once I have it (hopefully in couple of days), thanks for the
report!

 - Joel


  parent reply	other threads:[~2025-07-02 17:24 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-21  9:43 [QUESTION] problems report: rcu_read_unlock_special() called in irq_exit() causes dead loop Xiongfeng Wang
2025-05-28 16:30 ` Joel Fernandes
2025-05-30  1:55   ` Xiongfeng Wang
2025-06-03 18:59     ` Joel Fernandes
2025-06-03 19:03       ` Joel Fernandes
2025-06-03 19:22         ` Joel Fernandes
2025-06-04  1:35           ` Joel Fernandes
2025-06-04  3:25             ` Xiongfeng Wang
     [not found]               ` <64dfcaad-091c-4319-882b-d94515365758@huawei.com>
2025-06-04  9:20                 ` Joel Fernandes
2025-06-04  3:20           ` Xiongfeng Wang
2025-06-04 12:26             ` Paul E. McKenney
2025-06-05 18:56               ` Joel Fernandes
2025-07-01  9:20                 ` Qi Xi
2025-07-01 13:29                   ` Joel Fernandes
2025-07-02  9:04                     ` Qi Xi
2025-07-02  9:14                     ` Qi Xi
2025-07-02 10:59                       ` Joel Fernandes
2025-07-02 11:11                         ` Frederic Weisbecker
2025-07-02 17:24                         ` Joel Fernandes [this message]
2025-07-03  1:04                           ` Xiongfeng Wang
2025-07-05 13:12                             ` Joel Fernandes
2025-07-07  3:06                               ` Qi Xi
2025-07-07  3:08                                 ` Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c16ddb6e-73f1-4eff-bbcf-c03b95f79fdf@nvidia.com \
    --to=joelagnelf@nvidia.com \
    --cc=ankur.a.arora@oracle.com \
    --cc=bobo.shaobowang@huawei.com \
    --cc=boqun.feng@gmail.com \
    --cc=frederic@kernel.org \
    --cc=joel@joelfernandes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neeraj.upadhyay@kernel.org \
    --cc=paulmck@kernel.org \
    --cc=rcu@vger.kernel.org \
    --cc=urezki@gmail.com \
    --cc=wangxiongfeng2@huawei.com \
    --cc=xiexiuqi@huawei.com \
    --cc=xiqi2@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.