From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>, Christoph Hellwig <hch@lst.de>
Cc: linux-block@vger.kernel.org,
syzbot+77ba3d171a25c56756ea@syzkaller.appspotmail.com,
John Garry <john.garry@huawei.com>
Subject: Re: [PATCH] blk-mq: fix use-after-free in blk_mq_exit_sched
Date: Fri, 18 Jun 2021 08:50:37 -0600 [thread overview]
Message-ID: <c1b819bb-0117-577b-2edc-2abffbb9a659@kernel.dk> (raw)
In-Reply-To: <20210609063046.122843-1-ming.lei@redhat.com>
On 6/9/21 12:30 AM, Ming Lei wrote:
> tagset can't be used after blk_cleanup_queue() is returned because
> freeing tagset usually follows blk_clenup_queue(). Commit d97e594c5166
> ("blk-mq: Use request queue-wide tags for tagset-wide sbitmap") adds
> check on q->tag_set->flags in blk_mq_exit_sched(), and causes
> use-after-free.
>
> Fixes it by using hctx->flags.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2021-06-18 14:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 6:30 [PATCH] blk-mq: fix use-after-free in blk_mq_exit_sched Ming Lei
2021-06-09 8:59 ` John Garry
2021-06-09 10:16 ` Ming Lei
2021-06-09 11:42 ` John Garry
2021-06-14 22:07 ` Ming Lei
2021-06-15 10:02 ` John Garry
2021-06-18 6:03 ` Ming Lei
2021-06-18 14:50 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1b819bb-0117-577b-2edc-2abffbb9a659@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=syzbot+77ba3d171a25c56756ea@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.