All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hemant Kumar <hemantk@codeaurora.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Loic Poulain <loic.poulain@linaro.org>
Cc: linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] mhi: unconstify mhi_event_config
Date: Tue, 5 Jan 2021 18:25:42 -0800	[thread overview]
Message-ID: <c1c7efb6-ea3e-6882-0e20-5628bc34eab2@codeaurora.org> (raw)
In-Reply-To: <20210105152620.GA14794@thinkpad>

Hi Loic,

On 1/5/21 7:26 AM, Manivannan Sadhasivam wrote:
> On Tue, Jan 05, 2021 at 09:56:14AM +0100, Loic Poulain wrote:
>> Some parameters may have to be determined at runtime.
>> It is the case for the event ring MSI vector.
>>
>> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> 
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> 
> Thanks,
> Mani
> 
>> ---
>>   include/linux/mhi.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
>> index 62da830..48b1b2a 100644
>> --- a/include/linux/mhi.h
>> +++ b/include/linux/mhi.h
>> @@ -290,7 +290,7 @@ struct mhi_controller_config {
>>   	u32 num_channels;
>>   	const struct mhi_channel_config *ch_cfg;
>>   	u32 num_events;
>> -	const struct mhi_event_config *event_cfg;
>> +	struct mhi_event_config *event_cfg;
Do we need to update mhi controller driver like ath11k and generic pci 
driver to avoid compiler warnings?
>>   	bool use_bounce_buf;
>>   	bool m2_no_db;
>>   };
>> -- 
>> 2.7.4
>>

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

      reply	other threads:[~2021-01-06  2:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05  8:56 [PATCH 1/2] mhi: unconstify mhi_event_config Loic Poulain
2021-01-05  8:56 ` [PATCH 2/2] mhi: pci_generic: Fix shared MSI vector support Loic Poulain
2021-01-05 15:29   ` Manivannan Sadhasivam
2021-01-05 15:26 ` [PATCH 1/2] mhi: unconstify mhi_event_config Manivannan Sadhasivam
2021-01-06  2:25   ` Hemant Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1c7efb6-ea3e-6882-0e20-5628bc34eab2@codeaurora.org \
    --to=hemantk@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=manivannan.sadhasivam@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.