From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Subject: Re: [PATCH 3/3] KVM: nVMX: Emulate EPTP switching for the L1 hypervisor Date: Thu, 3 Aug 2017 14:47:02 +0200 Message-ID: References: <20170801232433.31749-1-bsd@redhat.com> <20170801232433.31749-4-bsd@redhat.com> <56d21524-1a08-8281-fb01-950fb7c10b2f@redhat.com> <179e5832-0dca-0b5f-b303-d5de18353f5e@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: rkrcmar@redhat.com, jmattson@google.com, linux-kernel@vger.kernel.org To: Paolo Bonzini , Bandan Das , kvm@vger.kernel.org Return-path: In-Reply-To: <179e5832-0dca-0b5f-b303-d5de18353f5e@redhat.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org >> Minor nit: Can't you directly do >> >> kunmap(page); >> nested_release_page_clean(page); >> >> at this point? >> >> We can fix this up later. > > You actually can do simply kvm_vcpu_read_guest_page(vcpu, > vmcs12->eptp_list_address >> PAGE_SHIFT, &address, index * 8, 8). > Fascinating how nested is able to confuse me every time :) . Sure, this is just a G1 address, not a G2 address ... (maybe we should rename nested_get_page to guest_get_page ...) > Paolo > -- Thanks, David