All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Anderson <seanga2@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH] timer: Return count from timer_ops.get_count
Date: Tue, 8 Sep 2020 19:59:53 -0400	[thread overview]
Message-ID: <c1ee1844-e082-400a-dad6-115d12cf20eb@gmail.com> (raw)
In-Reply-To: <CAPnjgZ3ACNMBFt8YWYbMQ76MhESaGD8Oa9LaW9VmiGt5syo9Pw@mail.gmail.com>

On 9/8/20 7:56 PM, Simon Glass wrote:
> Hi Sean,
> 
> 
> On Mon, 7 Sep 2020 at 12:19, Sean Anderson <seanga2@gmail.com> wrote:
>>
>> No timer drivers return an error from get_count. Instead of possibly
>> returning an error, just return the count directly.
>>
>> Signed-off-by: Sean Anderson <seanga2@gmail.com>
>> ---
>> Passing CI (but not otherwise tested):
>> https://dev.azure.com/seanga2/u-boot/_build/results?buildId=25&view=results
>>
>> This patch depends on
>> https://patchwork.ozlabs.org/project/uboot/list/?series=198797
>>
>>  arch/riscv/lib/andes_plmt.c       |  6 ++----
>>  arch/riscv/lib/sifive_clint.c     |  6 ++----
>>  drivers/timer/ag101p_timer.c      |  5 ++---
>>  drivers/timer/altera_timer.c      |  6 ++----
>>  drivers/timer/arc_timer.c         |  6 ++----
>>  drivers/timer/ast_timer.c         |  6 ++----
>>  drivers/timer/atcpit100_timer.c   |  5 ++---
>>  drivers/timer/atmel_pit_timer.c   |  6 ++----
>>  drivers/timer/cadence-ttc.c       |  6 ++----
>>  drivers/timer/dw-apb-timer.c      |  6 ++----
>>  drivers/timer/mpc83xx_timer.c     |  6 ++----
>>  drivers/timer/mtk_timer.c         |  6 ++----
>>  drivers/timer/nomadik-mtu-timer.c |  6 ++----
>>  drivers/timer/omap-timer.c        |  6 ++----
>>  drivers/timer/ostm_timer.c        |  6 ++----
>>  drivers/timer/riscv_timer.c       | 21 +++++++++------------
>>  drivers/timer/rockchip_timer.c    |  5 ++---
>>  drivers/timer/sandbox_timer.c     |  6 ++----
>>  drivers/timer/sti-timer.c         |  6 ++----
>>  drivers/timer/stm32_timer.c       |  6 ++----
>>  drivers/timer/timer-uclass.c      |  3 ++-
>>  drivers/timer/tsc_timer.c         |  6 ++----
>>  include/timer.h                   |  5 ++---
>>  23 files changed, 53 insertions(+), 93 deletions(-)
>>
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> This seems OK to me. The function should not be called until the
> driver is probed. It might be worth mentioning that probing must make
> the timer valid (always from then on)?
> 

Sure. I will update the docs in the next revision.

--Sean

      reply	other threads:[~2020-09-08 23:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07 18:19 [PATCH] timer: Return count from timer_ops.get_count Sean Anderson
2020-09-08 23:56 ` Simon Glass
2020-09-08 23:59   ` Sean Anderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1ee1844-e082-400a-dad6-115d12cf20eb@gmail.com \
    --to=seanga2@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.