From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFF4D2C6B4; Thu, 4 Jan 2024 21:38:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GuOeNjzs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A171BC433C8; Thu, 4 Jan 2024 21:38:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704404309; bh=C6yj4tbn318pdlPF1SHSET3ntYVv+Yq1nuht+eVikeI=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=GuOeNjzs7+jgEt/pSJNL8/o+eEmnqEjgSzbeDRPDlU7FLeASwA+SiFBaysdcbiZJ2 oIs1QY1xa6xwzCiZvoDpPPNrQAZiIF78RafagJ0OaM2wSk1l0EMMm18E+dwxtlN5PF KN5rububvg9JxwK/ZI+MjS2km+QxoA4aVLObgF4oMHTVC0k2PEtFZIZ3wnAddIrhbP u2tkAZgpXu/JhSdZOPxGO7p8BCGozWbnvTM3WmiFzJFoqj/iZjVQfvtE4hyW0EghRn rnZ9UBXxysu8fyq1HAgTvzqJOaJYByyUQuJNvBymlSKv/+3UA72iDXhXHT93R1Kucu 4YR4FwLcQHNVQ== Message-ID: Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <744a6371f94fe96f527eea6e52a600914e6fb6b5.1702403904.git.u.kleine-koenig@pengutronix.de> <5391068cdc86b6117920d31a524d934b.sboyd@kernel.org> <3fhgutm42b6sy6gdydcvflnsjuc2ozjetjbeyoxjvnl2t5q7za@4og2x6gqz5y2> Subject: Re: [PATCH 1/2] clk: Add a devm variant of clk_rate_exclusive_get() From: Stephen Boyd Cc: linux-pwm@vger.kernel.org, Sean Anderson , Michael Turquette , Russell King , Maxime Ripard , Thierry Reding , kernel@pengutronix.de, Michal Simek , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org To: Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Date: Thu, 04 Jan 2024 13:38:27 -0800 User-Agent: alot/0.10 Quoting Uwe Kleine-K=C3=B6nig (2024-01-04 10:06:29) > Hello Stephen, >=20 > On Mon, Dec 18, 2023 at 02:01:41PM +0100, Uwe Kleine-K=EF=BF=BDnig wrote: > > [Cc +=3D Maxime] > >=20 > > Hello Stephen, > >=20 > > On Sun, Dec 17, 2023 at 04:17:41PM -0800, Stephen Boyd wrote: > > > Quoting Uwe Kleine-K=EF=BF=BDnig (2023-12-12 10:09:42) > > > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > > > > index af2011c2a93b..78249ca2341c 100644 > > > > --- a/drivers/clk/clk.c > > > > +++ b/drivers/clk/clk.c > > > > @@ -937,6 +937,21 @@ void clk_rate_exclusive_get(struct clk *clk) > > > > } > > > > EXPORT_SYMBOL_GPL(clk_rate_exclusive_get); > > > > =20 > > > > +static void devm_clk_rate_exclusive_put(void *data) > > > > +{ > > > > + struct clk *clk =3D data; > > > > + > > > > + clk_rate_exclusive_put(clk); > > > > +} > > > > + > > > > +int devm_clk_rate_exclusive_get(struct device *dev, struct clk *cl= k) > > > > +{ > > > > + clk_rate_exclusive_get(clk); > > >=20 > > > It seems the other thread wants this to return an error value. > >=20 > > The status quo is that clk_rate_exclusive_get() always returns zero. > > Some users do error handling (which is dead code until Maxime reworks > > the call that it might return something non-zero), others just call it > > without checking. > >=20 > > If you don't require to add something like: > >=20 > > ret =3D clk_rate_exclusive_get(clk); > > if (ret) > > return ret; > >=20 > > where we currently have just > >=20 > > clk_rate_exclusive_get(clk); > >=20 > > the patch can just be applied (using git am -3) not even hitting a merge > > conflict without that other series. >=20 > I wonder what you think about this. This devm_clk_rate_exclusive_get() > would be very useful and simplify a few more drivers. >=20 > Do you intend to take the patch as is, or should I rework it to check > for the zero it returns? >=20 Please check the return value even if it is always zero. The discussion about handling the return value can continue in parallel. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83C8BC47074 for ; Thu, 4 Jan 2024 21:39:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+6w9RMWLzyxIv7Xb+ayRBl/91VmiMkGMd4kvGm7LNac=; b=bajnbJvIfRaaRp Xkxoogc3Tjyvs9FU72/qBosWJK+AnVWGvxXxXWAYyIyZUHgv0zWFN8Tr/sB3qjp4rP8SH38VuTQjK qd6syUL3Xlw+TKRBplf+IK5ehy8o1OT/eusJbY6t8kw3GOKo9wki4+LEHC1hgYxBDG1GWycrOiY/I gfl2BSOWP5XTQKo68fOLBFX58YluWDbxysiWpfDda/UWOYLTA0zjZPnPQCZjgAIpgoGzo8Yad+HVt mwVa5/SDpQRcmQ3gAhmvRx9Yc8ND1dxpVzFZ7muprFm8TngUuBRr1JpbZyMtgmkUt82iD4OHkopxh NC+fewwIJAQNBx48H5Sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rLVQ9-00FHVY-2n; Thu, 04 Jan 2024 21:38:33 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rLVQ6-00FHVB-2j for linux-arm-kernel@lists.infradead.org; Thu, 04 Jan 2024 21:38:32 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1882D61908; Thu, 4 Jan 2024 21:38:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A171BC433C8; Thu, 4 Jan 2024 21:38:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704404309; bh=C6yj4tbn318pdlPF1SHSET3ntYVv+Yq1nuht+eVikeI=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=GuOeNjzs7+jgEt/pSJNL8/o+eEmnqEjgSzbeDRPDlU7FLeASwA+SiFBaysdcbiZJ2 oIs1QY1xa6xwzCiZvoDpPPNrQAZiIF78RafagJ0OaM2wSk1l0EMMm18E+dwxtlN5PF KN5rububvg9JxwK/ZI+MjS2km+QxoA4aVLObgF4oMHTVC0k2PEtFZIZ3wnAddIrhbP u2tkAZgpXu/JhSdZOPxGO7p8BCGozWbnvTM3WmiFzJFoqj/iZjVQfvtE4hyW0EghRn rnZ9UBXxysu8fyq1HAgTvzqJOaJYByyUQuJNvBymlSKv/+3UA72iDXhXHT93R1Kucu 4YR4FwLcQHNVQ== Message-ID: MIME-Version: 1.0 In-Reply-To: References: <744a6371f94fe96f527eea6e52a600914e6fb6b5.1702403904.git.u.kleine-koenig@pengutronix.de> <5391068cdc86b6117920d31a524d934b.sboyd@kernel.org> <3fhgutm42b6sy6gdydcvflnsjuc2ozjetjbeyoxjvnl2t5q7za@4og2x6gqz5y2> Subject: Re: [PATCH 1/2] clk: Add a devm variant of clk_rate_exclusive_get() From: Stephen Boyd Cc: linux-pwm@vger.kernel.org, Sean Anderson , Michael Turquette , Russell King , Maxime Ripard , Thierry Reding , kernel@pengutronix.de, Michal Simek , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org To: Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Date: Thu, 04 Jan 2024 13:38:27 -0800 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240104_133830_968949_94C3367A X-CRM114-Status: GOOD ( 26.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UXVvdGluZyBVd2UgS2xlaW5lLUvDtm5pZyAoMjAyNC0wMS0wNCAxMDowNjoyOSkKPiBIZWxsbyBT dGVwaGVuLAo+IAo+IE9uIE1vbiwgRGVjIDE4LCAyMDIzIGF0IDAyOjAxOjQxUE0gKzAxMDAsIFV3 ZSBLbGVpbmUtS++/vW5pZyB3cm90ZToKPiA+IFtDYyArPSBNYXhpbWVdCj4gPiAKPiA+IEhlbGxv IFN0ZXBoZW4sCj4gPiAKPiA+IE9uIFN1biwgRGVjIDE3LCAyMDIzIGF0IDA0OjE3OjQxUE0gLTA4 MDAsIFN0ZXBoZW4gQm95ZCB3cm90ZToKPiA+ID4gUXVvdGluZyBVd2UgS2xlaW5lLUvvv71uaWcg KDIwMjMtMTItMTIgMTA6MDk6NDIpCj4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvY2xrL2Ns ay5jIGIvZHJpdmVycy9jbGsvY2xrLmMKPiA+ID4gPiBpbmRleCBhZjIwMTFjMmE5M2IuLjc4MjQ5 Y2EyMzQxYyAxMDA2NDQKPiA+ID4gPiAtLS0gYS9kcml2ZXJzL2Nsay9jbGsuYwo+ID4gPiA+ICsr KyBiL2RyaXZlcnMvY2xrL2Nsay5jCj4gPiA+ID4gQEAgLTkzNyw2ICs5MzcsMjEgQEAgdm9pZCBj bGtfcmF0ZV9leGNsdXNpdmVfZ2V0KHN0cnVjdCBjbGsgKmNsaykKPiA+ID4gPiAgfQo+ID4gPiA+ ICBFWFBPUlRfU1lNQk9MX0dQTChjbGtfcmF0ZV9leGNsdXNpdmVfZ2V0KTsKPiA+ID4gPiAgCj4g PiA+ID4gK3N0YXRpYyB2b2lkIGRldm1fY2xrX3JhdGVfZXhjbHVzaXZlX3B1dCh2b2lkICpkYXRh KQo+ID4gPiA+ICt7Cj4gPiA+ID4gKyAgICAgICBzdHJ1Y3QgY2xrICpjbGsgPSBkYXRhOwo+ID4g PiA+ICsKPiA+ID4gPiArICAgICAgIGNsa19yYXRlX2V4Y2x1c2l2ZV9wdXQoY2xrKTsKPiA+ID4g PiArfQo+ID4gPiA+ICsKPiA+ID4gPiAraW50IGRldm1fY2xrX3JhdGVfZXhjbHVzaXZlX2dldChz dHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBjbGsgKmNsaykKPiA+ID4gPiArewo+ID4gPiA+ICsg ICAgICAgY2xrX3JhdGVfZXhjbHVzaXZlX2dldChjbGspOwo+ID4gPiAKPiA+ID4gSXQgc2VlbXMg dGhlIG90aGVyIHRocmVhZCB3YW50cyB0aGlzIHRvIHJldHVybiBhbiBlcnJvciB2YWx1ZS4KPiA+ IAo+ID4gVGhlIHN0YXR1cyBxdW8gaXMgdGhhdCBjbGtfcmF0ZV9leGNsdXNpdmVfZ2V0KCkgYWx3 YXlzIHJldHVybnMgemVyby4KPiA+IFNvbWUgdXNlcnMgZG8gZXJyb3IgaGFuZGxpbmcgKHdoaWNo IGlzIGRlYWQgY29kZSB1bnRpbCBNYXhpbWUgcmV3b3Jrcwo+ID4gdGhlIGNhbGwgdGhhdCBpdCBt aWdodCByZXR1cm4gc29tZXRoaW5nIG5vbi16ZXJvKSwgb3RoZXJzIGp1c3QgY2FsbCBpdAo+ID4g d2l0aG91dCBjaGVja2luZy4KPiA+IAo+ID4gSWYgeW91IGRvbid0IHJlcXVpcmUgdG8gYWRkIHNv bWV0aGluZyBsaWtlOgo+ID4gCj4gPiAgICAgICByZXQgPSBjbGtfcmF0ZV9leGNsdXNpdmVfZ2V0 KGNsayk7Cj4gPiAgICAgICBpZiAocmV0KQo+ID4gICAgICAgICAgICAgICByZXR1cm4gcmV0Owo+ ID4gCj4gPiB3aGVyZSB3ZSBjdXJyZW50bHkgaGF2ZSBqdXN0Cj4gPiAKPiA+ICAgICAgIGNsa19y YXRlX2V4Y2x1c2l2ZV9nZXQoY2xrKTsKPiA+IAo+ID4gdGhlIHBhdGNoIGNhbiBqdXN0IGJlIGFw cGxpZWQgKHVzaW5nIGdpdCBhbSAtMykgbm90IGV2ZW4gaGl0dGluZyBhIG1lcmdlCj4gPiBjb25m bGljdCB3aXRob3V0IHRoYXQgb3RoZXIgc2VyaWVzLgo+IAo+IEkgd29uZGVyIHdoYXQgeW91IHRo aW5rIGFib3V0IHRoaXMuIFRoaXMgZGV2bV9jbGtfcmF0ZV9leGNsdXNpdmVfZ2V0KCkKPiB3b3Vs ZCBiZSB2ZXJ5IHVzZWZ1bCBhbmQgc2ltcGxpZnkgYSBmZXcgbW9yZSBkcml2ZXJzLgo+IAo+IERv IHlvdSBpbnRlbmQgdG8gdGFrZSB0aGUgcGF0Y2ggYXMgaXMsIG9yIHNob3VsZCBJIHJld29yayBp dCB0byBjaGVjawo+IGZvciB0aGUgemVybyBpdCByZXR1cm5zPwo+IAoKUGxlYXNlIGNoZWNrIHRo ZSByZXR1cm4gdmFsdWUgZXZlbiBpZiBpdCBpcyBhbHdheXMgemVyby4gVGhlIGRpc2N1c3Npb24K YWJvdXQgaGFuZGxpbmcgdGhlIHJldHVybiB2YWx1ZSBjYW4gY29udGludWUgaW4gcGFyYWxsZWwu CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1h cm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0t a2VybmVsCg==