diff for duplicates of <c1f01855-e05c-2435-0fa0-e159b47fa065@users.sourceforge.net> diff --git a/a/1.txt b/N1/1.txt index a20fb44..93065b7 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,7 +6,7 @@ Content-Transfer-Encoding: 8bit The script "checkpatch.pl" pointed information out like the following. -Comparison to NULL could be written … +Comparison to NULL could be written … Thus fix the affected source code places. @@ -36,7 +36,7 @@ index 3347fa14..fff1ece 100644 struct v4l2_output output; int ret; -- if (config->chan_config[ch->channel_id].outputs = NULL) +- if (config->chan_config[ch->channel_id].outputs == NULL) + if (!config->chan_config[ch->channel_id].outputs) return -ENODATA; @@ -45,7 +45,7 @@ index 3347fa14..fff1ece 100644 struct vpif_display_chan_config *chan_cfg; struct v4l2_output output; -- if (config->chan_config[ch->channel_id].outputs = NULL) +- if (config->chan_config[ch->channel_id].outputs == NULL) + if (!config->chan_config[ch->channel_id].outputs) return -ENODATA; @@ -54,12 +54,12 @@ index 3347fa14..fff1ece 100644 vpif_dbg(2, debug, "vpif_output_to_subdev\n"); -- if (chan_cfg->outputs = NULL) +- if (chan_cfg->outputs == NULL) + if (!chan_cfg->outputs) return -1; subdev_name = chan_cfg->outputs[index].subdev_name; -- if (subdev_name = NULL) +- if (subdev_name == NULL) + if (!subdev_name) return -1; @@ -77,7 +77,7 @@ index 3347fa14..fff1ece 100644 struct v4l2_output output; int ret; -- if (config->chan_config[ch->channel_id].outputs = NULL) +- if (config->chan_config[ch->channel_id].outputs == NULL) + if (!config->chan_config[ch->channel_id].outputs) return -ENODATA; @@ -86,7 +86,7 @@ index 3347fa14..fff1ece 100644 struct v4l2_output output; int ret; -- if (config->chan_config[ch->channel_id].outputs = NULL) +- if (config->chan_config[ch->channel_id].outputs == NULL) + if (!config->chan_config[ch->channel_id].outputs) return -ENODATA; @@ -95,7 +95,7 @@ index 3347fa14..fff1ece 100644 struct video_obj *vid_ch = &ch->video; struct v4l2_output output; -- if (config->chan_config[ch->channel_id].outputs = NULL) +- if (config->chan_config[ch->channel_id].outputs == NULL) + if (!config->chan_config[ch->channel_id].outputs) goto error; @@ -104,15 +104,10 @@ index 3347fa14..fff1ece 100644 subdev_count = vpif_obj.config->subdev_count; subdevdata = vpif_obj.config->subdevinfo; vpif_obj.sd = kcalloc(subdev_count, sizeof(*vpif_obj.sd), GFP_KERNEL); -- if (vpif_obj.sd = NULL) { +- if (vpif_obj.sd == NULL) { + if (!vpif_obj.sd) { err = -ENOMEM; goto vpif_unregister; } -- 2.10.1 - --- -To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 7f85aba..70e0eb5 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\0a99f89f2-a3be-9b5f-95c1-e0912a7d78f3@users.sourceforge.net\0" "From\0SF Markus Elfring <elfring@users.sourceforge.net>\0" "Subject\0[PATCH 32/34] [media] DaVinci-VPIF-Display: Adjust 11 checks for null pointers\0" - "Date\0Wed, 12 Oct 2016 15:13:50 +0000\0" + "Date\0Wed, 12 Oct 2016 17:13:50 +0200\0" "To\0linux-media@vger.kernel.org" Hans Verkuil <hans.verkuil@cisco.com> Lad @@ -20,7 +20,7 @@ "\n" "The script \"checkpatch.pl\" pointed information out like the following.\n" "\n" - "Comparison to NULL could be written \303\242\342\202\254\302\246\n" + "Comparison to NULL could be written \342\200\246\n" "\n" "Thus fix the affected source code places.\n" "\n" @@ -50,7 +50,7 @@ " \tstruct v4l2_output output;\n" " \tint ret;\n" " \n" - "-\tif (config->chan_config[ch->channel_id].outputs = NULL)\n" + "-\tif (config->chan_config[ch->channel_id].outputs == NULL)\n" "+\tif (!config->chan_config[ch->channel_id].outputs)\n" " \t\treturn -ENODATA;\n" " \n" @@ -59,7 +59,7 @@ " \tstruct vpif_display_chan_config *chan_cfg;\n" " \tstruct v4l2_output output;\n" " \n" - "-\tif (config->chan_config[ch->channel_id].outputs = NULL)\n" + "-\tif (config->chan_config[ch->channel_id].outputs == NULL)\n" "+\tif (!config->chan_config[ch->channel_id].outputs)\n" " \t\treturn -ENODATA;\n" " \n" @@ -68,12 +68,12 @@ " \n" " \tvpif_dbg(2, debug, \"vpif_output_to_subdev\\n\");\n" " \n" - "-\tif (chan_cfg->outputs = NULL)\n" + "-\tif (chan_cfg->outputs == NULL)\n" "+\tif (!chan_cfg->outputs)\n" " \t\treturn -1;\n" " \n" " \tsubdev_name = chan_cfg->outputs[index].subdev_name;\n" - "-\tif (subdev_name = NULL)\n" + "-\tif (subdev_name == NULL)\n" "+\tif (!subdev_name)\n" " \t\treturn -1;\n" " \n" @@ -91,7 +91,7 @@ " \tstruct v4l2_output output;\n" " \tint ret;\n" " \n" - "-\tif (config->chan_config[ch->channel_id].outputs = NULL)\n" + "-\tif (config->chan_config[ch->channel_id].outputs == NULL)\n" "+\tif (!config->chan_config[ch->channel_id].outputs)\n" " \t\treturn -ENODATA;\n" " \n" @@ -100,7 +100,7 @@ " \tstruct v4l2_output output;\n" " \tint ret;\n" " \n" - "-\tif (config->chan_config[ch->channel_id].outputs = NULL)\n" + "-\tif (config->chan_config[ch->channel_id].outputs == NULL)\n" "+\tif (!config->chan_config[ch->channel_id].outputs)\n" " \t\treturn -ENODATA;\n" " \n" @@ -109,7 +109,7 @@ " \tstruct video_obj *vid_ch = &ch->video;\n" " \tstruct v4l2_output output;\n" " \n" - "-\tif (config->chan_config[ch->channel_id].outputs = NULL)\n" + "-\tif (config->chan_config[ch->channel_id].outputs == NULL)\n" "+\tif (!config->chan_config[ch->channel_id].outputs)\n" " \t\tgoto error;\n" " \n" @@ -118,17 +118,12 @@ " \tsubdev_count = vpif_obj.config->subdev_count;\n" " \tsubdevdata = vpif_obj.config->subdevinfo;\n" " \tvpif_obj.sd = kcalloc(subdev_count, sizeof(*vpif_obj.sd), GFP_KERNEL);\n" - "-\tif (vpif_obj.sd = NULL) {\n" + "-\tif (vpif_obj.sd == NULL) {\n" "+\tif (!vpif_obj.sd) {\n" " \t\terr = -ENOMEM;\n" " \t\tgoto vpif_unregister;\n" " \t}\n" "-- \n" - "2.10.1\n" - "\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe kernel-janitors\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + 2.10.1 -3e88aec9f87611a180dd899ff73f2890b8a84ad87291db21cfbdf399535f6a0f +4388d4044eb7fe02588df19e68f6decc8ca1c2c39626d0c6cf87fcb3257cbb5c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.