All of lore.kernel.org
 help / color / mirror / Atom feed
From: WX Chen <wxchen0913@gmail.com>
To: Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>,
	qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Chao Liu" <chao.liu.zevorn@gmail.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Alistair Francis" <alistair.francis@wdc.com>,
	"Weiwei Li" <liwei1518@gmail.com>,
	"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>,
	qemu-riscv@nongnu.org, "Fabiano Rosas" <farosas@suse.de>,
	"Laurent Vivier" <lvivier@redhat.com>
Subject: Re: [PATCH RESEND v2 3/3] tests/qtest: add K230 UART test
Date: Fri, 7 Aug 2026 19:53:05 +0800	[thread overview]
Message-ID: <c201c673-eee6-474b-ace2-03f36d004858@gmail.com> (raw)
In-Reply-To: <af3d837c-e7f2-48ce-9b9c-c2ea9e4d8fb8@oss.qualcomm.com>


Hi Daniel,

Thanks for the review!


On 8/6/26 04:10, Daniel Henrique Barboza wrote:
>
> Any reason to use g_usleep() instead of qtest_clock_step()?  There are 
> a couple
> of g_usleep() uses in the code but you used lots of qtest_clock_step() 
> too.
>
> AFAIK g_usleep() is wall time and qtest_clock_step() is simulated 
> time, and
> I guess you should be using qtest_clock_step() for all the pollings 
> you're
> doing in this file.
>

You're right, there's no reason to mix them here. I'll fix this in v3.


Regards,

WX Chen




      reply	other threads:[~2026-08-07 11:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-25  3:52 [PATCH RESEND v2 0/3] riscv: Add K230 DW 8250-compatible UART WX Chen
2026-07-25  3:52 ` [PATCH RESEND v2 1/3] hw/char: add " WX Chen
2026-08-05 20:01   ` Daniel Henrique Barboza
2026-08-07  9:49     ` zhenbaii
2026-07-25  3:52 ` [PATCH RESEND v2 2/3] hw/riscv: k230: connect DW 8250 UART WX Chen
2026-08-05 20:02   ` Daniel Henrique Barboza
2026-07-25  3:52 ` [PATCH RESEND v2 3/3] tests/qtest: add K230 UART test WX Chen
2026-08-05 20:10   ` Daniel Henrique Barboza
2026-08-07 11:53     ` WX Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c201c673-eee6-474b-ace2-03f36d004858@gmail.com \
    --to=wxchen0913@gmail.com \
    --cc=alistair.francis@wdc.com \
    --cc=chao.liu.zevorn@gmail.com \
    --cc=daniel.barboza@oss.qualcomm.com \
    --cc=farosas@suse.de \
    --cc=liwei1518@gmail.com \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=palmer@dabbelt.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=zhiwei_liu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.