From: Eric Blake <eblake@redhat.com>
To: minyard@acm.org, Bug 1651167 <1651167@bugs.launchpad.net>,
qemu-devel@nongnu.org
Cc: Corey Minyard <cminyard@mvista.com>
Subject: Re: [Qemu-devel] [PATCH v2] ipmi: Fix macro issues
Date: Thu, 22 Dec 2016 16:17:48 -0600 [thread overview]
Message-ID: <c2115571-c5cc-ca63-3e54-cc0430fa9680@redhat.com> (raw)
In-Reply-To: <1482434287-26044-1-git-send-email-minyard@acm.org>
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
On 12/22/2016 01:18 PM, minyard@acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>
>
> Macro parameters should almost always have () around them when used.
> llvm reported an error on this.
>
> Remove redundant parenthesis and put parenthesis around the entire
> macros with assignments in case they are used in an expression.
>
> Remove some unused macros.
>
> Reported in https://bugs.launchpad.net/bugs/1651167
>
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
> ---
> hw/ipmi/isa_ipmi_bt.c | 34 ++++++++++++----------------------
> 1 file changed, 12 insertions(+), 22 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-12-22 22:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 15:47 [Qemu-devel] [Bug 1651167] [NEW] hw/ipmi/isa_ipmi_bt.c:283: suspect use of macro ? dcb
2016-12-22 14:20 ` Corey Minyard
2016-12-22 14:25 ` [Qemu-devel] [Bug 1651167] " cminyard
2016-12-22 14:30 ` [Qemu-devel] [PATCH] ipmi: Add parenthesis around some macro parameters minyard
2016-12-22 15:01 ` Eric Blake
2016-12-22 17:48 ` Corey Minyard
2016-12-22 19:18 ` [Qemu-devel] [PATCH v2] ipmi: Fix macro issues minyard
2016-12-22 22:17 ` Eric Blake [this message]
2016-12-23 14:07 ` [Qemu-devel] [PATCH v3] " minyard
2017-03-30 16:10 ` [Qemu-devel] [PATCH for-2.9? " Eric Blake
2017-04-24 7:38 ` [Qemu-devel] [Bug 1651167] Re: hw/ipmi/isa_ipmi_bt.c:283: suspect use of macro ? Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2115571-c5cc-ca63-3e54-cc0430fa9680@redhat.com \
--to=eblake@redhat.com \
--cc=1651167@bugs.launchpad.net \
--cc=cminyard@mvista.com \
--cc=minyard@acm.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.