From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 541CEC3ABA5 for ; Tue, 29 Apr 2025 17:24:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u9ogw-0007tX-Ly; Tue, 29 Apr 2025 13:24:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9ogo-0007Tn-7N for qemu-riscv@nongnu.org; Tue, 29 Apr 2025 13:24:15 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u9ogl-0001fT-Im for qemu-riscv@nongnu.org; Tue, 29 Apr 2025 13:24:13 -0400 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-22409077c06so101139435ad.1 for ; Tue, 29 Apr 2025 10:24:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1745947450; x=1746552250; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=h838S+PEIw0WKsswku0EbN0h1I/N/caDw+cTunuN/es=; b=kmmaSbdJd8V+ERm+HN60lTcLbvK0iwf/O+UNQKB6wrWOXyNIU4qOHfQjoXvpofHfVH 1W+IHx3/CqdpGgR0XCcznXp9fEyGtpXFlsawOR2zzQFvSfpj1k1asL35MO+dzp0ywYtp D7AAh5wphQg0ioDDxaOLs+BW/SysSB+a+Th9emyZi8yX/kr6bv+9YcUJJGD1pLc8g604 NnoRV1b48uwUwz4XsDaGqfy17ZQmgFrbzNzsfKKaIPL0vEaSg0oQoDntScyz+TB8dw6S DP0AK5BEBelqEAMHpH27Ho7OZKeQcyCL+zEWgZnUe2K3eU1+XL7KFlxXUqqxwg1ZxU4f TBdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745947450; x=1746552250; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h838S+PEIw0WKsswku0EbN0h1I/N/caDw+cTunuN/es=; b=mnsPov/+GGVAXAiG/Rw0DIDRNrd93H3+8MzcDzyw4Qp7wL2psYTmY7A3GQvDB1Ok1I yxEjU8a29yUUqAaDkjxdRzS8yMWg2I/7942e8pxVgFmofKVWoIrUNHS2PI9nCknfC2Jh woA/5YmoNbs42ljROoQH0WvuW7xbfe/LRi7QnORCv/AII0F/X5QYeimPKuFXP0W/j1tg 9j6NsRZWBQ/YUOlyLTQ2Cfdg0VQd62MLdb7/Zg4XCozwzsA8cRu3VcSMlPq7wKhWlfmT kU52KiW3Twy4UhQ5xeGSilsjI64+dVOfUkC5rqssu0490OhJItCvktmGD1a3wNjVE2nf 4mKQ== X-Gm-Message-State: AOJu0Yz/GLPIXbPJu5jtctzuM5ASwJG3n3LqA0xxiMOMVfJZv/TgdbrC PCbHzJuhliYrt9wvK7kctK2db+VJzGYS3f/HBNI9KlV9ACzSksPdoo/YP8lU3bY= X-Gm-Gg: ASbGncvAbHcJYvbT0PKaO1bcYH9od7LoAhyJSRsOP+avLmtU4tIHdHLJegFF2RWRdVo r/iYewxWb499oCEZprWTVC1LSRnhN06EitaWUCtC6VF4wwLNuMPAg2W4N872pQq5VxR3YLp/dqC Q0iLOEDOSQgIs4bIJIYowvB4TXUIOpmNDFqD0IE5qHoLM2+7yHvbQlfTlCO5xuyk7inrDOHrNvk zs0qpaqeD20uYxTw5Bg3mirjatIYw72gtW1tbfMm4sCG9CR4jIYAGeMRWjrsbSXgNLXcFDvW5c1 RPlFtfQBfgZ8WL+E4gng8S+c/6fvmKiBayRhq8jZZbeqtJ6NLs7PI0U= X-Google-Smtp-Source: AGHT+IFRsP2CFCFvtJujXh9w/9cqNdaAfa/cD3HzvtapxYBfVDBUmDI0jRDU1Qu0kK3rqyFxCsw0/A== X-Received: by 2002:a17:902:f685:b0:224:1219:934b with SMTP id d9443c01a7336-22df3591151mr2606785ad.50.1745947450049; Tue, 29 Apr 2025 10:24:10 -0700 (PDT) Received: from [192.168.68.110] ([152.234.125.33]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db510283bsm105620235ad.200.2025.04.29.10.24.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Apr 2025 10:24:09 -0700 (PDT) Message-ID: Date: Tue, 29 Apr 2025 14:24:07 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/13] hw/riscv/virt: Use setprop_sized_cells for uart To: Joel Stanley Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org References: <20250429061223.1457166-1-joel@jms.id.au> <20250429061223.1457166-11-joel@jms.id.au> Content-Language: en-US From: Daniel Henrique Barboza In-Reply-To: <20250429061223.1457166-11-joel@jms.id.au> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=dbarboza@ventanamicro.com; helo=mail-pl1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org On 4/29/25 3:12 AM, Joel Stanley wrote: > The current device tree property uses two cells for the address (and for > the size), but assumes the they are less than 32 bits by hard coding the > high cell to zero. > > Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper > and lower 32 bits across cells. > > Signed-off-by: Joel Stanley > --- Reviewed-by: Daniel Henrique Barboza > hw/riscv/virt.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c > index baa894b11aa6..d9303c9bb033 100644 > --- a/hw/riscv/virt.c > +++ b/hw/riscv/virt.c > @@ -966,9 +966,9 @@ static void create_fdt_uart(RISCVVirtState *s, > s->memmap[VIRT_UART0].base); > qemu_fdt_add_subnode(ms->fdt, name); > qemu_fdt_setprop_string(ms->fdt, name, "compatible", "ns16550a"); > - qemu_fdt_setprop_cells(ms->fdt, name, "reg", > - 0x0, s->memmap[VIRT_UART0].base, > - 0x0, s->memmap[VIRT_UART0].size); > + qemu_fdt_setprop_sized_cells(ms->fdt, name, "reg", > + 2, s->memmap[VIRT_UART0].base, > + 2, s->memmap[VIRT_UART0].size); > qemu_fdt_setprop_cell(ms->fdt, name, "clock-frequency", 3686400); > qemu_fdt_setprop_cell(ms->fdt, name, "interrupt-parent", irq_mmio_phandle); > if (s->aia_type == VIRT_AIA_TYPE_NONE) {