From: Krzysztof Kozlowski <krzk@kernel.org>
To: Guangshuo Li <lgs201920130244@gmail.com>,
Ajay Gupta <ajayg@nvidia.com>, Andi Shyti <andi.shyti@kernel.org>,
Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] i2c: nvidia-gpu: fix autosuspend cleanup
Date: Thu, 20 Aug 2026 16:48:18 +0200 [thread overview]
Message-ID: <c2434012-7bcb-42fc-b520-8fbc71db196f@kernel.org> (raw)
In-Reply-To: <20260812092322.3423217-1-lgs201920130244@gmail.com>
On 12/08/2026 11:23, Guangshuo Li wrote:
> gpu_i2c_probe() calls pm_runtime_use_autosuspend(), but the remove
> path does not call the matching pm_runtime_dont_use_autosuspend().
>
> If the autosuspend delay is set to a negative value while autosuspend
> is enabled, the runtime PM core increments usage_count to prevent
> runtime suspend. Without undoing the autosuspend setting during
> teardown, this reference is not dropped and usage_count remains
> unbalanced.
>
> Call pm_runtime_dont_use_autosuspend() during driver removal to
> properly undo the autosuspend setting.
>
> This issue was found by manual code inspection.
>
> Fixes: d4a4f927e4dd ("i2c: nvidia-gpu: add runtime pm support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
You sent vast amount of patches, all separate, making it very difficult
to track and respond in efficient way. Do not do that.
Group your work per subsystem.
You were asked to clarify and respond to incorrect fixes statement. I do
not see how you clarified and responded at all.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-08-20 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 9:23 [PATCH] i2c: nvidia-gpu: fix autosuspend cleanup Guangshuo Li
2026-08-20 14:48 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2434012-7bcb-42fc-b520-8fbc71db196f@kernel.org \
--to=krzk@kernel.org \
--cc=ajayg@nvidia.com \
--cc=andi.shyti@kernel.org \
--cc=lgs201920130244@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.