From: AlanSong-oc <AlanSong-oc@zhaoxin.com>
To: Eric Biggers <ebiggers@kernel.org>,
<linux-crypto@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: <linux-kernel@vger.kernel.org>, larryw3i <larryw3i@yeah.net>,
<stable@vger.kernel.org>, <CobeChen@zhaoxin.com>,
<GeorgeXue@zhaoxin.com>, <HansHu@zhaoxin.com>,
<LeoLiu-oc@zhaoxin.com>, <TonyWWang-oc@zhaoxin.com>,
<YunShen@zhaoxin.com>
Subject: Re: [PATCH] crypto: padlock-sha - Disable broken driver
Date: Mon, 17 Nov 2025 17:03:17 +0800 [thread overview]
Message-ID: <c24d0582-ae94-4dfb-ae6f-6baafa7fe689@zhaoxin.com> (raw)
In-Reply-To: <20251116183926.3969-1-ebiggers@kernel.org>
On 11/17/2025 2:39 AM, Eric Biggers wrote:
> This driver is known broken, as it computes the wrong SHA-1 and SHA-256
> hashes. Correctness needs to be the first priority for cryptographic
> code. Just disable it, allowing the standard (and actually correct)
> SHA-1 and SHA-256 implementations to take priority.
>
Following Herbert Xu's
suggestion（https://lore.kernel.org/linux-crypto/aFkdNoQFmr8-x4cu@gondor.apana.org.au/）,
we have prepared a new version of the patch to address this issue. Since
the code needs to remain compatible with older platforms, we are still
conducting extensive testing. Once the testing is complete, I will
submit the finalized patch immediately.
Best Regards
AlanSong-oc
next prev parent reply other threads:[~2025-11-17 9:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a1ed50c2-7338-4c97-8c36-84d2fa83d018@yeah.net>
2025-11-16 15:50 ` linux-image-amd64: self-tests for sha256 using sha256-padlock-nano failed larryw3i
2025-11-16 18:39 ` [PATCH] crypto: padlock-sha - Disable broken driver Eric Biggers
2025-11-17 9:03 ` AlanSong-oc [this message]
2025-11-17 10:08 ` larryw3i
2025-11-18 8:22 ` AlanSong-oc
2025-11-19 3:41 ` larryw3i
2025-11-18 3:34 ` Herbert Xu
2025-11-18 4:02 ` Eric Biggers
2025-12-17 4:30 ` AlanSong-oc
2025-12-17 4:56 ` Herbert Xu
2025-12-17 9:04 ` AlanSong-oc
2026-01-06 14:47 ` larryw3i
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c24d0582-ae94-4dfb-ae6f-6baafa7fe689@zhaoxin.com \
--to=alansong-oc@zhaoxin.com \
--cc=CobeChen@zhaoxin.com \
--cc=GeorgeXue@zhaoxin.com \
--cc=HansHu@zhaoxin.com \
--cc=LeoLiu-oc@zhaoxin.com \
--cc=TonyWWang-oc@zhaoxin.com \
--cc=YunShen@zhaoxin.com \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=larryw3i@yeah.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.