All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Spinler <mspinler@linux.ibm.com>
To: James Feist <james.feist@linux.intel.com>,
	OpenBMC Maillist <openbmc@lists.ozlabs.org>
Cc: Ratan Gupta <ratagupt@linux.vnet.ibm.com>,
	"Bills, Jason M" <jason.m.bills@linux.intel.com>
Subject: Re: Message registries continuation
Date: Tue, 23 Jun 2020 13:02:45 -0500	[thread overview]
Message-ID: <c24ff8ab-a12f-5137-368c-0dfd9bccc15b@linux.ibm.com> (raw)
In-Reply-To: <5d7fba06-b5fd-2fce-d05e-7f2b99069a2e@linux.intel.com>



On 6/22/2020 4:16 PM, James Feist wrote:
> On 6/22/2020 1:46 PM, Matt Spinler wrote:
>> Hi James,
>>
>> Something I forgot below - when building up our event logs, I have 
>> about a dozen fields (mostly OEM)
>> that I have to get from the OpenBMC event log's corresponding PEL 
>> (IBM's enterprise log format).
>>
>> PELs aren't on D-Bus for a few reasons, such as they can be several 
>> KB in size and consist of several
>> dozen discrete fields, so that rules out bmcweb getting them that way.
>
> Would doing something like having the fields in the journal with a 
> link to a file work? See this design for more info: 
> https://github.com/openbmc/docs/blob/master/architecture/redfish-logging-in-bmcweb.md
>

I forgot to mention that this would use the existing D-Bus based event 
log code, and just add new fields
to those responses.  At  this point, I don't think I can use the journal 
because I need to ensure the lifetime
of the errors matches that of the event logs on D-Bus and the PELs 
themselves.

>>
>> I do have a shared library that has the PEL APIs I need (PELs 
>> themselves are in files). Is it OK if I
>> just link in that library as needed when a USE_PELs or whatever 
>> option is set?
>> Alternatively, I could also dlopen it I suppose.
>
> There's another thread over here 
> https://lists.ozlabs.org/pipermail/openbmc/2020-June/022082.html 
> happening right now discussing types of logging. As we already have 2 
> forms of logging supported, I'm a little hesitant to the idea of a 
> third without at least some formal direction of what we want logging 
> to look like as a project. More so as we add advanced features on top 
> of logging, it makes it more difficult to support different methods.
>

This would just be an enhancement to the 2nd form that exists today, the 
D-Bus based one, but yea, I can
wait and see how that thread shakes out.


>>
>> Just trying to avoid a surprise during review.
>>
>> Thanks
>>
>

      reply	other threads:[~2020-06-23 18:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-16 19:47 Message registries continuation Matt Spinler
2020-06-16 20:39 ` James Feist
2020-06-16 20:50   ` Patrick Williams
2020-06-16 20:58     ` James Feist
2020-06-16 21:30   ` Matt Spinler
2020-06-16 21:57     ` James Feist
2020-06-18 15:23   ` Brad Bishop
2020-06-22 20:46   ` Matt Spinler
2020-06-22 21:16     ` James Feist
2020-06-23 18:02       ` Matt Spinler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c24ff8ab-a12f-5137-368c-0dfd9bccc15b@linux.ibm.com \
    --to=mspinler@linux.ibm.com \
    --cc=james.feist@linux.intel.com \
    --cc=jason.m.bills@linux.intel.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=ratagupt@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.