All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sourabh Banerjee" <sbanerje@codeaurora.org>
To: openembedded-core@lists.openembedded.org, steve@sakoman.com
Cc: vkraleti@codeaurora.org, ndeche@codeaurora.org,
	himalg@codeaurora.org,
	Richard Purdie <richard.purdie@linuxfoundation.org>
Subject: Re: [Dunfell][PATCH] layer.conf: fix sanity error for PATH variable in extensible SDK workflow
Date: Wed, 03 Feb 2021 21:54:07 +0530	[thread overview]
Message-ID: <c26b70b89acf21df70c8be98c1797baf@codeaurora.org> (raw)
In-Reply-To: <1612369223-5608-1-git-send-email-sbanerje@codeaurora.org>

On 2021-02-03 21:50, Sourabh Banerjee wrote:
> Sanity checker reports following error for the PATH variable,
> when bitbake -e <recipe> command is run in an extensible SDK workspace.
>    PATH contains '.', './' or '' (empty element), which will break the 
> build
> 
> In case of extensible SDK, PATH variable is formed with two consecutive 
> ':'
> as bb.utils.which(d.getVar('PATH'),'bitbake') call returns an empty 
> string.
> 
> This change adds ':' if BITBAKEPATH is a non empty string.
> 
> (From OE-Core rev: 05a87be51b44608ce4f77ac332df90a3cd2445ef)
> 
> Signed-off-by: Sourabh Banerjee <sbanerje@codeaurora.org>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/conf/layer.conf | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/conf/layer.conf b/meta/conf/layer.conf
> index d593492..2d9cd05 100644
> --- a/meta/conf/layer.conf
> +++ b/meta/conf/layer.conf
> @@ -102,4 +102,6 @@ SSTATE_EXCLUDEDEPS_SYSROOT += "\
>  SSTATE_EXCLUDEDEPS_SYSROOT += ".*->autoconf-archive-native"
> 
>  # We need to keep bitbake tools in PATH
> -PATH :=
> "${@os.path.dirname(bb.utils.which(d.getVar('PATH'),'bitbake'))}:${HOSTTOOLS_DIR}"
> +# Avoid empty path entries
> +BITBAKEPATH :=
> "${@os.path.dirname(bb.utils.which(d.getVar('PATH'),'bitbake'))}"
> +PATH := "${@'${BITBAKEPATH}:' if '${BITBAKEPATH}' is not '' else
> ''}${HOSTTOOLS_DIR}"

Hi Steve,

This is a backport from from master to Dunfell.

Regards,
Sourabh


-- 
Regards,
Sourabh

  reply	other threads:[~2021-02-03 16:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03 16:20 [Dunfell][PATCH] layer.conf: fix sanity error for PATH variable in extensible SDK workflow Sourabh Banerjee
2021-02-03 16:24 ` Sourabh Banerjee [this message]
2021-02-03 16:33   ` [OE-core] " Steve Sakoman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c26b70b89acf21df70c8be98c1797baf@codeaurora.org \
    --to=sbanerje@codeaurora.org \
    --cc=himalg@codeaurora.org \
    --cc=ndeche@codeaurora.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    --cc=steve@sakoman.com \
    --cc=vkraleti@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.