From: Damien Le Moal <dlemoal@kernel.org>
To: Christoph Hellwig <hch@lst.de>, djwong@kernel.org
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, axboe@kernel.dk,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
syzbot+4a08ffdf3667b36650a1@syzkaller.appspotmail.com
Subject: Re: [PATCH] iomap: handle error conditions more gracefully in iomap_to_bh
Date: Wed, 6 Sep 2023 10:18:32 +0900 [thread overview]
Message-ID: <c27f7736-33b6-71ea-97aa-81bcbce342e8@kernel.org> (raw)
In-Reply-To: <20230905124120.325518-1-hch@lst.de>
On 9/5/23 21:41, Christoph Hellwig wrote:
> iomap_to_bh currently BUG()s when the passed in block number is not
> in the iomap. For file systems that have proper synchronization this
> should never happen and so far hasn't in mainline, but for block devices
> size changes aren't fully synchronized against ongoing I/O. Instead
> of BUG()ing in this case, return -EIO to the caller, which already has
> proper error handling. While we're at it, also return -EIO for an
> unknown iomap state instead of returning garbage.
>
> Fixes: 487c607df790 ("block: use iomap for writes to block devices")
> Reported-by: syzbot+4a08ffdf3667b36650a1@syzkaller.appspotmail.com
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2023-09-06 1:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 12:41 [PATCH] iomap: handle error conditions more gracefully in iomap_to_bh Christoph Hellwig
2023-09-05 15:39 ` Darrick J. Wong
2023-09-05 15:53 ` Christoph Hellwig
2023-09-06 14:30 ` Christian Brauner
2023-09-06 14:54 ` Darrick J. Wong
2023-09-06 1:18 ` Damien Le Moal [this message]
2023-09-06 9:26 ` Hannes Reinecke
2023-09-06 14:31 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c27f7736-33b6-71ea-97aa-81bcbce342e8@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=syzbot+4a08ffdf3667b36650a1@syzkaller.appspotmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.